Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1172930/?format=api
{ "id": 1172930, "url": "http://patchwork.ozlabs.org/api/patches/1172930/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1570288803-14880-1-git-send-email-manjunath.b.patil@oracle.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1570288803-14880-1-git-send-email-manjunath.b.patil@oracle.com>", "list_archive_url": null, "date": "2019-10-05T15:20:03", "name": "[1/1] ixgbe: protect TX timestamping from API misuse", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "044b7f43db40490153984e7d038744ad6161e443", "submitter": { "id": 77602, "url": "http://patchwork.ozlabs.org/api/people/77602/?format=api", "name": "Manjunath Patil", "email": "manjunath.b.patil@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1570288803-14880-1-git-send-email-manjunath.b.patil@oracle.com/mbox/", "series": [ { "id": 134683, "url": "http://patchwork.ozlabs.org/api/series/134683/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=134683", "date": "2019-10-05T15:20:03", "name": "[1/1] ixgbe: protect TX timestamping from API misuse", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/134683/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1172930/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1172930/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=oracle.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=oracle.com header.i=@oracle.com\n\theader.b=\"i5OLs3ua\"; dkim-atps=neutral" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 46n6jP2YNDz9sCJ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 8 Oct 2019 04:22:00 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8B0D42040C;\n\tMon, 7 Oct 2019 17:21:58 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id J6rAhs3GvlsM; Mon, 7 Oct 2019 17:21:56 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 2D069203CE;\n\tMon, 7 Oct 2019 17:21:56 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 535591BF331\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 5 Oct 2019 15:19:36 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4EDFC880A1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 5 Oct 2019 15:19:36 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id GM2sz+Zd7Eda for <intel-wired-lan@lists.osuosl.org>;\n\tSat, 5 Oct 2019 15:19:35 +0000 (UTC)", "from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id B67F187F73\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 5 Oct 2019 15:19:35 +0000 (UTC)", "from pps.filterd (aserp2120.oracle.com [127.0.0.1])\n\tby aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx95F91aW050859; Sat, 5 Oct 2019 15:19:27 GMT", "from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70])\n\tby aserp2120.oracle.com with ESMTP id 2vek4q1jdn-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Sat, 05 Oct 2019 15:19:27 +0000", "from pps.filterd (aserp3020.oracle.com [127.0.0.1])\n\tby aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx95FEFGO195351; Sat, 5 Oct 2019 15:19:26 GMT", "from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72])\n\tby aserp3020.oracle.com with ESMTP id 2vek0bbwud-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Sat, 05 Oct 2019 15:19:26 +0000", "from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16])\n\tby userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id\n\tx95FJNwb016063; Sat, 5 Oct 2019 15:19:23 GMT", "from manjunathpatil.us.oracle.com (/10.211.44.52)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Sat, 05 Oct 2019 08:19:23 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;\n\th=from : to : cc :\n\tsubject : date : message-id; s=corp-2019-08-05;\n\tbh=oGOdeFTOCYRQYQ9d+ryLcttvRz8VQfHVuZKZJpIb3AM=;\n\tb=i5OLs3uaETaLdVpgLC/nr1i72eDrj2nkFOz9dZFaD560e6XilneBOxYRMxGXxJirAzSq\n\t9tRYyrQfVVE8sNNFNLscVpwHrXngJIFEg+NSnqVM4ewqzNQX5knoX/UnL9ZhI/pFq6u8\n\tCSzF4ZDiRIk6YgVMqfZ+DImQEBWJxIuOJdDgrm6MW5BKxPlbsXZB0oUWIhfVJ1y8Nz+2\n\t14Zc+P75fv5lLwI4ieOfedRFbjHviA2u0gKhT9x/bFkRDgeekbSfd3t0MvxLiINsnEGi\n\t6MQ67x9nEeg1zApzWDuC4qhSCCEo68H7tlRYKQ5OuibkwSxEC1GUOhbtjzuiVQ83auNY\n\tAg== ", "From": "Manjunath Patil <manjunath.b.patil@oracle.com>", "To": "jeffrey.t.kirsher@intel.com, davem@davemloft.net,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org", "Date": "Sat, 5 Oct 2019 08:20:03 -0700", "Message-Id": "<1570288803-14880-1-git-send-email-manjunath.b.patil@oracle.com>", "X-Mailer": "git-send-email 1.7.1", "X-Proofpoint-Virus-Version": [ "vendor=nai engine=6000 definitions=9401\n\tsignatures=668684", "vendor=nai engine=6000 definitions=9401\n\tsignatures=668684" ], "X-Proofpoint-Spam-Details": [ "rule=notspam policy=default score=0 suspectscore=0\n\tmalwarescore=0\n\tphishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999\n\tadultscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1908290000 definitions=main-1910050154", "rule=notspam policy=default score=0\n\tpriorityscore=1501 malwarescore=0\n\tsuspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011\n\tlowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999\n\tadultscore=0\n\tclassifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1908290000\n\tdefinitions=main-1910050154" ], "X-Mailman-Approved-At": "Mon, 07 Oct 2019 17:21:54 +0000", "Subject": "[Intel-wired-lan] [PATCH 1/1] ixgbe: protect TX timestamping from\n\tAPI misuse", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "manjunath.b.patil@oracle.com, christophe.jaillet@wanadoo.fr,\n\tcspradlin@google.com", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "HW timestamping can only be requested for a packet if the NIC is first\nsetup via ioctl(SIOCSHWTSTAMP). If this step was skipped, then the ixgbe\ndriver still allowed TX packets to request HW timestamping. In this\nsituation, we see 'clearing Tx Timestamp hang' noise in the log.\n\nFix this by checking that the NIC is configured for HW TX timestamping\nbefore accepting a HW TX timestamping request.\n\nsimilar-to:\n\t(26bd4e2 igb: protect TX timestamping from API misuse)\n\t(0a6f2f0 igb: Fix a test with HWTSTAMP_TX_ON)\n\nSigned-off-by: Manjunath Patil <manjunath.b.patil@oracle.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 1ce2397..dd24aeb 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -8640,7 +8640,8 @@ netdev_tx_t ixgbe_xmit_frame_ring(struct sk_buff *skb,\n \n \tif (unlikely(skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP) &&\n \t adapter->ptp_clock) {\n-\t\tif (!test_and_set_bit_lock(__IXGBE_PTP_TX_IN_PROGRESS,\n+\t\tif (adapter->tstamp_config.tx_type == HWTSTAMP_TX_ON &&\n+\t\t !test_and_set_bit_lock(__IXGBE_PTP_TX_IN_PROGRESS,\n \t\t\t\t\t &adapter->state)) {\n \t\t\tskb_shinfo(skb)->tx_flags |= SKBTX_IN_PROGRESS;\n \t\t\ttx_flags |= IXGBE_TX_FLAGS_TSTAMP;\n", "prefixes": [ "1/1" ] }