Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1172610/?format=api
{ "id": 1172610, "url": "http://patchwork.ozlabs.org/api/patches/1172610/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/edf91d8284a2a19d956eb8b7e8b6c4984ceaa1ab.camel@perches.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<edf91d8284a2a19d956eb8b7e8b6c4984ceaa1ab.camel@perches.com>", "list_archive_url": null, "date": "2019-10-06T17:19:10", "name": "i40e_pto.c: Odd use of strlcpy converted from strncpy", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "d60318b7fe2f4bd0ff28e1b0bd494de02d9c0647", "submitter": { "id": 771, "url": "http://patchwork.ozlabs.org/api/people/771/?format=api", "name": "Joe Perches", "email": "joe@perches.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/edf91d8284a2a19d956eb8b7e8b6c4984ceaa1ab.camel@perches.com/mbox/", "series": [ { "id": 134553, "url": "http://patchwork.ozlabs.org/api/series/134553/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=134553", "date": "2019-10-06T17:19:10", "name": "i40e_pto.c: Odd use of strlcpy converted from strncpy", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/134553/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1172610/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1172610/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=perches.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 46mmqz3fWsz9sCJ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 7 Oct 2019 14:56:28 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 78A98204EF;\n\tMon, 7 Oct 2019 03:56:25 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id v-j+mCYpW922; Mon, 7 Oct 2019 03:56:23 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id AF26D2012D;\n\tMon, 7 Oct 2019 03:56:23 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 76E0D1BF33E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 7 Oct 2019 03:56:22 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 727532012D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 7 Oct 2019 03:56:22 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id R6eY1IXEGk0D for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 7 Oct 2019 03:56:21 +0000 (UTC)", "from smtprelay.hostedemail.com (smtprelay0167.hostedemail.com\n\t[216.40.44.167])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 6C1A920025\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 7 Oct 2019 03:56:21 +0000 (UTC)", "from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com\n\t[10.5.19.251])\n\tby smtpgrave06.hostedemail.com (Postfix) with ESMTP id E9BE8800E2DA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 6 Oct 2019 17:19:15 +0000 (UTC)", "from filter.hostedemail.com (clb03-v110.bra.tucows.net\n\t[216.40.38.60])\n\tby smtprelay04.hostedemail.com (Postfix) with ESMTP id 41882180A68B1; \n\tSun, 6 Oct 2019 17:19:13 +0000 (UTC)", "from XPS-9350.home (unknown [47.151.152.152])\n\t(Authenticated sender: joe@perches.com)\n\tby omf20.hostedemail.com (Postfix) with ESMTPA;\n\tSun, 6 Oct 2019 17:19:11 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 08:10:01 by SQLgrey-1.7.6", "X-Session-Marker": "6A6F6540706572636865732E636F6D", "X-Spam-Summary": "2, 0, 0, , d41d8cd98f00b204, joe@perches.com, :::::::::,\n\tRULES_HIT:41:152:355:379:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2376:2393:2553:2559:2562:2903:3138:3139:3140:3141:3142:3352:3865:3867:3868:3871:3872:4321:5007:8603:10004:10400:10848:11026:11473:11657:11658:11914:12043:12262:12297:12438:12555:12679:12740:12895:12986:13069:13311:13357:13894:14096:14097:14181:14659:14721:21080:21365:21433:21451:21627:30054:30055:30064:30091,\n\t0, RBL:error, CacheIP:none, Bayesian:0.5, 0.5, 0.5, Netcheck:none,\n\tDomainCache:0, MSF:not bulk, SPF:fn, MSBL:0, DNSBL:neutral,\n\tCustom_rules:0:0:0, LFtime:260, LUA_SUMMARY:none", "X-HE-Tag": "road46_333b5ec2ba205", "X-Filterd-Recvd-Size": "2145", "Message-ID": "<edf91d8284a2a19d956eb8b7e8b6c4984ceaa1ab.camel@perches.com>", "From": "Joe Perches <joe@perches.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>, \n\tintel-wired-lan@lists.osuosl.org, netdev <netdev@vger.kernel.org>", "Date": "Sun, 06 Oct 2019 10:19:10 -0700", "User-Agent": "Evolution 3.32.1-2 ", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] i40e_pto.c: Odd use of strlcpy converted from\n\tstrncpy", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Patryk =?utf-8?b?TWHFgmVr?= <patryk.malek@intel.com>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This got converted from strncpy to strlcpy but it's\nnow not necessary to use one character less than the\nactual size.\n\nPerhaps the sizeof() - 1 is now not correct and it\nshould use strscpy and a normal sizeof.\n\nfrom:\n\ncommit 7eb74ff891b4e94b8bac48f648a21e4b94ddee64\nAuthor: Mitch Williams <mitch.a.williams@intel.com>\nDate: Mon Aug 20 08:12:30 2018 -0700\n\n i40e: use correct length for strncpy\n\nand\n\ncommit 4ff2d8540321324e04c1306f85d4fe68a0c2d0ae\nAuthor: Patryk Małek <patryk.malek@intel.com>\nDate: Tue Oct 30 10:50:44 2018 -0700\n\n i40e: Replace strncpy with strlcpy to ensure null termination\n---\n drivers/net/ethernet/intel/i40e/i40e_ptp.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ptp.c b/drivers/net/ethernet/intel/i40e/i40e_ptp.c\nindex 9bf1ad4319f5..627b1c02bb4b 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ptp.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ptp.c\n@@ -700,8 +700,8 @@ static long i40e_ptp_create_clock(struct i40e_pf *pf)\n \tif (!IS_ERR_OR_NULL(pf->ptp_clock))\n \t\treturn 0;\n \n-\tstrlcpy(pf->ptp_caps.name, i40e_driver_name,\n-\t\tsizeof(pf->ptp_caps.name) - 1);\n+\tstrscpy(pf->ptp_caps.name, i40e_driver_name, sizeof(pf->ptp_caps.name));\n+\n \tpf->ptp_caps.owner = THIS_MODULE;\n \tpf->ptp_caps.max_adj = 999999999;\n \tpf->ptp_caps.n_ext_ts = 0;\n", "prefixes": [] }