Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1171/?format=api
{ "id": 1171, "url": "http://patchwork.ozlabs.org/api/patches/1171/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/48D9524A.3050300@logitech.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<48D9524A.3050300@logitech.com>", "list_archive_url": null, "date": "2008-09-23T20:32:10", "name": "[MTD-UTILS] Allow an absent 'image' in the ubinize configuration.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2a43e4a07079fc612b683fac544cc79f69ad36a9", "submitter": { "id": 460, "url": "http://patchwork.ozlabs.org/api/people/460/?format=api", "name": "Richard Titmuss", "email": "richard_titmuss@logitech.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/48D9524A.3050300@logitech.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/1171/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1171/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Received": [ "from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id 1F53DDE3AE\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 24 Sep 2008 06:34:02 +1000 (EST)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KiEYd-0002ly-8Q; Tue, 23 Sep 2008 20:32:27 +0000", "from mail.slimdevices.com ([67.155.107.5])\n\tby bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KiEYa-0002Dh-SA\n\tfor linux-mtd@lists.infradead.org; Tue, 23 Sep 2008 20:32:25 +0000", "from [127.0.0.1] (host217-44-194-36.range217-44.btcentralplus.com\n\t[217.44.194.36])\n\tby mail.slimdevices.com (Postfix) with ESMTP id 7FFCDFD800C\n\tfor <linux-mtd@lists.infradead.org>;\n\tTue, 23 Sep 2008 13:32:22 -0700 (PDT)" ], "Message-ID": "<48D9524A.3050300@logitech.com>", "Date": "Tue, 23 Sep 2008 21:32:10 +0100", "From": "Richard Titmuss <richard_titmuss@logitech.com>", "User-Agent": "Thunderbird 2.0.0.16 (Windows/20080708)", "MIME-Version": "1.0", "To": "linux-mtd@lists.infradead.org", "Subject": "[PATCH][MTD-UTILS] Allow an absent 'image' in the ubinize\n\tconfiguration.", "X-Spam-Score": "0.0 (/)", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.9", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "linux-mtd-bounces@lists.infradead.org", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Hi,\n\nSome recent changes to ubinize prevent the 'image' parameter from being \nabsent in the configuration file. The following patch fixes that.\n\nSigned-off-by: Richard Titmuss <richard.titmuss@logitech.com>\n\n \n if (args.verbose)", "diff": "diff --git a/ubi-utils/new-utils/src/ubinize.c \nb/ubi-utils/new-utils/src/ubinize.c\nindex 5115db3..ebd5aa0 100644\n--- a/ubi-utils/new-utils/src/ubinize.c\n+++ b/ubi-utils/new-utils/src/ubinize.c\n@@ -561,20 +561,22 @@ int main(int argc, char * const argv[])\n goto out_free;\n }\n \n- fd = open(img, O_RDONLY);\n- if (fd == -1) {\n- sys_errmsg(\"cannot open \\\"%s\\\"\", img);\n- goto out_free;\n- }\n+ if (img) {\n+ fd = open(img, O_RDONLY);\n+ if (fd == -1) {\n+ sys_errmsg(\"cannot open \\\"%s\\\"\", img);\n+ goto out_free;\n+ }\n \n- verbose(args.verbose, \"writing volume %d\", vi[i].id);\n- verbose(args.verbose, \"image file: %s\", img);\n+ verbose(args.verbose, \"writing volume %d\", vi[i].id);\n+ verbose(args.verbose, \"image file: %s\", img);\n \n- err = ubigen_write_volume(&ui, &vi[i], args.ec, st.st_size, fd, \nargs.out_fd);\n- close(fd);\n- if (err) {\n- errmsg(\"cannot write volume for section \\\"%s\\\"\", sname);\n- goto out_free;\n+ err = ubigen_write_volume(&ui, &vi[i], args.ec, st.st_size, \nfd, args.out_fd);\n+ close(fd);\n+ if (err) {\n+ errmsg(\"cannot write volume for section \\\"%s\\\"\", sname);\n+ goto out_free;\n+ }\n }\n", "prefixes": [ "MTD-UTILS" ] }