Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1168047/?format=api
{ "id": 1168047, "url": "http://patchwork.ozlabs.org/api/patches/1168047/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190926181109.4871-3-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190926181109.4871-3-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2019-09-26T18:11:04", "name": "[net-next,v3,2/7] net: reject PTP periodic output requests with unsupported flags", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ce65cc8f1c575a78f05afcbe5703e94f5283e51c", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190926181109.4871-3-jacob.e.keller@intel.com/mbox/", "series": [ { "id": 132779, "url": "http://patchwork.ozlabs.org/api/series/132779/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=132779", "date": "2019-09-26T18:11:02", "name": "new PTP ioctl fixes", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/132779/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1168047/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1168047/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 46fNKW5Xk4z9sNf\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 27 Sep 2019 04:11:27 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 44E2F86234;\n\tThu, 26 Sep 2019 18:11:26 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id C-oLKaCSoG1H; Thu, 26 Sep 2019 18:11:25 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4A81F861B2;\n\tThu, 26 Sep 2019 18:11:25 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 4F4841BF336\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 26 Sep 2019 18:11:23 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4BF00861B2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 26 Sep 2019 18:11:23 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DA5yDr_tS_kF for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 26 Sep 2019 18:11:22 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 9D3AB81A2B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 26 Sep 2019 18:11:22 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Sep 2019 11:11:22 -0700", "from jekeller-desk.amr.corp.intel.com ([10.166.244.172])\n\tby orsmga005.jf.intel.com with ESMTP; 26 Sep 2019 11:11:22 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,552,1559545200\"; d=\"scan'208\";a=\"364882885\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "netdev@vger.kernel.org", "Date": "Thu, 26 Sep 2019 11:11:04 -0700", "Message-Id": "<20190926181109.4871-3-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.23.0.245.gf157bbb9169d", "In-Reply-To": "<20190926181109.4871-1-jacob.e.keller@intel.com>", "References": "<20190926181109.4871-1-jacob.e.keller@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [net-next v3 2/7] net: reject PTP periodic output\n\trequests with unsupported flags", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Christopher Hall <christopher.s.hall@intel.com>,\n\tFelipe Balbi <felipe.balbi@linux.intel.com>,\n\tRichard Cochran <richardcochran@gmail.com>,\n\tIntel Wired LAN <intel-wired-lan@lists.osuosl.org>,\n\t\"David S . Miller\" <davem@davemloft.net>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Commit 823eb2a3c4c7 (\"PTP: add support for one-shot output\") introduced\na new flag for the PTP periodic output request ioctl. This flag is not\ncurrently supported by any driver.\n\nFix all drivers which implement the periodic output request ioctl to\nexplicitly reject any request with flags they do not understand. This\nensures that the driver does not accidentally misinterpret the\nPTP_PEROUT_ONE_SHOT flag, or any new flag introduced in the future.\n\nThis is important for forward compatibility: if a new flag is\nintroduced, the driver should reject requests to enable the flag until\nthe driver has actually been modified to support the flag in question.\n\nCc: Richard Cochran <richardcochran@gmail.com>\nCc: Felipe Balbi <felipe.balbi@linux.intel.com>\nCc: David S. Miller <davem@davemloft.net>\nCc: Christopher Hall <christopher.s.hall@intel.com>\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/broadcom/tg3.c | 4 ++++\n drivers/net/ethernet/intel/igb/igb_ptp.c | 4 ++++\n drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c | 4 ++++\n drivers/net/ethernet/microchip/lan743x_ptp.c | 4 ++++\n drivers/net/ethernet/renesas/ravb_ptp.c | 4 ++++\n drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 4 ++++\n drivers/net/phy/dp83640.c | 3 +++\n 7 files changed, 27 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c\nindex 77f3511b97de..ca3aa1250dd1 100644\n--- a/drivers/net/ethernet/broadcom/tg3.c\n+++ b/drivers/net/ethernet/broadcom/tg3.c\n@@ -6280,6 +6280,10 @@ static int tg3_ptp_enable(struct ptp_clock_info *ptp,\n \n \tswitch (rq->type) {\n \tcase PTP_CLK_REQ_PEROUT:\n+\t\t/* Reject requests with unsupported flags */\n+\t\tif (rq->perout.flags)\n+\t\t\treturn -EOPNOTSUPP;\n+\n \t\tif (rq->perout.index != 0)\n \t\t\treturn -EINVAL;\n \ndiff --git a/drivers/net/ethernet/intel/igb/igb_ptp.c b/drivers/net/ethernet/intel/igb/igb_ptp.c\nindex fd3071f55bd3..4997963149f6 100644\n--- a/drivers/net/ethernet/intel/igb/igb_ptp.c\n+++ b/drivers/net/ethernet/intel/igb/igb_ptp.c\n@@ -551,6 +551,10 @@ static int igb_ptp_feature_enable_i210(struct ptp_clock_info *ptp,\n \t\treturn 0;\n \n \tcase PTP_CLK_REQ_PEROUT:\n+\t\t/* Reject requests with unsupported flags */\n+\t\tif (rq->perout.flags)\n+\t\t\treturn -EOPNOTSUPP;\n+\n \t\tif (on) {\n \t\t\tpin = ptp_find_pin(igb->ptp_clock, PTP_PF_PEROUT,\n \t\t\t\t\t rq->perout.index);\ndiff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c\nindex 0059b290e095..cff6b60de304 100644\n--- a/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c\n+++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c\n@@ -290,6 +290,10 @@ static int mlx5_perout_configure(struct ptp_clock_info *ptp,\n \tif (!MLX5_PPS_CAP(mdev))\n \t\treturn -EOPNOTSUPP;\n \n+\t/* Reject requests with unsupported flags */\n+\tif (rq->perout.flags)\n+\t\treturn -EOPNOTSUPP;\n+\n \tif (rq->perout.index >= clock->ptp_info.n_pins)\n \t\treturn -EINVAL;\n \ndiff --git a/drivers/net/ethernet/microchip/lan743x_ptp.c b/drivers/net/ethernet/microchip/lan743x_ptp.c\nindex 57b26c2acf87..e8fe9a90fe4f 100644\n--- a/drivers/net/ethernet/microchip/lan743x_ptp.c\n+++ b/drivers/net/ethernet/microchip/lan743x_ptp.c\n@@ -429,6 +429,10 @@ static int lan743x_ptp_perout(struct lan743x_adapter *adapter, int on,\n \tint pulse_width = 0;\n \tint perout_bit = 0;\n \n+\t/* Reject requests with unsupported flags */\n+\tif (perout->flags)\n+\t\treturn -EOPNOTSUPP;\n+\n \tif (!on) {\n \t\tlan743x_ptp_perout_off(adapter);\n \t\treturn 0;\ndiff --git a/drivers/net/ethernet/renesas/ravb_ptp.c b/drivers/net/ethernet/renesas/ravb_ptp.c\nindex 9a42580693cb..638f1fc2166f 100644\n--- a/drivers/net/ethernet/renesas/ravb_ptp.c\n+++ b/drivers/net/ethernet/renesas/ravb_ptp.c\n@@ -211,6 +211,10 @@ static int ravb_ptp_perout(struct ptp_clock_info *ptp,\n \tunsigned long flags;\n \tint error = 0;\n \n+\t/* Reject requests with unsupported flags */\n+\tif (req->flags)\n+\t\treturn -EOPNOTSUPP;\n+\n \tif (req->index)\n \t\treturn -EINVAL;\n \ndiff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c\nindex 173493db038c..352dc4c68625 100644\n--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c\n+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c\n@@ -140,6 +140,10 @@ static int stmmac_enable(struct ptp_clock_info *ptp,\n \n \tswitch (rq->type) {\n \tcase PTP_CLK_REQ_PEROUT:\n+\t\t/* Reject requests with unsupported flags */\n+\t\tif (rq->perout.flags)\n+\t\t\treturn -EOPNOTSUPP;\n+\n \t\tcfg = &priv->pps[rq->perout.index];\n \n \t\tcfg->start.tv_sec = rq->perout.start.sec;\ndiff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c\nindex 6580094161a9..04ad77758920 100644\n--- a/drivers/net/phy/dp83640.c\n+++ b/drivers/net/phy/dp83640.c\n@@ -491,6 +491,9 @@ static int ptp_dp83640_enable(struct ptp_clock_info *ptp,\n \t\treturn 0;\n \n \tcase PTP_CLK_REQ_PEROUT:\n+\t\t/* Reject requests with unsupported flags */\n+\t\tif (rq->perout.flags)\n+\t\t\treturn -EOPNOTSUPP;\n \t\tif (rq->perout.index >= N_PER_OUT)\n \t\t\treturn -EINVAL;\n \t\treturn periodic_output(clock, rq, on, rq->perout.index);\n", "prefixes": [ "net-next", "v3", "2/7" ] }