Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1165386/?format=api
{ "id": 1165386, "url": "http://patchwork.ozlabs.org/api/patches/1165386/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190920091724.51767-6-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190920091724.51767-6-alice.michael@intel.com>", "list_archive_url": null, "date": "2019-09-20T09:17:20", "name": "[next,S10,06/10] i40e: remove the macro with it's argument reuse", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "87c2dc4be93fe66829540b04496d57a2dfafd028", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190920091724.51767-6-alice.michael@intel.com/mbox/", "series": [ { "id": 131821, "url": "http://patchwork.ozlabs.org/api/series/131821/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=131821", "date": "2019-09-20T09:17:15", "name": "[next,S10,01/10] i40e: Fix for persistent lldp support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/131821/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1165386/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1165386/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 46Zgw446N5z9sNx\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 21 Sep 2019 03:40:04 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id ACB4687C0C;\n\tFri, 20 Sep 2019 17:40:02 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id eNavyyOV8MNC; Fri, 20 Sep 2019 17:39:59 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6ED9C87E4A;\n\tFri, 20 Sep 2019 17:39:58 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 78E2A1BF9AF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 20 Sep 2019 17:39:54 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 75F2D85764\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 20 Sep 2019 17:39:54 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id MnVMVbUFJQ1i for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 20 Sep 2019 17:39:53 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 1755E8583F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 20 Sep 2019 17:39:53 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Sep 2019 10:39:51 -0700", "from alicemic-1.jf.intel.com ([10.166.17.62])\n\tby fmsmga004.fm.intel.com with ESMTP; 20 Sep 2019 10:39:51 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,529,1559545200\"; d=\"scan'208\";a=\"212635335\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Fri, 20 Sep 2019 02:17:20 -0700", "Message-Id": "<20190920091724.51767-6-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190920091724.51767-1-alice.michael@intel.com>", "References": "<20190920091724.51767-1-alice.michael@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S10 06/10] i40e: remove the macro\n\twith it's argument reuse", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n\nRemove macro and call i40e_update_vfid_in_stats() function directly\nto avoid checkpatch.pl complains about macro argument reuse and\npossible side effects.\n\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n .../net/ethernet/intel/i40e/i40e_ethtool.c | 28 ++++---------------\n 1 file changed, 6 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 67a6bd52eb95..883b43ac9816 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -2417,7 +2417,7 @@ static void i40e_get_ethtool_stats(struct net_device *netdev,\n }\n \n /**\n- * __i40e_update_vfid_in_stats_strings - print VF num to stats names\n+ * i40e_update_vfid_in_stats - print VF num to stats names\n * @stats_extra: array of stats structs with stats name strings\n * @strings_num: number of stats name strings in array above (length)\n * @vf_id: VF number to update stats name strings with\n@@ -2425,8 +2425,8 @@ static void i40e_get_ethtool_stats(struct net_device *netdev,\n * Helper function to i40e_get_stat_strings() in case of extra stats.\n **/\n static inline void\n-__i40e_update_vfid_in_stats_strings(struct i40e_stats stats_extra[],\n-\t\t\t\t int strings_num, int vf_id)\n+i40e_update_vfid_in_stats(struct i40e_stats stats_extra[],\n+\t\t\t int strings_num, int vf_id)\n {\n \tint i;\n \n@@ -2438,24 +2438,6 @@ __i40e_update_vfid_in_stats_strings(struct i40e_stats stats_extra[],\n \t}\n }\n \n-/**\n- * i40e_update_vfid_in_stats - print VF num to stat names\n- * @stats_extra: array of stats structs with stats name strings\n- * @vf_id: VF number to update stats name strings with\n- *\n- * Helper macro to i40e_get_stat_strings() to ease use of\n- * __i40e_update_vfid_in_stats_strings() function due to extra stats.\n- *\n- * Macro to ease the use of __i40e_update_vfid_in_stats_strings by taking\n- * a static constant stats array and passing the ARRAY_SIZE(). This avoids typos\n- * by ensuring that we pass the size associated with the given stats array.\n- *\n- * The parameter @stats_extra is evaluated twice, so parameters with side\n- * effects should be avoided.\n- **/\n-#define i40e_update_vfid_in_stats(stats_extra, vf_id) \\\n-__i40e_update_vfid_in_stats_strings(stats_extra, ARRAY_SIZE(stats_extra), vf_id)\n-\n /**\n * i40e_get_stat_strings - copy stat strings into supplied buffer\n * @netdev: the netdev to collect strings for\n@@ -2499,7 +2481,9 @@ static void i40e_get_stat_strings(struct net_device *netdev, u8 *data)\n \t\ti40e_add_stat_strings(&data, i40e_gstrings_pfc_stats, i);\n \n \tfor (i = 0; i < I40E_STATS_EXTRA_COUNT; i++) {\n-\t\ti40e_update_vfid_in_stats(i40e_gstrings_eth_stats_extra, i);\n+\t\ti40e_update_vfid_in_stats\n+\t\t\t(i40e_gstrings_eth_stats_extra,\n+\t\t\t ARRAY_SIZE(i40e_gstrings_eth_stats_extra), i);\n \t\ti40e_add_stat_strings(&data, i40e_gstrings_eth_stats_extra);\n \t}\n \n", "prefixes": [ "next", "S10", "06/10" ] }