Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1161350,
    "url": "http://patchwork.ozlabs.org/api/patches/1161350/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20190912040219.67517-3-maowenan@huawei.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20190912040219.67517-3-maowenan@huawei.com>",
    "list_archive_url": null,
    "date": "2019-09-12T04:02:18",
    "name": "[v2,net,2/3] sctp: remove redundant assignment when call sctp_get_port_local",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "fdf42d397d1b3435aa7810d56abb2741f6dc1713",
    "submitter": {
        "id": 70289,
        "url": "http://patchwork.ozlabs.org/api/people/70289/?format=api",
        "name": "maowenan",
        "email": "maowenan@huawei.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20190912040219.67517-3-maowenan@huawei.com/mbox/",
    "series": [
        {
            "id": 130322,
            "url": "http://patchwork.ozlabs.org/api/series/130322/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=130322",
            "date": "2019-09-12T04:02:16",
            "name": "fix memory leak for sctp_do_bind",
            "version": 2,
            "mbox": "http://patchwork.ozlabs.org/series/130322/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/1161350/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/1161350/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming-netdev@ozlabs.org",
        "Delivered-To": "patchwork-incoming-netdev@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=huawei.com"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 46TPmV1c6Mz9sPD\n\tfor <patchwork-incoming-netdev@ozlabs.org>;\n\tThu, 12 Sep 2019 13:45:14 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1729830AbfILDpH (ORCPT\n\t<rfc822;patchwork-incoming-netdev@ozlabs.org>);\n\tWed, 11 Sep 2019 23:45:07 -0400",
            "from szxga05-in.huawei.com ([45.249.212.191]:2268 \"EHLO huawei.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1729752AbfILDpF (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tWed, 11 Sep 2019 23:45:05 -0400",
            "from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58])\n\tby Forcepoint Email with ESMTP id 1167E92762D2E5FEB2E6;\n\tThu, 12 Sep 2019 11:45:04 +0800 (CST)",
            "from localhost.localdomain.localdomain (10.175.113.25) by\n\tDGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP\n\tServer id 14.3.439.0; Thu, 12 Sep 2019 11:44:52 +0800"
        ],
        "From": "Mao Wenan <maowenan@huawei.com>",
        "To": "<vyasevich@gmail.com>, <nhorman@tuxdriver.com>,\n\t<marcelo.leitner@gmail.com>, <davem@davemloft.net>",
        "CC": "<linux-sctp@vger.kernel.org>, <netdev@vger.kernel.org>,\n\t<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,\n\tMao Wenan <maowenan@huawei.com>",
        "Subject": "[PATCH v2 net 2/3] sctp: remove redundant assignment when call\n\tsctp_get_port_local",
        "Date": "Thu, 12 Sep 2019 12:02:18 +0800",
        "Message-ID": "<20190912040219.67517-3-maowenan@huawei.com>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20190912040219.67517-1-maowenan@huawei.com>",
        "References": "<7a450679-40ca-8a84-4cba-7a16f22ea3c0@huawei.com>\n\t<20190912040219.67517-1-maowenan@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "7BIT",
        "Content-Type": "text/plain; charset=US-ASCII",
        "X-Originating-IP": "[10.175.113.25]",
        "X-CFilter-Loop": "Reflected",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "There are more parentheses in if clause when call sctp_get_port_local\nin sctp_do_bind, and redundant assignment to 'ret'. This patch is to\ndo cleanup.\n\nSigned-off-by: Mao Wenan <maowenan@huawei.com>\nAcked-by: Neil Horman <nhorman@tuxdriver.com>\n---\n net/sctp/socket.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)",
    "diff": "diff --git a/net/sctp/socket.c b/net/sctp/socket.c\nindex 5e1934c48709..2f810078c91d 100644\n--- a/net/sctp/socket.c\n+++ b/net/sctp/socket.c\n@@ -399,9 +399,8 @@ static int sctp_do_bind(struct sock *sk, union sctp_addr *addr, int len)\n \t * detection.\n \t */\n \taddr->v4.sin_port = htons(snum);\n-\tif ((ret = sctp_get_port_local(sk, addr))) {\n+\tif (sctp_get_port_local(sk, addr))\n \t\treturn -EADDRINUSE;\n-\t}\n \n \t/* Refresh ephemeral port.  */\n \tif (!bp->port)\n",
    "prefixes": [
        "v2",
        "net",
        "2/3"
    ]
}