Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1158955/?format=api
{ "id": 1158955, "url": "http://patchwork.ozlabs.org/api/patches/1158955/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190906113356.9985-1-colin.king@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190906113356.9985-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2019-09-06T11:33:56", "name": "net/ixgbevf: make array api static const, makes object smaller", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cca4a758f225febf1f6a3c57fe94b2809b6fe56c", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190906113356.9985-1-colin.king@canonical.com/mbox/", "series": [ { "id": 129401, "url": "http://patchwork.ozlabs.org/api/series/129401/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=129401", "date": "2019-09-06T11:33:56", "name": "net/ixgbevf: make array api static const, makes object smaller", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/129401/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1158955/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1158955/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=fail (p=none dis=none)\n\theader.from=canonical.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 46PwSH5rH5z9sN1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 6 Sep 2019 21:34:06 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 170E786235;\n\tFri, 6 Sep 2019 11:34:05 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id j26OPvV4QlCK; Fri, 6 Sep 2019 11:34:03 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 19E5785044;\n\tFri, 6 Sep 2019 11:34:03 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 241D31BF5DB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 6 Sep 2019 11:34:02 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1C70986521\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 6 Sep 2019 11:34:02 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id xwnWwnb1n_3C for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 6 Sep 2019 11:34:01 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 76D138651A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 6 Sep 2019 11:34:01 +0000 (UTC)", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1i6CV2-0006NC-VZ; Fri, 06 Sep 2019 11:33:57 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Colin King <colin.king@canonical.com>", "To": "gJeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Date": "Fri, 6 Sep 2019 12:33:56 +0100", "Message-Id": "<20190906113356.9985-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] net/ixgbevf: make array api static const, \n\tmakes object smaller", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nDon't populate the array api on the stack but instead make it\nstatic const. Makes the object code smaller by 58 bytes.\n\nBefore:\n text\t data\t bss\t dec\t hex\tfilename\n 82969\t 9763\t 256\t 92988\t 16b3c\tixgbevf/ixgbevf_main.o\n\nAfter:\n text\t data\t bss\t dec\t hex\tfilename\n 82815\t 9859\t 256\t 92930\t 16b02\tixgbevf/ixgbevf_main.o\n\n(gcc version 9.2.1, amd64)\n\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\nindex 8c011d4ce7a9..46c8e2501084 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n@@ -2261,12 +2261,14 @@ static void ixgbevf_init_last_counter_stats(struct ixgbevf_adapter *adapter)\n static void ixgbevf_negotiate_api(struct ixgbevf_adapter *adapter)\n {\n \tstruct ixgbe_hw *hw = &adapter->hw;\n-\tint api[] = { ixgbe_mbox_api_14,\n-\t\t ixgbe_mbox_api_13,\n-\t\t ixgbe_mbox_api_12,\n-\t\t ixgbe_mbox_api_11,\n-\t\t ixgbe_mbox_api_10,\n-\t\t ixgbe_mbox_api_unknown };\n+\tstatic const int api[] = {\n+\t\tixgbe_mbox_api_14,\n+\t\tixgbe_mbox_api_13,\n+\t\tixgbe_mbox_api_12,\n+\t\tixgbe_mbox_api_11,\n+\t\tixgbe_mbox_api_10,\n+\t\tixgbe_mbox_api_unknown\n+\t};\n \tint err, idx = 0;\n \n \tspin_lock_bh(&adapter->mbx_lock);\n", "prefixes": [] }