Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1157805/?format=api
{ "id": 1157805, "url": "http://patchwork.ozlabs.org/api/patches/1157805/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190904150703.13516.21103.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190904150703.13516.21103.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2019-09-04T15:07:11", "name": "[net-queue] ixgbe: Prevent u8 wrapping of ITR value to something less than 10us", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "405e33485f4577b437e1a551190d42ecaef6dfa0", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190904150703.13516.21103.stgit@localhost.localdomain/mbox/", "series": [ { "id": 129001, "url": "http://patchwork.ozlabs.org/api/series/129001/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=129001", "date": "2019-09-04T15:07:11", "name": "[net-queue] ixgbe: Prevent u8 wrapping of ITR value to something less than 10us", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/129001/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1157805/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1157805/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"VOKnX9bo\"; dkim-atps=neutral" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 46NnHJ0GMwz9sBF\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 5 Sep 2019 01:07:21 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 0FC0B85477;\n\tWed, 4 Sep 2019 15:07:19 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id U2QmQvmCbE8x; Wed, 4 Sep 2019 15:07:17 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 671DE877EC;\n\tWed, 4 Sep 2019 15:07:17 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6EEDE1BF3AA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 4 Sep 2019 15:07:15 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 63DC8869EA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 4 Sep 2019 15:07:15 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id o7mgVY4SNyqE for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 4 Sep 2019 15:07:14 +0000 (UTC)", "from mail-ot1-f67.google.com (mail-ot1-f67.google.com\n\t[209.85.210.67])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 16BBD869E4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 4 Sep 2019 15:07:14 +0000 (UTC)", "by mail-ot1-f67.google.com with SMTP id c10so9566471otd.9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 04 Sep 2019 08:07:14 -0700 (PDT)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\tl30sm4653063otl.74.2019.09.04.08.07.12\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 04 Sep 2019 08:07:12 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:cc:date:message-id:user-agent:mime-version\n\t:content-transfer-encoding;\n\tbh=igZsZ0dH+EIfH5MzGHYssyFYBGCrBbP03/TQYeZEM50=;\n\tb=VOKnX9boTah59OvOXcXeVx29zgAq3EQhEA2yr+183t8jhB/CYQBaTerov8uYD6yAJq\n\t0z5Ppy4o82QYD2XeJDKGuTABxBYKU72LalWKhtz5mA2lbu+u0xFKe0JQtl3fALT+6pZk\n\tapHtl/n/u39FdeRq/B5Yx1sYIjxkFAGMolMP1iAaZb/cQoRK1kIXh+EN/aWMZlgL7cg2\n\tSu0bFycgbA/NUsCTQvxuvHkUuDYltYw5/dNfbuP8G/oanjnL5z2w7lkPmOoWktzE3MhF\n\t4lm97mqICzvgpqKjUy1c5FY07SY7n6sIvA4euzaLtxGJTKyRVm9ssXoneRpGXh1aCYUZ\n\tbMYg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=igZsZ0dH+EIfH5MzGHYssyFYBGCrBbP03/TQYeZEM50=;\n\tb=ITm2gQrsvOjOUWBKLuICepNvfssHfjBPpOk8DgB/2BFcWvRvaarkGOrGlts5w6RKtQ\n\tLaujr3d7AcR+smbLtOTQc59gSmpSUXrJrpsCF3zRRmYZmWUnuumqxI/Iwi+TlmWbmXIs\n\tSWlxJJt+W2h8XDogtiF8JL4n+zOSEefUXrm1q419QP6LJ1V+4BEzRyC4HIG1NhmIqeID\n\tov4le8xn1u1mdnsdVK5eU5KjEBS0f2aWYafgsz0U5LcUSKTOgHSr9qbxVM1QK/ivANHd\n\t2jUVf5Rkrs6jPT37Oqt/artSrU3m7oJPEKzNsz2FtqZ4hqidJA5yXDhrLkcdN2AWLDH0\n\t0WeQ==", "X-Gm-Message-State": "APjAAAXjA4Tr57Zbdc1dYww5ey7FlZ0TUPCDkKBHWaG1Iew/QnHTmEgN\n\tIRTABikAMUZzI7mxlSpBlEE=", "X-Google-Smtp-Source": "APXvYqwJC7IZtMXmcLjmXr7WnfPHAfpuM6LUAP18mfYRU7hM5DeoMqeoTgbNmwOIMqPPS+gqwxxbCw==", "X-Received": "by 2002:a05:6830:c1:: with SMTP id\n\tx1mr12739641oto.272.1567609632821; \n\tWed, 04 Sep 2019 08:07:12 -0700 (PDT)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 04 Sep 2019 08:07:11 -0700", "Message-ID": "<20190904150703.13516.21103.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [net-queue PATCH] ixgbe: Prevent u8 wrapping of\n\tITR value to something less than 10us", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "alexander.h.duyck@linux.intel.com, gleventhal@janestreet.com", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@linux.intel.com>\n\nThere were a couple cases where the ITR value generated via the adaptive\nITR scheme could exceed 126. This resulted in the value becoming either 0\nor something less than 10. Switching back and forth between a value less\nthan 10 and a value greater than 10 can cause issues as certain hardware\nfeatures such as RSC to not function well when the ITR value has dropped\nthat low.\n\nReported-by: Gregg Leventhal <gleventhal@janestreet.com>\nSigned-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 5fa585dfddf6..097e6dfbf65a 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -2621,7 +2621,7 @@ static void ixgbe_update_itr(struct ixgbe_q_vector *q_vector,\n \t\t/* 16K ints/sec to 9.2K ints/sec */\n \t\tavg_wire_size *= 15;\n \t\tavg_wire_size += 11452;\n-\t} else if (avg_wire_size <= 1980) {\n+\t} else if (avg_wire_size < 1968) {\n \t\t/* 9.2K ints/sec to 8K ints/sec */\n \t\tavg_wire_size *= 5;\n \t\tavg_wire_size += 22420;\n@@ -2654,6 +2654,8 @@ static void ixgbe_update_itr(struct ixgbe_q_vector *q_vector,\n \tcase IXGBE_LINK_SPEED_2_5GB_FULL:\n \tcase IXGBE_LINK_SPEED_1GB_FULL:\n \tcase IXGBE_LINK_SPEED_10_FULL:\n+\t\tif (avg_wire_size > 8064)\n+\t\t\tavg_wire_size = 8064;\n \t\titr += DIV_ROUND_UP(avg_wire_size,\n \t\t\t\t IXGBE_ITR_ADAPTIVE_MIN_INC * 64) *\n \t\t IXGBE_ITR_ADAPTIVE_MIN_INC;\n", "prefixes": [ "net-queue" ] }