Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1157240/?format=api
{ "id": 1157240, "url": "http://patchwork.ozlabs.org/api/patches/1157240/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190903192021.25789-2-maurosr@linux.vnet.ibm.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190903192021.25789-2-maurosr@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2019-09-03T19:20:21", "name": "[v2,net-next,2/2] i40e: Implement debug macro hw_dbg using dev_dbg", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "df592a7c46a2c7dda0fa06eb31c16c9da8452d6a", "submitter": { "id": 71608, "url": "http://patchwork.ozlabs.org/api/people/71608/?format=api", "name": "Mauro S. M. Rodrigues", "email": "maurosr@linux.vnet.ibm.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190903192021.25789-2-maurosr@linux.vnet.ibm.com/mbox/", "series": [ { "id": 128830, "url": "http://patchwork.ozlabs.org/api/series/128830/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=128830", "date": "2019-09-03T19:20:20", "name": "[v2,net-next,1/2] i40e: fix hw_dbg usage in i40e_hmc_get_object_va", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/128830/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1157240/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1157240/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=linux.vnet.ibm.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 46NGy723hWz9s4Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 4 Sep 2019 05:20:47 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D1FF8228EF;\n\tTue, 3 Sep 2019 19:20:45 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id cdvPpN+uOkHN; Tue, 3 Sep 2019 19:20:43 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id C6A6D228E3;\n\tTue, 3 Sep 2019 19:20:43 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 32B801BF5A2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 Sep 2019 19:20:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 2F4E2228E3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 Sep 2019 19:20:43 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CC2uSRiA+HCd for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 Sep 2019 19:20:42 +0000 (UTC)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 5B43C228BA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 Sep 2019 19:20:42 +0000 (UTC)", "from pps.filterd (m0098404.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx83JHOsn104305; Tue, 3 Sep 2019 15:20:40 -0400", "from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com\n\t[169.62.189.11])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2usw0q2dfk-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Tue, 03 Sep 2019 15:20:39 -0400", "from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1])\n\tby ppma03dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx83JJeCi003864; Tue, 3 Sep 2019 19:20:39 GMT", "from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com\n\t[9.57.198.29]) by ppma03dal.us.ibm.com with ESMTP id 2uqgh71nwb-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Tue, 03 Sep 2019 19:20:39 +0000", "from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com\n\t[9.57.199.109])\n\tby b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid x83JKcSM54198562\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 3 Sep 2019 19:20:38 GMT", "from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 3CAE8112062;\n\tTue, 3 Sep 2019 19:20:38 +0000 (GMT)", "from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 0EBD1112061;\n\tTue, 3 Sep 2019 19:20:37 +0000 (GMT)", "from localhost (unknown [9.18.235.139])\n\tby b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP;\n\tTue, 3 Sep 2019 19:20:37 +0000 (GMT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "\"Mauro S. M. Rodrigues\" <maurosr@linux.vnet.ibm.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Tue, 3 Sep 2019 16:20:21 -0300", "Message-Id": "<20190903192021.25789-2-maurosr@linux.vnet.ibm.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190903192021.25789-1-maurosr@linux.vnet.ibm.com>", "References": "<20190903192021.25789-1-maurosr@linux.vnet.ibm.com>", "MIME-Version": "1.0", "X-TM-AS-GCONF": "00", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-09-03_04:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tpriorityscore=1501\n\tmalwarescore=0 suspectscore=0 phishscore=0 bulkscore=21 spamscore=0\n\tclxscore=1015 lowpriorityscore=21 mlxscore=0 impostorscore=0\n\tmlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx\n\tscancount=1 engine=8.0.1-1906280000 definitions=main-1909030191", "Subject": "[Intel-wired-lan] [PATCH v2 net-next 2/2] i40e: Implement debug\n\tmacro hw_dbg using dev_dbg", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Jakub Kicinski <jakub.kicinski@netronome.com>, netdev@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org, davem@davemloft.net", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "There are several uses of hw_dbg in the code, producing no output. This\npatch implments it using dev_debug.\n\nInitially the intention was to implement it using netdev_dbg, analogously\nto what is done in ixgbe for instance. That approach was avoided due to\nsome early usages of hw_dbg, like i40e_pf_reset, before the vsi structure\ninitialization causing NULL pointer dereference during the driver probe if\nthe dbg messages were turned on as soon as the module is probed.\n\nv2:\n - Use dev_dbg instead of pr_debug, and take advantage of dev_name\ninstead of crafting pretty much the same device name locally as suggested\nby Jakub Kicinski.\n\nSigned-off-by: Mauro S. M. Rodrigues <maurosr@linux.vnet.ibm.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_common.c | 1 +\n drivers/net/ethernet/intel/i40e/i40e_hmc.c | 1 +\n drivers/net/ethernet/intel/i40e/i40e_osdep.h | 5 ++++-\n 3 files changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c\nindex 906cf68d3453..a51678166ff9 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c\n@@ -1,6 +1,7 @@\n // SPDX-License-Identifier: GPL-2.0\n /* Copyright(c) 2013 - 2018 Intel Corporation. */\n \n+#include \"i40e.h\"\n #include \"i40e_type.h\"\n #include \"i40e_adminq.h\"\n #include \"i40e_prototype.h\"\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_hmc.c b/drivers/net/ethernet/intel/i40e/i40e_hmc.c\nindex 19ce93d7fd0a..163ee8c6311c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_hmc.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_hmc.c\n@@ -1,6 +1,7 @@\n // SPDX-License-Identifier: GPL-2.0\n /* Copyright(c) 2013 - 2018 Intel Corporation. */\n \n+#include \"i40e.h\"\n #include \"i40e_osdep.h\"\n #include \"i40e_register.h\"\n #include \"i40e_status.h\"\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_osdep.h b/drivers/net/ethernet/intel/i40e/i40e_osdep.h\nindex a07574bff550..c302ef2524f8 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_osdep.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_osdep.h\n@@ -18,7 +18,10 @@\n * actual OS primitives\n */\n \n-#define hw_dbg(hw, S, A...)\tdo {} while (0)\n+#define hw_dbg(hw, S, A...)\t\t\t\t\t\t\t\\\n+do {\t\t\t\t\t\t\t\t\t\t\\\n+\tdev_dbg(&((struct i40e_pf *)hw->back)->pdev->dev, S, ##A);\t\t\\\n+} while (0)\n \n #define wr32(a, reg, value)\twritel((value), ((a)->hw_addr + (reg)))\n #define rd32(a, reg)\t\treadl((a)->hw_addr + (reg))\n", "prefixes": [ "v2", "net-next", "2/2" ] }