Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1157239/?format=api
{ "id": 1157239, "url": "http://patchwork.ozlabs.org/api/patches/1157239/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190903192021.25789-1-maurosr@linux.vnet.ibm.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190903192021.25789-1-maurosr@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2019-09-03T19:20:20", "name": "[v2,net-next,1/2] i40e: fix hw_dbg usage in i40e_hmc_get_object_va", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c74d973b282555292541f8ac6197824bb123deee", "submitter": { "id": 71608, "url": "http://patchwork.ozlabs.org/api/people/71608/?format=api", "name": "Mauro S. M. Rodrigues", "email": "maurosr@linux.vnet.ibm.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190903192021.25789-1-maurosr@linux.vnet.ibm.com/mbox/", "series": [ { "id": 128830, "url": "http://patchwork.ozlabs.org/api/series/128830/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=128830", "date": "2019-09-03T19:20:20", "name": "[v2,net-next,1/2] i40e: fix hw_dbg usage in i40e_hmc_get_object_va", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/128830/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1157239/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1157239/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=linux.vnet.ibm.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 46NGy54Qypz9sP6\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 4 Sep 2019 05:20:44 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 854D18758C;\n\tTue, 3 Sep 2019 19:20:42 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id WgtB4g9uUqJX; Tue, 3 Sep 2019 19:20:41 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 69289875C7;\n\tTue, 3 Sep 2019 19:20:41 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2D3DD1BF5A2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 Sep 2019 19:20:40 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 28388875C7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 Sep 2019 19:20:40 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id nkHuC0-4gxi0 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 Sep 2019 19:20:39 +0000 (UTC)", "from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 7C2E48758C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 Sep 2019 19:20:39 +0000 (UTC)", "from pps.filterd (m0098413.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx83JHjO2025350; Tue, 3 Sep 2019 15:20:33 -0400", "from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com\n\t[169.63.214.131])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2usuxj4e23-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Tue, 03 Sep 2019 15:20:32 -0400", "from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1])\n\tby ppma01dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx83JJfTj008333; Tue, 3 Sep 2019 19:20:31 GMT", "from b03cxnp07029.gho.boulder.ibm.com\n\t(b03cxnp07029.gho.boulder.ibm.com [9.17.130.16])\n\tby ppma01dal.us.ibm.com with ESMTP id 2uqgh71m9e-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Tue, 03 Sep 2019 19:20:31 +0000", "from b03ledav006.gho.boulder.ibm.com\n\t(b03ledav006.gho.boulder.ibm.com [9.17.130.237])\n\tby b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id x83JKU6m51642688\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 3 Sep 2019 19:20:30 GMT", "from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 52826C6061;\n\tTue, 3 Sep 2019 19:20:30 +0000 (GMT)", "from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 1D233C605A;\n\tTue, 3 Sep 2019 19:20:30 +0000 (GMT)", "from localhost (unknown [9.18.235.139])\n\tby b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP;\n\tTue, 3 Sep 2019 19:20:29 +0000 (GMT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "\"Mauro S. M. Rodrigues\" <maurosr@linux.vnet.ibm.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Tue, 3 Sep 2019 16:20:20 -0300", "Message-Id": "<20190903192021.25789-1-maurosr@linux.vnet.ibm.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "X-TM-AS-GCONF": "00", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-09-03_04:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tpriorityscore=1501\n\tmalwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0\n\tclxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0\n\tmlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx\n\tscancount=1 engine=8.0.1-1906280000 definitions=main-1909030191", "Subject": "[Intel-wired-lan] [PATCH v2 net-next 1/2] i40e: fix hw_dbg usage in\n\ti40e_hmc_get_object_va", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Jakub Kicinski <jakub.kicinski@netronome.com>, netdev@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org, davem@davemloft.net", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The mentioned function references a i40e_hw attribute, as parameter for\nhw_dbg, but it doesn't exist in the function scope.\nFixes it by changing parameters from i40e_hmc_info to i40e_hw which can\nretrieve the necessary i40e_hmc_info.\n\nv2:\n - Fixed reverse xmas tree code style issue as suggested by Jakub Kicinski\n\nSigned-off-by: Mauro S. M. Rodrigues <maurosr@linux.vnet.ibm.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 16 +++++++++-------\n 1 file changed, 9 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c b/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c\nindex 994011c38fb4..fd987f7ae6e5 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c\n@@ -1,6 +1,7 @@\n // SPDX-License-Identifier: GPL-2.0\n /* Copyright(c) 2013 - 2018 Intel Corporation. */\n \n+#include \"i40e.h\"\n #include \"i40e_osdep.h\"\n #include \"i40e_register.h\"\n #include \"i40e_type.h\"\n@@ -963,7 +964,7 @@ static i40e_status i40e_set_hmc_context(u8 *context_bytes,\n \n /**\n * i40e_hmc_get_object_va - retrieves an object's virtual address\n- * @hmc_info: pointer to i40e_hmc_info struct\n+ * @hw: the hardware struct, from which we obtain the i40e_hmc_info pointer\n * @object_base: pointer to u64 to get the va\n * @rsrc_type: the hmc resource type\n * @obj_idx: hmc object index\n@@ -972,16 +973,17 @@ static i40e_status i40e_set_hmc_context(u8 *context_bytes,\n * base pointer. This function is used for LAN Queue contexts.\n **/\n static\n-i40e_status i40e_hmc_get_object_va(struct i40e_hmc_info *hmc_info,\n+i40e_status i40e_hmc_get_object_va(struct i40e_hw *hw,\n \t\t\t\t\tu8 **object_base,\n \t\t\t\t\tenum i40e_hmc_lan_rsrc_type rsrc_type,\n \t\t\t\t\tu32 obj_idx)\n {\n+\tstruct i40e_hmc_info *hmc_info = &hw->hmc;\n \tu32 obj_offset_in_sd, obj_offset_in_pd;\n-\ti40e_status ret_code = 0;\n \tstruct i40e_hmc_sd_entry *sd_entry;\n \tstruct i40e_hmc_pd_entry *pd_entry;\n \tu32 pd_idx, pd_lmt, rel_pd_idx;\n+\ti40e_status ret_code = 0;\n \tu64 obj_offset_in_fpm;\n \tu32 sd_idx, sd_lmt;\n \n@@ -1047,7 +1049,7 @@ i40e_status i40e_clear_lan_tx_queue_context(struct i40e_hw *hw,\n \ti40e_status err;\n \tu8 *context_bytes;\n \n-\terr = i40e_hmc_get_object_va(&hw->hmc, &context_bytes,\n+\terr = i40e_hmc_get_object_va(hw, &context_bytes,\n \t\t\t\t I40E_HMC_LAN_TX, queue);\n \tif (err < 0)\n \t\treturn err;\n@@ -1068,7 +1070,7 @@ i40e_status i40e_set_lan_tx_queue_context(struct i40e_hw *hw,\n \ti40e_status err;\n \tu8 *context_bytes;\n \n-\terr = i40e_hmc_get_object_va(&hw->hmc, &context_bytes,\n+\terr = i40e_hmc_get_object_va(hw, &context_bytes,\n \t\t\t\t I40E_HMC_LAN_TX, queue);\n \tif (err < 0)\n \t\treturn err;\n@@ -1088,7 +1090,7 @@ i40e_status i40e_clear_lan_rx_queue_context(struct i40e_hw *hw,\n \ti40e_status err;\n \tu8 *context_bytes;\n \n-\terr = i40e_hmc_get_object_va(&hw->hmc, &context_bytes,\n+\terr = i40e_hmc_get_object_va(hw, &context_bytes,\n \t\t\t\t I40E_HMC_LAN_RX, queue);\n \tif (err < 0)\n \t\treturn err;\n@@ -1109,7 +1111,7 @@ i40e_status i40e_set_lan_rx_queue_context(struct i40e_hw *hw,\n \ti40e_status err;\n \tu8 *context_bytes;\n \n-\terr = i40e_hmc_get_object_va(&hw->hmc, &context_bytes,\n+\terr = i40e_hmc_get_object_va(hw, &context_bytes,\n \t\t\t\t I40E_HMC_LAN_RX, queue);\n \tif (err < 0)\n \t\treturn err;\n", "prefixes": [ "v2", "net-next", "1/2" ] }