Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1156828/?format=api
{ "id": 1156828, "url": "http://patchwork.ozlabs.org/api/patches/1156828/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190903060810.30775-1-sassmann@kpanic.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190903060810.30775-1-sassmann@kpanic.de>", "list_archive_url": null, "date": "2019-09-03T06:08:10", "name": "i40e: clear __I40E_VIRTCHNL_OP_PENDING on invalid min tx rate", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8f8bf13265b926ea847ddac46fd4107ac19f10c1", "submitter": { "id": 7508, "url": "http://patchwork.ozlabs.org/api/people/7508/?format=api", "name": "Stefan Assmann", "email": "sassmann@kpanic.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190903060810.30775-1-sassmann@kpanic.de/mbox/", "series": [ { "id": 128678, "url": "http://patchwork.ozlabs.org/api/series/128678/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=128678", "date": "2019-09-03T06:08:10", "name": "i40e: clear __I40E_VIRTCHNL_OP_PENDING on invalid min tx rate", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/128678/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1156828/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1156828/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=kpanic.de" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 46MxMq3B7jz9s7T\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 3 Sep 2019 16:08:20 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3B9738632D;\n\tTue, 3 Sep 2019 06:08:18 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id AeqK7H7x9dtM; Tue, 3 Sep 2019 06:08:17 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id C65C2862DB;\n\tTue, 3 Sep 2019 06:08:17 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id E08171BF36A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 Sep 2019 06:08:15 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id DBE18862DB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 Sep 2019 06:08:15 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id indEQjOp-usC for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 Sep 2019 06:08:15 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 5DF7286149\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 Sep 2019 06:08:15 +0000 (UTC)", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 6DCA8A707;\n\tTue, 3 Sep 2019 06:08:14 +0000 (UTC)", "from p50.redhat.com (ovpn-117-136.ams2.redhat.com [10.36.117.136])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0CC0160BE0;\n\tTue, 3 Sep 2019 06:08:12 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": [ "from auto-whitelisted by SQLgrey-1.7.6", "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]); Tue, 03 Sep 2019 06:08:14 +0000 (UTC)" ], "From": "Stefan Assmann <sassmann@kpanic.de>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 3 Sep 2019 08:08:10 +0200", "Message-Id": "<20190903060810.30775-1-sassmann@kpanic.de>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "Subject": "[Intel-wired-lan] [PATCH] i40e: clear __I40E_VIRTCHNL_OP_PENDING on\n\tinvalid min tx rate", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, davem@davemloft.net, sassmann@kpanic.de", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "In the case of an invalid min tx rate being requested\ni40e_ndo_set_vf_bw() immediately returns -EINVAL instead of releasing\n__I40E_VIRTCHNL_OP_PENDING first.\n\nSigned-off-by: Stefan Assmann <sassmann@kpanic.de>\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex f8aa4deceb5e..3d2440838822 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -4263,7 +4263,8 @@ int i40e_ndo_set_vf_bw(struct net_device *netdev, int vf_id, int min_tx_rate,\n \tif (min_tx_rate) {\n \t\tdev_err(&pf->pdev->dev, \"Invalid min tx rate (%d) (greater than 0) specified for VF %d.\\n\",\n \t\t\tmin_tx_rate, vf_id);\n-\t\treturn -EINVAL;\n+\t\tret = -EINVAL;\n+\t\tgoto error;\n \t}\n \n \tvf = &pf->vf[vf_id];\n", "prefixes": [] }