Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1154090/?format=api
{ "id": 1154090, "url": "http://patchwork.ozlabs.org/api/patches/1154090/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190827131354.12703-2-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190827131354.12703-2-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2019-08-27T13:13:47", "name": "[S28,2/9] ice: report link down for VF when PF's queues are not enabled", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bca265b4d2b9aea9369dab2bc4f66f672ec2480a", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190827131354.12703-2-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 127658, "url": "http://patchwork.ozlabs.org/api/series/127658/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=127658", "date": "2019-08-27T13:13:48", "name": "[S28,1/9] ice: Reliably reset VFs", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/127658/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1154090/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1154090/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 46J2Rh6zbYz9sDB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 28 Aug 2019 07:43:12 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 9062322FD5;\n\tTue, 27 Aug 2019 21:43:11 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id SxPGn8B7J59U; Tue, 27 Aug 2019 21:43:09 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5CAF42322B;\n\tTue, 27 Aug 2019 21:43:07 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9B6481BF97D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Aug 2019 21:43:02 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 987AA868CB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Aug 2019 21:43:02 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id D-7Czl-R64Av for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Aug 2019 21:43:01 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id B437386B15\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Aug 2019 21:43:00 +0000 (UTC)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Aug 2019 14:42:59 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby orsmga008.jf.intel.com with ESMTP; 27 Aug 2019 14:42:59 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,438,1559545200\"; d=\"scan'208\";a=\"174703662\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 27 Aug 2019 06:13:47 -0700", "Message-Id": "<20190827131354.12703-2-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190827131354.12703-1-anthony.l.nguyen@intel.com>", "References": "<20190827131354.12703-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S28 2/9] ice: report link down for VF when\n\tPF's queues are not enabled", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Lukasz Czapnik <lukasz.czapnik@intel.com>\n\nThis is port of a fix from i40e commit 2ad1274fa35a (\"i40e: don't\nreport link up for a VF who hasn't enabled queues\")\n\nOlder VF drivers do not respond well to receiving a link\nup notification before queues are enabled. This can cause their state\nmachine to think that it is safe to send traffic. This results in a Tx\nhang on the VF.\n\nRecord whether the PF has actually enabled queues for the VF. When\nreporting link status, always report link down if the queues aren't\nenabled. In this way, the VF driver will never receive a link up\nnotification until after its queues are enabled.\n\nSigned-off-by: Lukasz Czapnik <lukasz.czapnik@intel.com>\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\nindex 3ba6613048ef..1ec2a037a369 100644\n--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n@@ -129,7 +129,10 @@ static void ice_vc_notify_vf_link_state(struct ice_vf *vf)\n \tpfe.event = VIRTCHNL_EVENT_LINK_CHANGE;\n \tpfe.severity = PF_EVENT_SEVERITY_INFO;\n \n-\tif (vf->link_forced)\n+\t/* Always report link is down if the VF queues aren't enabled */\n+\tif (!vf->num_qs_ena)\n+\t\tice_set_pfe_link(vf, &pfe, ICE_AQ_LINK_SPEED_UNKNOWN, false);\n+\telse if (vf->link_forced)\n \t\tice_set_pfe_link_forced(vf, &pfe, vf->link_up);\n \telse\n \t\tice_set_pfe_link(vf, &pfe, ls->link_speed, ls->link_info &\n", "prefixes": [ "S28", "2/9" ] }