Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1153708/?format=api
{ "id": 1153708, "url": "http://patchwork.ozlabs.org/api/patches/1153708/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20190827101235.46371-4-Zhiqiang.Hou@nxp.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190827101235.46371-4-Zhiqiang.Hou@nxp.com>", "list_archive_url": null, "date": "2019-08-27T10:13:54", "name": "[U-Boot,PATCHv3,3/3] dm: pcie_fsl: Fix the calculation of controller index", "commit_ref": "fbcb2ff5c6477c7d2ddc9f54967a5cfc21aefbed", "pull_url": null, "state": "accepted", "archived": false, "hash": "7bbd00a190d68f8ba8ddc976dff22e8e6f39352b", "submitter": { "id": 67929, "url": "http://patchwork.ozlabs.org/api/people/67929/?format=api", "name": "Z.Q. Hou", "email": "zhiqiang.hou@nxp.com" }, "delegate": { "id": 2467, "url": "http://patchwork.ozlabs.org/api/users/2467/?format=api", "username": "prabhu_kush", "first_name": "Prabhakar", "last_name": "Kushwaha", "email": "prabhakar@freescale.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20190827101235.46371-4-Zhiqiang.Hou@nxp.com/mbox/", "series": [ { "id": 127507, "url": "http://patchwork.ozlabs.org/api/series/127507/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=127507", "date": "2019-08-27T10:13:45", "name": "dm: pcie_fsl: Fix some issues", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/127507/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1153708/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1153708/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=nxp.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"K4kvZZ3Y\";\n\tdkim-atps=neutral", "spf=none (sender IP is )\n\tsmtp.mailfrom=zhiqiang.hou@nxp.com; " ], "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 46Hl9K6ngmz9s00\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 27 Aug 2019 20:14:45 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid 9A3F7C22003; Tue, 27 Aug 2019 10:14:21 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id B2323C2202C;\n\tTue, 27 Aug 2019 10:14:19 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 91045C21FF3; Tue, 27 Aug 2019 10:13:58 +0000 (UTC)", "from EUR04-DB3-obe.outbound.protection.outlook.com\n\t(mail-eopbgr60087.outbound.protection.outlook.com [40.107.6.87])\n\tby lists.denx.de (Postfix) with ESMTPS id 0CC3EC21E9F\n\tfor <u-boot@lists.denx.de>; Tue, 27 Aug 2019 10:13:56 +0000 (UTC)", "from DB8PR04MB6747.eurprd04.prod.outlook.com (20.179.250.159) by\n\tDB8PR04MB6538.eurprd04.prod.outlook.com (20.179.249.86) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.2199.19; Tue, 27 Aug 2019 10:13:55 +0000", "from DB8PR04MB6747.eurprd04.prod.outlook.com\n\t([fe80::7c8a:ab5d:dc27:be5f]) by\n\tDB8PR04MB6747.eurprd04.prod.outlook.com\n\t([fe80::7c8a:ab5d:dc27:be5f%6]) with mapi id 15.20.2199.021;\n\tTue, 27 Aug 2019 10:13:54 +0000" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.0 required=5.0 tests=SPF_HELO_PASS, T_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=cW3g3b0Ek/wvOSAgyAdQkHWja0KpHdWRO74Y5X/Q+k6/JmdYKx0zjrordprL7Mdfqi5kEGuI9BFREOv0K7YPEgTLU2Gz4iwk2cjdesdtBP+C5+Kdts8QpqG94646KZhfx5XjsWu1ZufUZIvwzDM1OAhrPgRpt1Sw5Z7H6NiL00KTDAIJZR37BM/FgFlSftU5iqqBG08/KgCJw9MSgtWRPx/oa6i0iO6ata032qVImR2ekTVBgc112qPY75UCkE+jqpJuxvsLlOvEq6Y8BWTECpd6PpXIY3nl1BoLs6fS9vf6JOD6xkvJrKywM0pMwtq5Crg4QF8KeJLX0OOhtXKOqQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=NDXSruN3EcjojDC2EsIbieSZtDvMigx5uBzI8tW9G4w=;\n\tb=A64wJzRg+igS8lOg/096IWopK+Ws1qyr5E3QGlo9b3uiuFgz1WiuZywJAZLx9MF3X4Dg0Ow3gM7VWJIChrH1sVi3+q+01mtlcXahiztMBiSisSagYcQ+1MEExCkh1DXCzFx7wKu4vYfSJFGjatvpTZYQkyFga6IHVtuVP9uEwedSEouS+clGZKPr/fQTyNPbCgEoazqCoKOmC6MH6+AHytPTya/ry3X7BP0/N9aA3OidMYw5JHbDS5mLDMKPCb57LdTg/L0mdxttDfh1XYgkAk1orMq4/JgNugq18lNRtfh4qG/8RwyPAu2dDsolY+k0/mUfwDYTJW3EcnbylOlCFw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=NDXSruN3EcjojDC2EsIbieSZtDvMigx5uBzI8tW9G4w=;\n\tb=K4kvZZ3YvGJ/puspjCCLsCeq2Xu5A5zbevRNExUZ9iOSfY2lxwkKV01pexLrP0E9rYfDLvM5dy+GiA902cENVT7DBbJn651qcNR8dCXdabZB7fBz7sKeZ95IkbZPc7w0gMbRjFQlMrvK2UmRWOUH9vUjqLAEHOP2T24nZ0uzGAY=", "From": "\"Z.q. Hou\" <zhiqiang.hou@nxp.com>", "To": "\"u-boot@lists.denx.de\" <u-boot@lists.denx.de>, Prabhakar Kushwaha\n\t<prabhakar.kushwaha@nxp.com>, \"bmeng.cn@gmail.com\" <bmeng.cn@gmail.com>", "Thread-Topic": "[PATCHv3 3/3] dm: pcie_fsl: Fix the calculation of controller\n\tindex", "Thread-Index": "AQHVXMAheIS9qsD3w06VsaB1s2zA9A==", "Date": "Tue, 27 Aug 2019 10:13:54 +0000", "Message-ID": "<20190827101235.46371-4-Zhiqiang.Hou@nxp.com>", "References": "<20190827101235.46371-1-Zhiqiang.Hou@nxp.com>", "In-Reply-To": "<20190827101235.46371-1-Zhiqiang.Hou@nxp.com>", "Accept-Language": "zh-CN, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "HK2PR0401CA0010.apcprd04.prod.outlook.com\n\t(2603:1096:202:2::20) To DB8PR04MB6747.eurprd04.prod.outlook.com\n\t(2603:10a6:10:10b::31)", "authentication-results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=nxp.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"K4kvZZ3Y\";\n\tdkim-atps=neutral", "spf=none (sender IP is )\n\tsmtp.mailfrom=zhiqiang.hou@nxp.com; " ], "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.17.1", "x-originating-ip": "[119.31.174.73]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "d9ee9c28-b620-4a40-f574-08d72ad743c9", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);\n\tSRVR:DB8PR04MB6538; ", "x-ms-traffictypediagnostic": "DB8PR04MB6538:", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "<DB8PR04MB653898299748333CBE42449A84A00@DB8PR04MB6538.eurprd04.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:3044;", "x-forefront-prvs": "0142F22657", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(4636009)(136003)(396003)(366004)(39860400002)(346002)(376002)(199004)(189003)(53936002)(6436002)(2906002)(7736002)(478600001)(6116002)(3846002)(71200400001)(486006)(8936002)(5660300002)(81156014)(81166006)(50226002)(2501003)(36756003)(71190400001)(316002)(6486002)(66066001)(305945005)(14454004)(25786009)(256004)(4326008)(1076003)(446003)(2616005)(8676002)(66476007)(66556008)(64756008)(66446008)(476003)(66946007)(11346002)(99286004)(52116002)(76176011)(386003)(26005)(6512007)(6506007)(110136005)(86362001)(186003)(102836004);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DB8PR04MB6538;\n\tH:DB8PR04MB6747.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "3bvJc+gCU9TgXpUbnciJZY4aRfczdz2Pz8QpfEKpzUjsydnvK5iImQe7O1eQjQChC9/+tJpdfr/n+5Eq25Rv6G2fCCcrFMM9gqbGSwpQkL61TzFVvz4KjqSek+uIdAP0sQc0q+cNuM2BfWA9Xoqx1dLT5F1vhf97OXl1b9DSSb6fh+SY5x4WNxsthYK0OG34nDiKAI0LB+YCRA5bQhoZWxLEvu/He6fNQCxjHPDZIb6xZ5/0KAqkIME/+Fahh0EcsyM/bmhsAVKYn36S4RlUct5VbgLIWPdlRM/kKuy6IflUbQZ0HpSIvzFh8qWdChK1yzdsof4XFD7gqWqgUJrrnXX4zhqgRYkgcuvaVANzyggQT8BNOv4IbYCBext0fw9B62uPyFjizIkMluUnnf4PYL1xrIao+yJVZbEkQNZ81lQ=", "MIME-Version": "1.0", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "d9ee9c28-b620-4a40-f574-08d72ad743c9", "X-MS-Exchange-CrossTenant-originalarrivaltime": "27 Aug 2019 10:13:54.4596\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "rWRFMc4XxXSJwDzkSJWiU1MoYYmBADhBLsybNGKUEwsX3DT0FZJ95tPflF5UOrfoi+J1eEehsrlvY/QGs9pdfw==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB8PR04MB6538", "Cc": "\"Z.q. Hou\" <zhiqiang.hou@nxp.com>", "Subject": "[U-Boot] [PATCHv3 3/3] dm: pcie_fsl: Fix the calculation of\n\tcontroller index", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>\n\nThe PCIe controller register address in CCSR is different\non various platforms, the current code erroneously use\nthe hardcoded address (0xffe240000) and stride (0x10000)\nto calculate the controller's index.\n\nFix it by adding the related info to the driver data\nstructure.\n\nSigned-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>\nReviewed-by: Bin Meng <bmeng.cn@gmail.com>\n---\nV3:\n - No change.\n\n drivers/pci/pcie_fsl.c | 14 ++++++++++++--\n drivers/pci/pcie_fsl.h | 7 +++++++\n 2 files changed, 19 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/pci/pcie_fsl.c b/drivers/pci/pcie_fsl.c\nindex 1be5063467..d3d2c191e5 100644\n--- a/drivers/pci/pcie_fsl.c\n+++ b/drivers/pci/pcie_fsl.c\n@@ -582,6 +582,7 @@ static int fsl_pcie_probe(struct udevice *dev)\n static int fsl_pcie_ofdata_to_platdata(struct udevice *dev)\n {\n \tstruct fsl_pcie *pcie = dev_get_priv(dev);\n+\tstruct fsl_pcie_data *info;\n \tint ret;\n \n \tpcie->regs = dev_remap_addr(dev);\n@@ -596,7 +597,10 @@ static int fsl_pcie_ofdata_to_platdata(struct udevice *dev)\n \t\treturn ret;\n \t}\n \n-\tpcie->idx = (dev_read_addr(dev) - 0xffe240000) / 0x10000;\n+\tinfo = (struct fsl_pcie_data *)dev_get_driver_data(dev);\n+\tpcie->info = info;\n+\tpcie->idx = abs((u32)(dev_read_addr(dev) & info->block_offset_mask) -\n+\t\t info->block_offset) / info->stride;\n \n \treturn 0;\n }\n@@ -606,8 +610,14 @@ static const struct dm_pci_ops fsl_pcie_ops = {\n \t.write_config\t= fsl_pcie_write_config,\n };\n \n+static struct fsl_pcie_data t2080_data = {\n+\t.block_offset = 0x240000,\n+\t.block_offset_mask = 0x3fffff,\n+\t.stride = 0x10000,\n+};\n+\n static const struct udevice_id fsl_pcie_ids[] = {\n-\t{ .compatible = \"fsl,pcie-t2080\" },\n+\t{ .compatible = \"fsl,pcie-t2080\", .data = (ulong)&t2080_data },\n \t{ }\n };\n \ndiff --git a/drivers/pci/pcie_fsl.h b/drivers/pci/pcie_fsl.h\nindex 032775ca05..dc8368d559 100644\n--- a/drivers/pci/pcie_fsl.h\n+++ b/drivers/pci/pcie_fsl.h\n@@ -43,6 +43,12 @@\n #define LTSSM_L0_REV3\t\t\t0x11\n #define LTSSM_L0\t\t\t0x16\n \n+struct fsl_pcie_data {\n+\tu32 block_offset;\t\t/* Offset from CCSR of 1st controller */\n+\tu32 block_offset_mask;\t\t/* Mask out the CCSR base */\n+\tu32 stride;\t\t\t/* Offset stride between controllers */\n+};\n+\n struct fsl_pcie {\n \tint idx;\n \tstruct udevice *bus;\n@@ -52,6 +58,7 @@ struct fsl_pcie {\n \tbool mode;\t\t\t/* RC&EP mode flag */\n \tbool enabled;\t\t\t/* Enable status */\n \tstruct list_head list;\n+\tstruct fsl_pcie_data *info;\n };\n \n extern struct list_head fsl_pcie_list;\n", "prefixes": [ "U-Boot", "PATCHv3", "3/3" ] }