Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1153375/?format=api
{ "id": 1153375, "url": "http://patchwork.ozlabs.org/api/patches/1153375/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190826181655.15106-5-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190826181655.15106-5-alice.michael@intel.com>", "list_archive_url": null, "date": "2019-08-26T18:16:53", "name": "[next,S9,5/7] i40e: fix missed \"Negotiated\" string in i40e_print_link_message()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "212e9e56585f1002055ad8f82a46a6b38d5025a6", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190826181655.15106-5-alice.michael@intel.com/mbox/", "series": [ { "id": 127371, "url": "http://patchwork.ozlabs.org/api/series/127371/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=127371", "date": "2019-08-26T18:16:51", "name": "[next,S9,1/7] i40e: Allow updating OROM when a NIC is in recovery mode", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/127371/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1153375/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1153375/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 46HKwM3vRYz9sDQ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 27 Aug 2019 04:17:07 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 1D4D02264C;\n\tMon, 26 Aug 2019 18:17:06 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6lNaWpTPE0AM; Mon, 26 Aug 2019 18:17:02 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id D988A2265B;\n\tMon, 26 Aug 2019 18:17:00 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 0B0761BF2CF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 26 Aug 2019 18:16:59 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 08E22880C2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 26 Aug 2019 18:16:59 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Wb7-AF6xwuKK for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 26 Aug 2019 18:16:58 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 94A1E880D9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 26 Aug 2019 18:16:58 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Aug 2019 11:16:58 -0700", "from alicemic-1.jf.intel.com ([10.166.17.62])\n\tby orsmga005.jf.intel.com with ESMTP; 26 Aug 2019 11:16:57 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,433,1559545200\"; d=\"scan'208\";a=\"355508893\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Mon, 26 Aug 2019 11:16:53 -0700", "Message-Id": "<20190826181655.15106-5-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190826181655.15106-1-alice.michael@intel.com>", "References": "<20190826181655.15106-1-alice.michael@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S9 5/7] i40e: fix missed \"Negotiated\"\n\tstring in i40e_print_link_message()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n\nThe \"Negotiated\" string in i40e_print_link_message() function was missed.\nThis string has been added to the dmesg and small refactoring done removing\ncommon substrings and unifying link status message format.\nWithout this patch it was not clear that FEC is related to negotiated FEC.\n\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 19 ++++++++++---------\n 1 file changed, 10 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex ed8e62cb5417..161663de09ef 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -6564,19 +6564,19 @@ void i40e_print_link_message(struct i40e_vsi *vsi, bool isup)\n \t}\n \n \tif (pf->hw.phy.link_info.link_speed == I40E_LINK_SPEED_25GB) {\n-\t\treq_fec = \", Requested FEC: None\";\n-\t\tfec = \", FEC: None\";\n-\t\tan = \", Autoneg: False\";\n+\t\treq_fec = \"None\";\n+\t\tfec = \"None\";\n+\t\tan = \"False\";\n \n \t\tif (pf->hw.phy.link_info.an_info & I40E_AQ_AN_COMPLETED)\n-\t\t\tan = \", Autoneg: True\";\n+\t\t\tan = \"True\";\n \n \t\tif (pf->hw.phy.link_info.fec_info &\n \t\t I40E_AQ_CONFIG_FEC_KR_ENA)\n-\t\t\tfec = \", FEC: CL74 FC-FEC/BASE-R\";\n+\t\t\tfec = \"CL74 FC-FEC/BASE-R\";\n \t\telse if (pf->hw.phy.link_info.fec_info &\n \t\t\t I40E_AQ_CONFIG_FEC_RS_ENA)\n-\t\t\tfec = \", FEC: CL108 RS-FEC\";\n+\t\t\tfec = \"CL108 RS-FEC\";\n \n \t\t/* 'CL108 RS-FEC' should be displayed when RS is requested, or\n \t\t * both RS and FC are requested\n@@ -6585,13 +6585,14 @@ void i40e_print_link_message(struct i40e_vsi *vsi, bool isup)\n \t\t (I40E_AQ_REQUEST_FEC_KR | I40E_AQ_REQUEST_FEC_RS)) {\n \t\t\tif (vsi->back->hw.phy.link_info.req_fec_info &\n \t\t\t I40E_AQ_REQUEST_FEC_RS)\n-\t\t\t\treq_fec = \", Requested FEC: CL108 RS-FEC\";\n+\t\t\t\treq_fec = \"CL108 RS-FEC\";\n \t\t\telse\n-\t\t\t\treq_fec = \", Requested FEC: CL74 FC-FEC/BASE-R\";\n+\t\t\t\treq_fec = \"CL74 FC-FEC/BASE-R\";\n \t\t}\n \t}\n \n-\tnetdev_info(vsi->netdev, \"NIC Link is Up, %sbps Full Duplex%s%s%s, Flow Control: %s\\n\",\n+\tnetdev_info(vsi->netdev,\n+\t\t \"NIC Link is Up, %sbps Full Duplex, Requested FEC: %s, Negotiated FEC: %s, Autoneg: %s, Flow Control: %s\\n\",\n \t\t speed, req_fec, fec, an, fc);\n }\n \n", "prefixes": [ "next", "S9", "5/7" ] }