Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1151777/?format=api
{ "id": 1151777, "url": "http://patchwork.ozlabs.org/api/patches/1151777/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190822183318.27634-1-lyude@redhat.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190822183318.27634-1-lyude@redhat.com>", "list_archive_url": null, "date": "2019-08-22T18:33:18", "name": "igb/igc: Don't warn on fatal read failures when the device is removed", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "efb4ed57bd3c0b19ea9c9e445565788b244b4c5d", "submitter": { "id": 70744, "url": "http://patchwork.ozlabs.org/api/people/70744/?format=api", "name": "Lyude Paul", "email": "lyude@redhat.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190822183318.27634-1-lyude@redhat.com/mbox/", "series": [ { "id": 126818, "url": "http://patchwork.ozlabs.org/api/series/126818/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=126818", "date": "2019-08-22T18:33:18", "name": "igb/igc: Don't warn on fatal read failures when the device is removed", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/126818/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1151777/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1151777/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=redhat.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 46DwRc3MmRz9sN1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 23 Aug 2019 06:02:19 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 2AF0F86B31;\n\tThu, 22 Aug 2019 20:02:17 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id nZuDSf7XMiDi; Thu, 22 Aug 2019 20:02:16 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1455E86B2C;\n\tThu, 22 Aug 2019 20:02:16 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 4B3191BF3BE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Aug 2019 18:33:39 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 35D0A2038B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Aug 2019 18:33:39 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Ojim6d7l9wfs for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Aug 2019 18:33:38 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 7D0CF20385\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Aug 2019 18:33:38 +0000 (UTC)", "from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C6C87C0546FE;\n\tThu, 22 Aug 2019 18:33:37 +0000 (UTC)", "from malachite.bss.redhat.com (dhcp-10-20-1-11.bss.redhat.com\n\t[10.20.1.11])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5718A18517;\n\tThu, 22 Aug 2019 18:33:34 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": [ "domain auto-whitelisted by SQLgrey-1.7.6", "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]); Thu, 22 Aug 2019 18:33:37 +0000 (UTC)" ], "From": "Lyude Paul <lyude@redhat.com>", "To": "intel-wired-lan@lists.osuosl.org,\n\tnetdev@vger.kernel.org", "Date": "Thu, 22 Aug 2019 14:33:18 -0400", "Message-Id": "<20190822183318.27634-1-lyude@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.14", "X-Mailman-Approved-At": "Thu, 22 Aug 2019 20:02:14 +0000", "Subject": "[Intel-wired-lan] [PATCH] igb/igc: Don't warn on fatal read\n\tfailures when the device is removed", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "linux-kernel@vger.kernel.org, \"David S. Miller\" <davem@davemloft.net>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Fatal read errors are worth warning about, unless of course the device\nwas just unplugged from the machine - something that's a rather normal\noccurence when the igb/igc adapter is located on a Thunderbolt dock. So,\nlet's only WARN() if there's a fatal read error while the device is\nstill present.\n\nThis fixes the following WARN splat that's been appearing whenever I\nunplug my Caldigit TS3 Thunderbolt dock from my laptop:\n\n igb 0000:09:00.0 enp9s0: PCIe link lost\n ------------[ cut here ]------------\n igb: Failed to read reg 0x18!\n WARNING: CPU: 7 PID: 516 at\n drivers/net/ethernet/intel/igb/igb_main.c:756 igb_rd32+0x57/0x6a [igb]\n Modules linked in: igb dca thunderbolt fuse vfat fat elan_i2c mei_wdt\n mei_hdcp i915 wmi_bmof intel_wmi_thunderbolt iTCO_wdt\n iTCO_vendor_support x86_pkg_temp_thermal intel_powerclamp joydev\n coretemp crct10dif_pclmul crc32_pclmul i2c_algo_bit ghash_clmulni_intel\n intel_cstate drm_kms_helper intel_uncore syscopyarea sysfillrect\n sysimgblt fb_sys_fops intel_rapl_perf intel_xhci_usb_role_switch mei_me\n drm roles idma64 i2c_i801 ucsi_acpi typec_ucsi mei intel_lpss_pci\n processor_thermal_device typec intel_pch_thermal intel_soc_dts_iosf\n intel_lpss int3403_thermal thinkpad_acpi wmi int340x_thermal_zone\n ledtrig_audio int3400_thermal acpi_thermal_rel acpi_pad video\n pcc_cpufreq ip_tables serio_raw nvme nvme_core crc32c_intel uas\n usb_storage e1000e i2c_dev\n CPU: 7 PID: 516 Comm: kworker/u16:3 Not tainted 5.2.0-rc1Lyude-Test+ #14\n Hardware name: LENOVO 20L8S2N800/20L8S2N800, BIOS N22ET35W (1.12 ) 04/09/2018\n Workqueue: kacpi_hotplug acpi_hotplug_work_fn\n RIP: 0010:igb_rd32+0x57/0x6a [igb]\n Code: 87 b8 fc ff ff 48 c7 47 08 00 00 00 00 48 c7 c6 33 42 9b c0 4c 89\n c7 e8 47 45 cd dc 89 ee 48 c7 c7 43 42 9b c0 e8 c1 94 71 dc <0f> 0b eb\n 08 8b 00 ff c0 75 b0 eb c8 44 89 e0 5d 41 5c c3 0f 1f 44\n RSP: 0018:ffffba5801cf7c48 EFLAGS: 00010286\n RAX: 0000000000000000 RBX: ffff9e7956608840 RCX: 0000000000000007\n RDX: 0000000000000000 RSI: ffffba5801cf7b24 RDI: ffff9e795e3d6a00\n RBP: 0000000000000018 R08: 000000009dec4a01 R09: ffffffff9e61018f\n R10: 0000000000000000 R11: ffffba5801cf7ae5 R12: 00000000ffffffff\n R13: ffff9e7956608840 R14: ffff9e795a6f10b0 R15: 0000000000000000\n FS: 0000000000000000(0000) GS:ffff9e795e3c0000(0000) knlGS:0000000000000000\n CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033\n CR2: 0000564317bc4088 CR3: 000000010e00a006 CR4: 00000000003606e0\n DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000\n DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400\n Call Trace:\n igb_release_hw_control+0x1a/0x30 [igb]\n igb_remove+0xc5/0x14b [igb]\n pci_device_remove+0x3b/0x93\n device_release_driver_internal+0xd7/0x17e\n pci_stop_bus_device+0x36/0x75\n pci_stop_bus_device+0x66/0x75\n pci_stop_bus_device+0x66/0x75\n pci_stop_and_remove_bus_device+0xf/0x19\n trim_stale_devices+0xc5/0x13a\n ? __pm_runtime_resume+0x6e/0x7b\n trim_stale_devices+0x103/0x13a\n ? __pm_runtime_resume+0x6e/0x7b\n trim_stale_devices+0x103/0x13a\n acpiphp_check_bridge+0xd8/0xf5\n acpiphp_hotplug_notify+0xf7/0x14b\n ? acpiphp_check_bridge+0xf5/0xf5\n acpi_device_hotplug+0x357/0x3b5\n acpi_hotplug_work_fn+0x1a/0x23\n process_one_work+0x1a7/0x296\n worker_thread+0x1a8/0x24c\n ? process_scheduled_works+0x2c/0x2c\n kthread+0xe9/0xee\n ? kthread_destroy_worker+0x41/0x41\n ret_from_fork+0x35/0x40\n ---[ end trace 252bf10352c63d22 ]---\n\nSigned-off-by: Lyude Paul <lyude@redhat.com>\nFixes: 47e16692b26b (\"igb/igc: warn when fatal read failure happens\")\nCc: Feng Tang <feng.tang@intel.com>\nCc: Sasha Neftin <sasha.neftin@intel.com>\nCc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\nCc: intel-wired-lan@lists.osuosl.org\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 3 ++-\n drivers/net/ethernet/intel/igc/igc_main.c | 3 ++-\n 2 files changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex e5b7e638df28..1a7f7cd28df9 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -753,7 +753,8 @@ u32 igb_rd32(struct e1000_hw *hw, u32 reg)\n \t\tstruct net_device *netdev = igb->netdev;\n \t\thw->hw_addr = NULL;\n \t\tnetdev_err(netdev, \"PCIe link lost\\n\");\n-\t\tWARN(1, \"igb: Failed to read reg 0x%x!\\n\", reg);\n+\t\tWARN(pci_device_is_present(igb->pdev),\n+\t\t \"igb: Failed to read reg 0x%x!\\n\", reg);\n \t}\n \n \treturn value;\ndiff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex 28072b9aa932..f873a4b35eaf 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -3934,7 +3934,8 @@ u32 igc_rd32(struct igc_hw *hw, u32 reg)\n \t\thw->hw_addr = NULL;\n \t\tnetif_device_detach(netdev);\n \t\tnetdev_err(netdev, \"PCIe link lost, device now detached\\n\");\n-\t\tWARN(1, \"igc: Failed to read reg 0x%x!\\n\", reg);\n+\t\tWARN(pci_device_is_present(igc->pdev),\n+\t\t \"igc: Failed to read reg 0x%x!\\n\", reg);\n \t}\n \n \treturn value;\n", "prefixes": [] }