Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1150313/?format=api
{ "id": 1150313, "url": "http://patchwork.ozlabs.org/api/patches/1150313/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190820085237.35579-1-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190820085237.35579-1-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2019-08-20T08:52:37", "name": "[net-next,v3,04/14] ice: fix set pause param autoneg check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "97f0a74f5a2dbdab51e551e2f55a287847067147", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190820085237.35579-1-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 126297, "url": "http://patchwork.ozlabs.org/api/series/126297/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=126297", "date": "2019-08-20T08:52:37", "name": null, "version": 3, "mbox": "http://patchwork.ozlabs.org/series/126297/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1150313/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1150313/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 46Ccz74GFWz9s4Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 21 Aug 2019 03:21:36 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 773442286F;\n\tTue, 20 Aug 2019 17:21:34 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id EPKMk2hPSpwC; Tue, 20 Aug 2019 17:21:32 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 91D2F22889;\n\tTue, 20 Aug 2019 17:21:32 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 66CD11BF681\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Aug 2019 17:21:31 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 6351B2287D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Aug 2019 17:21:31 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id sh6PPoDC-Hn4 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Aug 2019 17:21:27 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 7DFF622855\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 20 Aug 2019 17:21:27 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Aug 2019 10:21:17 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby orsmga002.jf.intel.com with ESMTP; 20 Aug 2019 10:21:17 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,408,1559545200\"; d=\"scan'208\";a=\"189928437\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 20 Aug 2019 01:52:37 -0700", "Message-Id": "<20190820085237.35579-1-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [net-next v3 04/14] ice: fix set pause param\n\tautoneg check", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Paul Greenwalt <paul.greenwalt@intel.com>\n\nWhen ETHTOOL_GLINKSETTINGS is defined get pause param pause->autoneg\nreports SW configured setting, however when not defined get pause param\npause->autoneg reports the link status. Set pause param needs to compare\npause->autoneg with the same source as get pause param to block the user\nfrom changing autoneg with the set pause param option, or the user\nmay be incorrectly blocked from changing Rx|Tx pause settings.\n\nSigned-off-by: Paul Greenwalt <paul.greenwalt@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 27 +++++++++++++++++++-\n 1 file changed, 26 insertions(+), 1 deletion(-)\n---\nv3:\n - Use kzalloc/kfree instead of devm_kzalloc/devm_kzfree", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex 1fe048cfb737..0099cfb21860 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -2856,6 +2856,7 @@ static int\n ice_set_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *pause)\n {\n \tstruct ice_netdev_priv *np = netdev_priv(netdev);\n+\tstruct ice_aqc_get_phy_caps_data *pcaps;\n \tstruct ice_link_status *hw_link_info;\n \tstruct ice_pf *pf = np->vsi->back;\n \tstruct ice_dcbx_cfg *dcbx_cfg;\n@@ -2866,6 +2867,7 @@ ice_set_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *pause)\n \tu8 aq_failures;\n \tbool link_up;\n \tint err = 0;\n+\tu32 is_an;\n \n \tpi = vsi->port_info;\n \thw_link_info = &pi->phy.link_info;\n@@ -2880,7 +2882,30 @@ ice_set_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *pause)\n \t\treturn -EOPNOTSUPP;\n \t}\n \n-\tif (pause->autoneg != (hw_link_info->an_info & ICE_AQ_AN_COMPLETED)) {\n+\t/* Get pause param reports configured and negotiated flow control pause\n+\t * when ETHTOOL_GLINKSETTINGS is defined. Since ETHTOOL_GLINKSETTINGS is\n+\t * defined get pause param pause->autoneg reports SW configured setting,\n+\t * so compare pause->autoneg with SW configured to prevent the user from\n+\t * using set pause param to chance autoneg.\n+\t */\n+\tpcaps = kzalloc(sizeof(*pcaps), GFP_KERNEL);\n+\tif (!pcaps)\n+\t\treturn -ENOMEM;\n+\n+\t/* Get current PHY config */\n+\tstatus = ice_aq_get_phy_caps(pi, false, ICE_AQC_REPORT_SW_CFG, pcaps,\n+\t\t\t\t NULL);\n+\tif (status) {\n+\t\tkfree(pcaps);\n+\t\treturn -EIO;\n+\t}\n+\n+\tis_an = ((pcaps->caps & ICE_AQC_PHY_AN_MODE) ?\n+\t\t\tAUTONEG_ENABLE : AUTONEG_DISABLE);\n+\n+\tkfree(pcaps);\n+\n+\tif (pause->autoneg != is_an) {\n \t\tnetdev_info(netdev, \"To change autoneg please use: ethtool -s <dev> autoneg <on|off>\\n\");\n \t\treturn -EOPNOTSUPP;\n \t}\n", "prefixes": [ "net-next", "v3", "04/14" ] }