Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1147831/?format=api
{ "id": 1147831, "url": "http://patchwork.ozlabs.org/api/patches/1147831/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190815205520.22475-2-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190815205520.22475-2-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2019-08-15T20:55:20", "name": "[net,2/2] igb: Fix constant media auto sense switching when no cable is connected.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6d4286b7e93a6105f3dc1cea36d0a0dd32fcedc5", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190815205520.22475-2-jeffrey.t.kirsher@intel.com/mbox/", "series": [ { "id": 125455, "url": "http://patchwork.ozlabs.org/api/series/125455/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=125455", "date": "2019-08-15T20:55:19", "name": "[net,1/2] igb: Enable media autosense for the i350.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/125455/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1147831/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1147831/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 468dyB6Zwhz9sN1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 16 Aug 2019 06:55:30 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7A82986155;\n\tThu, 15 Aug 2019 20:55:29 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id EkRdOPH_eK_9; Thu, 15 Aug 2019 20:55:27 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id CE00B85FC1;\n\tThu, 15 Aug 2019 20:55:27 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 067581BF39E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Aug 2019 20:55:26 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 0131B87851\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Aug 2019 20:55:26 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Fo0LlxnYfxyp for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Aug 2019 20:55:25 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 7B45787863\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Aug 2019 20:55:25 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t15 Aug 2019 13:55:25 -0700", "from jtkirshe-desk1.jf.intel.com ([134.134.177.96])\n\tby orsmga002.jf.intel.com with ESMTP; 15 Aug 2019 13:55:25 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,389,1559545200\"; d=\"scan'208\";a=\"188609492\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 15 Aug 2019 13:55:20 -0700", "Message-Id": "<20190815205520.22475-2-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190815205520.22475-1-jeffrey.t.kirsher@intel.com>", "References": "<20190815205520.22475-1-jeffrey.t.kirsher@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH net 2/2] igb: Fix constant media auto\n\tsense switching when no cable is connected.", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Manfred Rudigier <manfred.rudigier@omicronenergy.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Manfred Rudigier <manfred.rudigier@omicronenergy.com>\n\nAt least on the i350 there is an annoying behavior that is maybe also\npresent on 82580 devices, but was probably not noticed yet as MAS is not\nwidely used.\n\nIf no cable is connected on both fiber/copper ports the media auto sense\ncode will constantly swap between them as part of the watchdog task and\nproduce many unnecessary kernel log messages.\n\nThe swap code responsible for this behavior (switching to fiber) should\nnot be executed if the current media type is copper and there is no signal\ndetected on the fiber port. In this case we can safely wait until the\nAUTOSENSE_EN bit is cleared.\n\nSigned-off-by: Manfred Rudigier <manfred.rudigier@omicronenergy.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 95fc1a178ff3..891cd072d4dd 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -2064,7 +2064,8 @@ static void igb_check_swap_media(struct igb_adapter *adapter)\n \tif ((hw->phy.media_type == e1000_media_type_copper) &&\n \t (!(connsw & E1000_CONNSW_AUTOSENSE_EN))) {\n \t\tswap_now = true;\n-\t} else if (!(connsw & E1000_CONNSW_SERDESD)) {\n+\t} else if ((hw->phy.media_type != e1000_media_type_copper) &&\n+\t !(connsw & E1000_CONNSW_SERDESD)) {\n \t\t/* copper signal takes time to appear */\n \t\tif (adapter->copper_tries < 4) {\n \t\t\tadapter->copper_tries++;\n", "prefixes": [ "net", "2/2" ] }