Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1145780/?format=api
{ "id": 1145780, "url": "http://patchwork.ozlabs.org/api/patches/1145780/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1565589561-5910-1-git-send-email-wenwen@cs.uga.edu/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1565589561-5910-1-git-send-email-wenwen@cs.uga.edu>", "list_archive_url": null, "date": "2019-08-12T05:59:21", "name": "e1000: fix memory leaks", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "71c0d5d4902d3b4a3a531852d218e5fe79fbe39b", "submitter": { "id": 77104, "url": "http://patchwork.ozlabs.org/api/people/77104/?format=api", "name": "Wenwen Wang", "email": "wenwen@cs.uga.edu" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1565589561-5910-1-git-send-email-wenwen@cs.uga.edu/mbox/", "series": [ { "id": 124619, "url": "http://patchwork.ozlabs.org/api/series/124619/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=124619", "date": "2019-08-12T05:59:21", "name": "e1000: fix memory leaks", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/124619/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1145780/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1145780/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=cs.uga.edu" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 466f2V0yHDz9sDQ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 13 Aug 2019 00:52:18 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id AAD802152E;\n\tMon, 12 Aug 2019 14:52:16 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zfsbVLsc98K1; Mon, 12 Aug 2019 14:52:14 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5AA722152F;\n\tMon, 12 Aug 2019 14:52:13 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7A8D61BF29F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Aug 2019 05:59:31 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6C455854E8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Aug 2019 05:59:31 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id nf8VdivBB3bJ for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Aug 2019 05:59:28 +0000 (UTC)", "from mail-yb1-f194.google.com (mail-yb1-f194.google.com\n\t[209.85.219.194])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 88219854E3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Aug 2019 05:59:28 +0000 (UTC)", "by mail-yb1-f194.google.com with SMTP id b16so6918996ybq.0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 11 Aug 2019 22:59:28 -0700 (PDT)", "from localhost.localdomain\n\t(24-158-240-219.dhcp.smyr.ga.charter.com. [24.158.240.219])\n\tby smtp.gmail.com with ESMTPSA id\n\te12sm24721471ywe.85.2019.08.11.22.59.26\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSun, 11 Aug 2019 22:59:26 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=N6oSMRPpHGkQ7E+kK6e4vXB5ZZOBX+MrIVovGvsXigg=;\n\tb=UudQMvinKPFXE55tLONrW5T/sib3WWzTwe6yEKcjsqi9iVjt5cMD8XBQ5QH9U995Fa\n\twnpq9UWLPJoJxFjGUVe9Xqjw0KlwpkIsGql68vxeQbIhg3u42V1qcIFodXEcfJT++Syv\n\thDgVSLKFDGC2cN3EXHB2dEDhdN/PGfEqVr1YVaPVvzadyPPhfNWktY21dPjfufbbYwAd\n\tP5ljjaHHg/5T4YJqZbqxA0Pbq6808+Jjtl+GFuWXODmQl7F64LJLR4n47xpwx/+yCaTR\n\tYF4IZQ8eG3f2DSkLbJM1quBoKcdiphERmv69anm/jAp4ovaPLdmKFLpQbbCdlAfr/yOl\n\tH62w==", "X-Gm-Message-State": "APjAAAXeXqfa0wqmrRQwJ2Ceid6HRkF1qhaZw+oHZMsdo48rdBMmB6Pc\n\tfqNqHBpiTGbFNB07pTsnv9I=", "X-Google-Smtp-Source": "APXvYqyH7bGaVBWLSU8sEzfL/N45LAWNBbDKUHxF98WHxf0lYev6I/BUIG/ZR/mT8bKm9nE2BGn1Zw==", "X-Received": "by 2002:a25:d794:: with SMTP id\n\to142mr9107179ybg.384.1565589567579; \n\tSun, 11 Aug 2019 22:59:27 -0700 (PDT)", "From": "Wenwen Wang <wenwen@cs.uga.edu>", "To": "Wenwen Wang <wenwen@cs.uga.edu>", "Date": "Mon, 12 Aug 2019 00:59:21 -0500", "Message-Id": "<1565589561-5910-1-git-send-email-wenwen@cs.uga.edu>", "X-Mailer": "git-send-email 2.7.4", "X-Mailman-Approved-At": "Mon, 12 Aug 2019 14:52:11 +0000", "Subject": "[Intel-wired-lan] [PATCH] e1000: fix memory leaks", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "\"open list:NETWORKING DRIVERS\" <netdev@vger.kernel.org>,\n\t\"moderated list:INTEL ETHERNET DRIVERS\"\n\t<intel-wired-lan@lists.osuosl.org>, \n\topen list <linux-kernel@vger.kernel.org>,\n\t\"David S. Miller\" <davem@davemloft.net>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "In e1000_set_ringparam(), 'tx_old' and 'rx_old' are not deallocated if\ne1000_up() fails, leading to memory leaks. Refactor the code to fix this\nissue.\n\nSigned-off-by: Wenwen Wang <wenwen@cs.uga.edu>\n---\n drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c\nindex a410085..2e07ffa 100644\n--- a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c\n+++ b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c\n@@ -607,6 +607,7 @@ static int e1000_set_ringparam(struct net_device *netdev,\n \tfor (i = 0; i < adapter->num_rx_queues; i++)\n \t\trxdr[i].count = rxdr->count;\n \n+\terr = 0;\n \tif (netif_running(adapter->netdev)) {\n \t\t/* Try to get new resources before deleting old */\n \t\terr = e1000_setup_all_rx_resources(adapter);\n@@ -627,14 +628,13 @@ static int e1000_set_ringparam(struct net_device *netdev,\n \t\tadapter->rx_ring = rxdr;\n \t\tadapter->tx_ring = txdr;\n \t\terr = e1000_up(adapter);\n-\t\tif (err)\n-\t\t\tgoto err_setup;\n \t}\n \tkfree(tx_old);\n \tkfree(rx_old);\n \n \tclear_bit(__E1000_RESETTING, &adapter->flags);\n-\treturn 0;\n+\treturn err;\n+\n err_setup_tx:\n \te1000_free_all_rx_resources(adapter);\n err_setup_rx:\n@@ -646,7 +646,6 @@ static int e1000_set_ringparam(struct net_device *netdev,\n err_alloc_tx:\n \tif (netif_running(adapter->netdev))\n \t\te1000_up(adapter);\n-err_setup:\n \tclear_bit(__E1000_RESETTING, &adapter->flags);\n \treturn err;\n }\n", "prefixes": [] }