Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1145779/?format=api
{ "id": 1145779, "url": "http://patchwork.ozlabs.org/api/patches/1145779/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1565554067-4994-1-git-send-email-wenwen@cs.uga.edu/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1565554067-4994-1-git-send-email-wenwen@cs.uga.edu>", "list_archive_url": null, "date": "2019-08-11T20:07:47", "name": "net: ixgbe: fix memory leaks", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d2d618efa9147afb2314de5973c089b10f8f52c9", "submitter": { "id": 77104, "url": "http://patchwork.ozlabs.org/api/people/77104/?format=api", "name": "Wenwen Wang", "email": "wenwen@cs.uga.edu" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1565554067-4994-1-git-send-email-wenwen@cs.uga.edu/mbox/", "series": [ { "id": 124618, "url": "http://patchwork.ozlabs.org/api/series/124618/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=124618", "date": "2019-08-11T20:07:47", "name": "net: ixgbe: fix memory leaks", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/124618/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1145779/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1145779/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=cs.uga.edu" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 466f2S2G2qz9sDQ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 13 Aug 2019 00:52:15 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 62FA321548;\n\tMon, 12 Aug 2019 14:52:14 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 55SGTKrX57f5; Mon, 12 Aug 2019 14:52:13 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 07E34203CA;\n\tMon, 12 Aug 2019 14:52:13 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9160D1BF322\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 11 Aug 2019 20:07:56 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8A824203B3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 11 Aug 2019 20:07:56 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id sL5ci6qNStQI for <intel-wired-lan@lists.osuosl.org>;\n\tSun, 11 Aug 2019 20:07:55 +0000 (UTC)", "from mail-yw1-f67.google.com (mail-yw1-f67.google.com\n\t[209.85.161.67])\n\tby silver.osuosl.org (Postfix) with ESMTPS id C4EB420130\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 11 Aug 2019 20:07:55 +0000 (UTC)", "by mail-yw1-f67.google.com with SMTP id z63so38057716ywz.9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 11 Aug 2019 13:07:55 -0700 (PDT)", "from localhost.localdomain\n\t(24-158-240-219.dhcp.smyr.ga.charter.com. [24.158.240.219])\n\tby smtp.gmail.com with ESMTPSA id\n\tx138sm23418950ywg.4.2019.08.11.13.07.53\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSun, 11 Aug 2019 13:07:54 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=I/wDFVoI+mYQ74OtLuR5i4v0k0nbe35K0FGp9EAyx0w=;\n\tb=pIXlDgVcOEm/EIgI/2RsUPv++Y6y5rpBhX8wvg64pEbHHu/o9/bzbLKX5cF/QI7um5\n\tiD8Kfq6ZQ1vep/VD7KldkfcOQY+deSy0lleliv8eFV+jUr606VXykf5oLf8pWW+iSe7v\n\tZZkacw8hs4DocrcMyNXXKXJsJqU62Eojj4dRqSA4RShXo6kJ3LmNu/X04Ci25MyNJToM\n\tlMHSr7+mjfTqSfJ2bNZtRit7rhmVYmeEdF2KQesjtAtQyXh3I8IyOZwOZr1/ECqFGK/M\n\tJuVnxG5oJlv/hlWil6jkTfcpOnSeePFmHmIAMDWyamWKOI1VVyUl5gamyloQtBA7/FZN\n\tLowg==", "X-Gm-Message-State": "APjAAAWKXKyogSjXwpFla2/oWbDOcT1vN9s/GRnej4chADh1OJjXNUiA\n\tpgNQYMUBMGn8gpxlui2Zjk8=", "X-Google-Smtp-Source": "APXvYqyoSDYPWu4RUOvnDARGMo8pOuQZ3RGQOV1HGXtNwNsBcsmUEeugZgXKGibzzlthU+3xSqElvw==", "X-Received": "by 2002:a0d:f0c7:: with SMTP id\n\tz190mr2409714ywe.317.1565554074798; \n\tSun, 11 Aug 2019 13:07:54 -0700 (PDT)", "From": "Wenwen Wang <wenwen@cs.uga.edu>", "To": "Wenwen Wang <wenwen@cs.uga.edu>", "Date": "Sun, 11 Aug 2019 15:07:47 -0500", "Message-Id": "<1565554067-4994-1-git-send-email-wenwen@cs.uga.edu>", "X-Mailer": "git-send-email 2.7.4", "X-Mailman-Approved-At": "Mon, 12 Aug 2019 14:52:11 +0000", "Subject": "[Intel-wired-lan] [PATCH] net: ixgbe: fix memory leaks", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "\"open list:NETWORKING DRIVERS\" <netdev@vger.kernel.org>,\n\t\"moderated list:INTEL ETHERNET DRIVERS\"\n\t<intel-wired-lan@lists.osuosl.org>, \n\topen list <linux-kernel@vger.kernel.org>,\n\t\"David S. Miller\" <davem@davemloft.net>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "In ixgbe_configure_clsu32(), 'jump', 'input', and 'mask' are allocated\nthrough kzalloc() respectively in a for loop body. Then,\nixgbe_clsu32_build_input() is invoked to build the input. If this process\nfails, next iteration of the for loop will be executed. However, the\nallocated 'jump', 'input', and 'mask' are not deallocated on this execution\npath, leading to memory leaks.\n\nSigned-off-by: Wenwen Wang <wenwen@cs.uga.edu>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex cbaf712..6b7ea87 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -9490,6 +9490,10 @@ static int ixgbe_configure_clsu32(struct ixgbe_adapter *adapter,\n \t\t\t\tjump->mat = nexthdr[i].jump;\n \t\t\t\tadapter->jump_tables[link_uhtid] = jump;\n \t\t\t\tbreak;\n+\t\t\t} else {\n+\t\t\t\tkfree(mask);\n+\t\t\t\tkfree(input);\n+\t\t\t\tkfree(jump);\n \t\t\t}\n \t\t}\n \t\treturn 0;\n", "prefixes": [] }