Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1144202/?format=api
{ "id": 1144202, "url": "http://patchwork.ozlabs.org/api/patches/1144202/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190808143938.4968-3-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190808143938.4968-3-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2019-08-08T14:39:26", "name": "[S27,03/15] ice: Always notify FW of VF reset", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "93d8a82d23fc70376674d45c67b267ff32e4ab8e", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190808143938.4968-3-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 124091, "url": "http://patchwork.ozlabs.org/api/series/124091/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=124091", "date": "2019-08-08T14:39:28", "name": "[S27,01/15] ice: Limit Max TCs on devices with more than 4 ports", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/124091/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1144202/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1144202/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 464PDp1nj1z9sND\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 9 Aug 2019 09:08:26 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 94DA6220B2;\n\tThu, 8 Aug 2019 23:08:24 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id t5hTQT1P6rOM; Thu, 8 Aug 2019 23:08:22 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5EA98204C7;\n\tThu, 8 Aug 2019 23:08:22 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 86E971BF383\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Aug 2019 23:08:18 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7C32D8831B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Aug 2019 23:08:18 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ctCzLs8J1v6Y for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Aug 2019 23:08:17 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 4A94788320\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Aug 2019 23:08:17 +0000 (UTC)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Aug 2019 16:08:16 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby orsmga008.jf.intel.com with ESMTP; 08 Aug 2019 16:08:16 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,363,1559545200\"; d=\"scan'208\";a=\"169141828\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 8 Aug 2019 07:39:26 -0700", "Message-Id": "<20190808143938.4968-3-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190808143938.4968-1-anthony.l.nguyen@intel.com>", "References": "<20190808143938.4968-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S27 03/15] ice: Always notify FW of VF\n\treset", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nThe call to ice_dis_vsi_txq() acts as the notification to the firmware\nthat the VF is being reset. Because of this, we need to make this call\nevery time we reset, regardless of whatever else we do to stop the tx\nqueues.\n\nWithout this change, VF resets would fail to complete on interfaces that\nwere up and running.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\n---\n .../net/ethernet/intel/ice/ice_virtchnl_pf.c | 25 ++++++++++++-------\n 1 file changed, 16 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\nindex b93324e9f4bc..c58e3e3212df 100644\n--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n@@ -1074,9 +1074,16 @@ bool ice_reset_all_vfs(struct ice_pf *pf, bool is_vflr)\n \tfor (v = 0; v < pf->num_alloc_vfs; v++)\n \t\tice_trigger_vf_reset(&pf->vf[v], is_vflr);\n \n-\tfor (v = 0; v < pf->num_alloc_vfs; v++)\n-\t\tif (test_bit(ICE_VF_STATE_QS_ENA, pf->vf[v].vf_states))\n-\t\t\tice_dis_vf_qs(&pf->vf[v]);\n+\tfor (v = 0; v < pf->num_alloc_vfs; v++) {\n+\t\tstruct ice_vsi *vsi;\n+\n+\t\tvf = &pf->vf[v];\n+\t\tvsi = pf->vsi[vf->lan_vsi_idx];\n+\t\tif (test_bit(ICE_VF_STATE_QS_ENA, vf->vf_states))\n+\t\t\tice_dis_vf_qs(vf);\n+\t\tice_dis_vsi_txq(vsi->port_info, vsi->idx, 0, 0, NULL, NULL,\n+\t\t\t\tNULL, ICE_VF_RESET, vf->vf_id, NULL);\n+\t}\n \n \t/* HW requires some time to make sure it can flush the FIFO for a VF\n \t * when it resets it. Poll the VPGEN_VFRSTAT register for each VF in\n@@ -1171,12 +1178,12 @@ static bool ice_reset_vf(struct ice_vf *vf, bool is_vflr)\n \n \tif (test_bit(ICE_VF_STATE_QS_ENA, vf->vf_states))\n \t\tice_dis_vf_qs(vf);\n-\telse\n-\t\t/* Call Disable LAN Tx queue AQ call even when queues are not\n-\t\t * enabled. This is needed for successful completion of VFR\n-\t\t */\n-\t\tice_dis_vsi_txq(vsi->port_info, vsi->idx, 0, 0, NULL, NULL,\n-\t\t\t\tNULL, ICE_VF_RESET, vf->vf_id, NULL);\n+\n+\t/* Call Disable LAN Tx queue AQ whether or not queues are\n+\t * enabled. This is needed for successful completion of VFR.\n+\t */\n+\tice_dis_vsi_txq(vsi->port_info, vsi->idx, 0, 0, NULL, NULL,\n+\t\t\tNULL, ICE_VF_RESET, vf->vf_id, NULL);\n \n \thw = &pf->hw;\n \t/* poll VPGEN_VFRSTAT reg to make sure\n", "prefixes": [ "S27", "03/15" ] }