Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1144199/?format=api
{ "id": 1144199, "url": "http://patchwork.ozlabs.org/api/patches/1144199/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190808143938.4968-15-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190808143938.4968-15-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2019-08-08T14:39:38", "name": "[S27,15/15] ice: change work limit to a constant", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "85de2f537823707798549b499819e8ec8f41d3e4", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190808143938.4968-15-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 124091, "url": "http://patchwork.ozlabs.org/api/series/124091/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=124091", "date": "2019-08-08T14:39:28", "name": "[S27,01/15] ice: Limit Max TCs on devices with more than 4 ports", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/124091/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1144199/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1144199/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 464PDn5lm0z9sNp\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 9 Aug 2019 09:08:25 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 56954867B9;\n\tThu, 8 Aug 2019 23:08:23 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DO7G3CspIdEc; Thu, 8 Aug 2019 23:08:22 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id C2171867BD;\n\tThu, 8 Aug 2019 23:08:22 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2A5BE1BF383\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Aug 2019 23:08:19 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 27C1A86781\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Aug 2019 23:08:19 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id fEXGxSyTh5Si for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Aug 2019 23:08:18 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 5868486745\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Aug 2019 23:08:18 +0000 (UTC)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Aug 2019 16:08:17 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby orsmga008.jf.intel.com with ESMTP; 08 Aug 2019 16:08:16 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,363,1559545200\"; d=\"scan'208\";a=\"169141840\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 8 Aug 2019 07:39:38 -0700", "Message-Id": "<20190808143938.4968-15-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190808143938.4968-1-anthony.l.nguyen@intel.com>", "References": "<20190808143938.4968-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S27 15/15] ice: change work limit to a\n\tconstant", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nThe driver has supported a transmit work limit\nthat was configurable from ethtool for a long time, but\nthere are no good use cases for having it be a variable\nthat can be changed at run time. In addition, this\nvariable was noted to be causing performance overhead\ndue to cache misses.\n\nJust remove the variable and let the code use a constant\nso that the functionality is maintained (a limit on the\nnumber of transmits that will be cleaned in any one call\nto the clean routines) without the cache miss.\n\nRemoves code, removes a variable, removes testing surface. Yay.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice.h | 3 ---\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 14 ++------------\n drivers/net/ethernet/intel/ice/ice_lib.c | 2 +-\n 3 files changed, 3 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h\nindex 681224c1de0e..f05e43693c95 100644\n--- a/drivers/net/ethernet/intel/ice/ice.h\n+++ b/drivers/net/ethernet/intel/ice/ice.h\n@@ -247,9 +247,6 @@ struct ice_vsi {\n \tu16 vsi_num;\t\t\t/* HW (absolute) index of this VSI */\n \tu16 idx;\t\t\t/* software index in pf->vsi[] */\n \n-\t/* Interrupt thresholds */\n-\tu16 work_lmt;\n-\n \ts16 vf_id;\t\t\t/* VF ID for SR-IOV VSIs */\n \n \tu16 ethtype;\t\t\t/* Ethernet protocol for pause frame */\ndiff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex dadcf4324f56..68dd5ec392ce 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -3361,12 +3361,6 @@ __ice_get_coalesce(struct net_device *netdev, struct ethtool_coalesce *ec,\n \tif (ice_get_q_coalesce(vsi, ec, q_num))\n \t\treturn -EINVAL;\n \n-\tif (q_num < vsi->num_txq)\n-\t\tec->tx_max_coalesced_frames_irq = vsi->work_lmt;\n-\n-\tif (q_num < vsi->num_rxq)\n-\t\tec->rx_max_coalesced_frames_irq = vsi->work_lmt;\n-\n \treturn 0;\n }\n \n@@ -3546,17 +3540,13 @@ __ice_set_coalesce(struct net_device *netdev, struct ethtool_coalesce *ec,\n \t\t\tif (ice_set_q_coalesce(vsi, ec, i))\n \t\t\t\treturn -EINVAL;\n \t\t}\n-\t\tgoto set_work_lmt;\n+\t\tgoto set_complete;\n \t}\n \n \tif (ice_set_q_coalesce(vsi, ec, q_num))\n \t\treturn -EINVAL;\n \n-set_work_lmt:\n-\n-\tif (ec->tx_max_coalesced_frames_irq || ec->rx_max_coalesced_frames_irq)\n-\t\tvsi->work_lmt = max(ec->tx_max_coalesced_frames_irq,\n-\t\t\t\t ec->rx_max_coalesced_frames_irq);\n+set_complete:\n \n \treturn 0;\n }\ndiff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c\nindex 46cca842eea9..541c480d27e4 100644\n--- a/drivers/net/ethernet/intel/ice/ice_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_lib.c\n@@ -574,8 +574,8 @@ ice_vsi_alloc(struct ice_pf *pf, enum ice_vsi_type type, u16 vf_id)\n \tvsi->type = type;\n \tvsi->back = pf;\n \tset_bit(__ICE_DOWN, vsi->state);\n+\n \tvsi->idx = pf->next_vsi;\n-\tvsi->work_lmt = ICE_DFLT_IRQ_WORK;\n \n \tif (type == ICE_VSI_VF)\n \t\tice_vsi_set_num_qs(vsi, vf_id);\n", "prefixes": [ "S27", "15/15" ] }