Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1144198/?format=api
{ "id": 1144198, "url": "http://patchwork.ozlabs.org/api/patches/1144198/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190808143938.4968-2-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190808143938.4968-2-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2019-08-08T14:39:25", "name": "[S27,02/15] ice: Correctly handle return values for init DCB", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "df6f88f10650d1deeaf53e8cf87fe22b54344188", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190808143938.4968-2-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 124091, "url": "http://patchwork.ozlabs.org/api/series/124091/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=124091", "date": "2019-08-08T14:39:28", "name": "[S27,01/15] ice: Limit Max TCs on devices with more than 4 ports", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/124091/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1144198/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1144198/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 464PDn1rybz9sNk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 9 Aug 2019 09:08:24 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7AC6D87672;\n\tThu, 8 Aug 2019 23:08:22 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jdiihxB7AH6s; Thu, 8 Aug 2019 23:08:21 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 75E2E875EE;\n\tThu, 8 Aug 2019 23:08:21 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1411E1BF383\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Aug 2019 23:08:18 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0F0AE88353\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Aug 2019 23:08:18 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PaimIAbkHn4k for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Aug 2019 23:08:17 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 6DEC088338\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 8 Aug 2019 23:08:17 +0000 (UTC)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Aug 2019 16:08:16 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby orsmga008.jf.intel.com with ESMTP; 08 Aug 2019 16:08:16 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,363,1559545200\"; d=\"scan'208\";a=\"169141827\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 8 Aug 2019 07:39:25 -0700", "Message-Id": "<20190808143938.4968-2-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190808143938.4968-1-anthony.l.nguyen@intel.com>", "References": "<20190808143938.4968-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S27 02/15] ice: Correctly handle return\n\tvalues for init DCB", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Dave Ertman <david.m.ertman@intel.com>\n\nIn the init path for DCB, the call to ice_init_dcb()\ncan return a non-zero value for either an actual\nerror, or due to the FW lldp engine being stopped.\n\nWe are currently treating all non-zero values only as\nan indication that the FW LLDP engine is stopped.\n\nCheck for an actual error in the DCB init flow.\n\nSigned-off-by: Dave Ertman <david.m.ertman@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 17 ++++++++---------\n 1 file changed, 8 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_dcb_lib.c b/drivers/net/ethernet/intel/ice/ice_dcb_lib.c\nindex e65b87f26828..eb1077450e5b 100644\n--- a/drivers/net/ethernet/intel/ice/ice_dcb_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_dcb_lib.c\n@@ -457,14 +457,18 @@ int ice_init_pf_dcb(struct ice_pf *pf, bool locked)\n \tport_info = hw->port_info;\n \n \terr = ice_init_dcb(hw);\n+\tif (err && !port_info->is_sw_lldp) {\n+\t\tdev_err(&pf->pdev->dev, \"Error initializing DCB %d\\n\", err);\n+\t\tgoto dcb_init_err;\n+\t}\n+\n+\tdev_info(&pf->pdev->dev,\n+\t\t \"DCB is enabled in the hardware, max number of TCs supported on this port are %d\\n\",\n+\t\t pf->hw.func_caps.common_cap.maxtc);\n \tif (err) {\n \t\t/* FW LLDP is disabled, activate SW DCBX/LLDP mode */\n-\t\tdev_info(&pf->pdev->dev,\n-\t\t\t \"DCB is enabled in the hardware, max number of TCs supported on this port are %d\\n\",\n-\t\t\t pf->hw.func_caps.common_cap.maxtc);\n \t\tdev_info(&pf->pdev->dev,\n \t\t\t \"FW LLDP is disabled, DCBx/LLDP in SW mode.\\n\");\n-\t\tport_info->is_sw_lldp = true;\n \t\tclear_bit(ICE_FLAG_FW_LLDP_AGENT, pf->flags);\n \t\terr = ice_dcb_sw_dflt_cfg(pf, locked);\n \t\tif (err) {\n@@ -480,7 +484,6 @@ int ice_init_pf_dcb(struct ice_pf *pf, bool locked)\n \t\treturn 0;\n \t}\n \n-\tport_info->is_sw_lldp = false;\n \tset_bit(ICE_FLAG_FW_LLDP_AGENT, pf->flags);\n \n \t/* DCBX in FW and LLDP enabled in FW */\n@@ -492,10 +495,6 @@ int ice_init_pf_dcb(struct ice_pf *pf, bool locked)\n \tif (err)\n \t\tgoto dcb_init_err;\n \n-\tdev_info(&pf->pdev->dev,\n-\t\t \"DCB is enabled in the hardware, max number of TCs supported on this port are %d\\n\",\n-\t\t pf->hw.func_caps.common_cap.maxtc);\n-\tdev_info(&pf->pdev->dev, \"DCBX offload supported\\n\");\n \treturn err;\n \n dcb_init_err:\n", "prefixes": [ "S27", "02/15" ] }