Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1142794/?format=api
{ "id": 1142794, "url": "http://patchwork.ozlabs.org/api/patches/1142794/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190806133826.18480-1-maurosr@linux.vnet.ibm.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190806133826.18480-1-maurosr@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2019-08-06T13:38:26", "name": "i40e: Remove EMPR traces from debugfs facility", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ecf24ab2e81b6f207f1bc9cadf3fc06bb803296a", "submitter": { "id": 71608, "url": "http://patchwork.ozlabs.org/api/people/71608/?format=api", "name": "Mauro S. M. Rodrigues", "email": "maurosr@linux.vnet.ibm.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190806133826.18480-1-maurosr@linux.vnet.ibm.com/mbox/", "series": [ { "id": 123572, "url": "http://patchwork.ozlabs.org/api/series/123572/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=123572", "date": "2019-08-06T13:38:26", "name": "i40e: Remove EMPR traces from debugfs facility", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/123572/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1142794/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1142794/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=linux.vnet.ibm.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 462wjC6ls9z9sDB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 6 Aug 2019 23:39:27 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DFF3C87E4C;\n\tTue, 6 Aug 2019 13:39:25 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4vv5IAnX3les; Tue, 6 Aug 2019 13:39:25 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5ECCD87E38;\n\tTue, 6 Aug 2019 13:39:25 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8C30F1BF28A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 6 Aug 2019 13:39:24 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 862372154B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 6 Aug 2019 13:39:24 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id xueNCK-zgnO8 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 6 Aug 2019 13:39:23 +0000 (UTC)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\tby silver.osuosl.org (Postfix) with ESMTPS id CB704214E9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 6 Aug 2019 13:39:23 +0000 (UTC)", "from pps.filterd (m0098399.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx76Dd8Es092349\n\tfor <intel-wired-lan@lists.osuosl.org>; Tue, 6 Aug 2019 09:39:23 -0400", "from e12.ny.us.ibm.com (e12.ny.us.ibm.com [129.33.205.202])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2u7888pbmb-1\n\t(version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT)\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 06 Aug 2019 09:39:18 -0400", "from localhost\n\tby e12.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <intel-wired-lan@lists.osuosl.org> from\n\t<maurosr@linux.vnet.ibm.com>; Tue, 6 Aug 2019 14:38:34 +0100", "from b01cxnp23032.gho.pok.ibm.com (9.57.198.27)\n\tby e12.ny.us.ibm.com (146.89.104.199) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\t(version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256)\n\tTue, 6 Aug 2019 14:38:33 +0100", "from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com\n\t[9.57.199.110])\n\tby b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid x76DcWpS21233956\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 6 Aug 2019 13:38:32 GMT", "from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 12926AE063;\n\tTue, 6 Aug 2019 13:38:32 +0000 (GMT)", "from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id D9243AE05C;\n\tTue, 6 Aug 2019 13:38:31 +0000 (GMT)", "from localhost (unknown [9.18.239.191])\n\tby b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP;\n\tTue, 6 Aug 2019 13:38:31 +0000 (GMT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "\"Mauro S. M. Rodrigues\" <maurosr@linux.vnet.ibm.com>", "To": "intel-wired-lan@lists.osuosl.org,\n\tJeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Tue, 6 Aug 2019 10:38:26 -0300", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "X-TM-AS-GCONF": "00", "x-cbid": "19080613-0060-0000-0000-000003698896", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00011559; HX=3.00000242; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000287; SDB=6.01242914; UDB=6.00655626;\n\tIPR=6.01024379; \n\tMB=3.00028065; MTD=3.00000008; XFM=3.00000015; UTC=2019-08-06 13:38:33", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "19080613-0061-0000-0000-00004A72EF1D", "Message-Id": "<20190806133826.18480-1-maurosr@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-08-06_08:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tpriorityscore=1501\n\tmalwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0\n\tclxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0\n\tmlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx\n\tscancount=1 engine=8.0.1-1906280000 definitions=main-1908060138", "Subject": "[Intel-wired-lan] [PATCH] i40e: Remove EMPR traces from debugfs\n\tfacility", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Since commit\n'5098850c9b9b (\"i40e/i40evf: i40e_register.h updates\")'\nit is no longer possible to trigger an EMP Reset from debugfs, but it's\npossible to request it either way, to end up with a bad reset request:\n\necho empr > /sys/kernel/debug/i40e/0002\\:01\\:00.1/command\ni40e 0002:01:00.1: debugfs: forcing EMPR\ni40e 0002:01:00.1: bad reset request 0x00010000\n\nSo let's remove this piece of code and show the available valid commands\nas it is when any invalid command is issued.\n\nSigned-off-by: Mauro S. M. Rodrigues <maurosr@linux.vnet.ibm.com>\n---\n drivers/net/ethernet/intel/i40e/i40e.h | 1 -\n drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 4 ----\n 2 files changed, 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h\nindex 84bd06901014..6ec0e1bc05e6 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e.h\n@@ -131,7 +131,6 @@ enum i40e_state_t {\n \t__I40E_PF_RESET_REQUESTED,\n \t__I40E_CORE_RESET_REQUESTED,\n \t__I40E_GLOBAL_RESET_REQUESTED,\n-\t__I40E_EMP_RESET_REQUESTED,\n \t__I40E_EMP_RESET_INTR_RECEIVED,\n \t__I40E_SUSPENDED,\n \t__I40E_PTP_TX_IN_PROGRESS,\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\nindex 55d20acfcf70..48fdf16c6019 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n@@ -1125,10 +1125,6 @@ static ssize_t i40e_dbg_command_write(struct file *filp,\n \t\tdev_info(&pf->pdev->dev, \"debugfs: forcing GlobR\\n\");\n \t\ti40e_do_reset_safe(pf, BIT(__I40E_GLOBAL_RESET_REQUESTED));\n \n-\t} else if (strncmp(cmd_buf, \"empr\", 4) == 0) {\n-\t\tdev_info(&pf->pdev->dev, \"debugfs: forcing EMPR\\n\");\n-\t\ti40e_do_reset_safe(pf, BIT(__I40E_EMP_RESET_REQUESTED));\n-\n \t} else if (strncmp(cmd_buf, \"read\", 4) == 0) {\n \t\tu32 address;\n \t\tu32 value;\n", "prefixes": [] }