Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1142793/?format=api
{ "id": 1142793, "url": "http://patchwork.ozlabs.org/api/patches/1142793/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190806133348.17924-2-maurosr@linux.vnet.ibm.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190806133348.17924-2-maurosr@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2019-08-06T13:33:48", "name": "[2/2] i40e: Implement debug macro hw_dbg using pr_debug", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "564ef3d0343bac4743ee8cad106185a14dfe9a5f", "submitter": { "id": 71608, "url": "http://patchwork.ozlabs.org/api/people/71608/?format=api", "name": "Mauro S. M. Rodrigues", "email": "maurosr@linux.vnet.ibm.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190806133348.17924-2-maurosr@linux.vnet.ibm.com/mbox/", "series": [ { "id": 123571, "url": "http://patchwork.ozlabs.org/api/series/123571/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=123571", "date": "2019-08-06T13:33:47", "name": "[1/2] i40e: fix hw_dbg usage in i40e_hmc_get_object_va", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/123571/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1142793/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1142793/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=linux.vnet.ibm.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 462wb966rrz9sBF\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 6 Aug 2019 23:34:13 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 2A1B82154B;\n\tTue, 6 Aug 2019 13:34:12 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id QbeMylO74gdu; Tue, 6 Aug 2019 13:34:08 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7363B21556;\n\tTue, 6 Aug 2019 13:34:08 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 492921BF28A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 6 Aug 2019 13:34:07 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 381AD87E4D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 6 Aug 2019 13:34:07 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id f7J03KVxyBx6 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 6 Aug 2019 13:34:06 +0000 (UTC)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 6155787E60\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 6 Aug 2019 13:34:06 +0000 (UTC)", "from pps.filterd (m0098399.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx76DW3Sv070631; Tue, 6 Aug 2019 09:34:05 -0400", "from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com\n\t[169.63.121.186])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2u7888p58x-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Tue, 06 Aug 2019 09:34:05 -0400", "from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1])\n\tby ppma03wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx76DTjkl001855; Tue, 6 Aug 2019 13:34:04 GMT", "from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com\n\t[9.57.198.23]) by ppma03wdc.us.ibm.com with ESMTP id 2u51w62mtk-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Tue, 06 Aug 2019 13:34:04 +0000", "from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com\n\t[9.57.199.110])\n\tby b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid x76DY3MV31588808\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 6 Aug 2019 13:34:03 GMT", "from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 85613AE05F;\n\tTue, 6 Aug 2019 13:34:03 +0000 (GMT)", "from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 588C2AE066;\n\tTue, 6 Aug 2019 13:34:03 +0000 (GMT)", "from localhost (unknown [9.18.239.191])\n\tby b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP;\n\tTue, 6 Aug 2019 13:34:03 +0000 (GMT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "\"Mauro S. M. Rodrigues\" <maurosr@linux.vnet.ibm.com>", "To": "intel-wired-lan@lists.osuosl.org,\n\tJeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Tue, 6 Aug 2019 10:33:48 -0300", "Message-Id": "<20190806133348.17924-2-maurosr@linux.vnet.ibm.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190806133348.17924-1-maurosr@linux.vnet.ibm.com>", "References": "<20190806133348.17924-1-maurosr@linux.vnet.ibm.com>", "MIME-Version": "1.0", "X-TM-AS-GCONF": "00", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-08-06_07:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tpriorityscore=1501\n\tmalwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0\n\tclxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0\n\tmlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx\n\tscancount=1 engine=8.0.1-1906280000 definitions=main-1908060137", "Subject": "[Intel-wired-lan] [PATCH 2/2] i40e: Implement debug macro hw_dbg\n\tusing pr_debug", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "There are several uses of hw_dbg in the code, producing no output. This\npatch implments it using pr_debug.\n\nInitially the intention was to implement it using netdev_dbg, analogously\nto what is done in ixgbe for instance. That approach was avoided due to\nsome early usages of hw_dbg, like i40e_pf_reset, before the vsi structure\ninitialization causing NULL pointer dereference during the driver probe if\nthe dbg messages were turned on as soon as the module is probed.\n\nSigned-off-by: Mauro S. M. Rodrigues <maurosr@linux.vnet.ibm.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_common.c | 1 +\n drivers/net/ethernet/intel/i40e/i40e_hmc.c | 1 +\n drivers/net/ethernet/intel/i40e/i40e_osdep.h | 7 ++++++-\n 3 files changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c\nindex 906cf68d3453..a51678166ff9 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c\n@@ -1,6 +1,7 @@\n // SPDX-License-Identifier: GPL-2.0\n /* Copyright(c) 2013 - 2018 Intel Corporation. */\n \n+#include \"i40e.h\"\n #include \"i40e_type.h\"\n #include \"i40e_adminq.h\"\n #include \"i40e_prototype.h\"\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_hmc.c b/drivers/net/ethernet/intel/i40e/i40e_hmc.c\nindex 19ce93d7fd0a..163ee8c6311c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_hmc.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_hmc.c\n@@ -1,6 +1,7 @@\n // SPDX-License-Identifier: GPL-2.0\n /* Copyright(c) 2013 - 2018 Intel Corporation. */\n \n+#include \"i40e.h\"\n #include \"i40e_osdep.h\"\n #include \"i40e_register.h\"\n #include \"i40e_status.h\"\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_osdep.h b/drivers/net/ethernet/intel/i40e/i40e_osdep.h\nindex a07574bff550..c0c9ce3eab23 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_osdep.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_osdep.h\n@@ -18,7 +18,12 @@\n * actual OS primitives\n */\n \n-#define hw_dbg(hw, S, A...)\tdo {} while (0)\n+#define hw_dbg(hw, S, A...)\t\t\t\t\t\t\t\\\n+do {\t\t\t\t\t\t\t\t\t\t\\\n+\tint domain = pci_domain_nr(((struct i40e_pf *)(hw)->back)->pdev->bus);\t\\\n+\tpr_debug(\"i40e %04x:%02x:%02x.%x \" S, domain, (hw)->bus.bus_id,\t\t\\\n+\t\t (hw)->bus.device, (hw)->bus.func, ## A);\t\t\t\\\n+} while (0)\n \n #define wr32(a, reg, value)\twritel((value), ((a)->hw_addr + (reg)))\n #define rd32(a, reg)\t\treadl((a)->hw_addr + (reg))\n", "prefixes": [ "2/2" ] }