Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1142792/?format=api
{ "id": 1142792, "url": "http://patchwork.ozlabs.org/api/patches/1142792/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190806133348.17924-1-maurosr@linux.vnet.ibm.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190806133348.17924-1-maurosr@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2019-08-06T13:33:47", "name": "[1/2] i40e: fix hw_dbg usage in i40e_hmc_get_object_va", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "fafc1503c18fc7227fd6374a3a59e96164baab98", "submitter": { "id": 71608, "url": "http://patchwork.ozlabs.org/api/people/71608/?format=api", "name": "Mauro S. M. Rodrigues", "email": "maurosr@linux.vnet.ibm.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190806133348.17924-1-maurosr@linux.vnet.ibm.com/mbox/", "series": [ { "id": 123571, "url": "http://patchwork.ozlabs.org/api/series/123571/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=123571", "date": "2019-08-06T13:33:47", "name": "[1/2] i40e: fix hw_dbg usage in i40e_hmc_get_object_va", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/123571/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1142792/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1142792/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=linux.vnet.ibm.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 462wb35m01z9sBF\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 6 Aug 2019 23:34:05 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id BA86F87816;\n\tTue, 6 Aug 2019 13:34:02 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id o6Nyj5mljXHg; Tue, 6 Aug 2019 13:34:01 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5DE7187994;\n\tTue, 6 Aug 2019 13:34:01 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 3E3EA1BF28A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 6 Aug 2019 13:33:59 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 387CA2154B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 6 Aug 2019 13:33:59 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HsUcQG4YJhC9 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 6 Aug 2019 13:33:58 +0000 (UTC)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\tby silver.osuosl.org (Postfix) with ESMTPS id A6BFD20345\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 6 Aug 2019 13:33:58 +0000 (UTC)", "from pps.filterd (m0098399.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx76DW2Hs070582; Tue, 6 Aug 2019 09:33:57 -0400", "from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com\n\t[169.53.41.122])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2u7888p51g-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Tue, 06 Aug 2019 09:33:57 -0400", "from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1])\n\tby ppma04dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx76DTOec018882; Tue, 6 Aug 2019 13:33:56 GMT", "from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com\n\t[9.57.198.28]) by ppma04dal.us.ibm.com with ESMTP id 2u51w6rmc4-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Tue, 06 Aug 2019 13:33:56 +0000", "from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com\n\t[9.57.199.109])\n\tby b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid x76DXt7w27197858\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 6 Aug 2019 13:33:55 GMT", "from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id D9FE1112066;\n\tTue, 6 Aug 2019 13:33:55 +0000 (GMT)", "from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id ACC11112062;\n\tTue, 6 Aug 2019 13:33:55 +0000 (GMT)", "from localhost (unknown [9.18.239.191])\n\tby b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP;\n\tTue, 6 Aug 2019 13:33:55 +0000 (GMT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "\"Mauro S. M. Rodrigues\" <maurosr@linux.vnet.ibm.com>", "To": "intel-wired-lan@lists.osuosl.org,\n\tJeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Tue, 6 Aug 2019 10:33:47 -0300", "Message-Id": "<20190806133348.17924-1-maurosr@linux.vnet.ibm.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "X-TM-AS-GCONF": "00", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-08-06_07:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tpriorityscore=1501\n\tmalwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0\n\tclxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0\n\tmlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx\n\tscancount=1 engine=8.0.1-1906280000 definitions=main-1908060137", "Subject": "[Intel-wired-lan] [PATCH 1/2] i40e: fix hw_dbg usage in\n\ti40e_hmc_get_object_va", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The mentioned function references a i40e_hw attribute, as parameter for\nhw_dbg, but it doesn't exist in the function scope.\nFixes it by changing parameters from i40e_hmc_info to i40e_hw which can\nretrieve the necessary i40e_hmc_info.\n\nSigned-off-by: Mauro S. M. Rodrigues <maurosr@linux.vnet.ibm.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c b/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c\nindex 994011c38fb4..f059de33a0fd 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c\n@@ -1,6 +1,7 @@\n // SPDX-License-Identifier: GPL-2.0\n /* Copyright(c) 2013 - 2018 Intel Corporation. */\n \n+#include \"i40e.h\"\n #include \"i40e_osdep.h\"\n #include \"i40e_register.h\"\n #include \"i40e_type.h\"\n@@ -963,7 +964,7 @@ static i40e_status i40e_set_hmc_context(u8 *context_bytes,\n \n /**\n * i40e_hmc_get_object_va - retrieves an object's virtual address\n- * @hmc_info: pointer to i40e_hmc_info struct\n+ * @hw: the hardware struct, from which we obtain the i40e_hmc_info pointer\n * @object_base: pointer to u64 to get the va\n * @rsrc_type: the hmc resource type\n * @obj_idx: hmc object index\n@@ -972,7 +973,7 @@ static i40e_status i40e_set_hmc_context(u8 *context_bytes,\n * base pointer. This function is used for LAN Queue contexts.\n **/\n static\n-i40e_status i40e_hmc_get_object_va(struct i40e_hmc_info *hmc_info,\n+i40e_status i40e_hmc_get_object_va(struct i40e_hw *hw,\n \t\t\t\t\tu8 **object_base,\n \t\t\t\t\tenum i40e_hmc_lan_rsrc_type rsrc_type,\n \t\t\t\t\tu32 obj_idx)\n@@ -982,6 +983,7 @@ i40e_status i40e_hmc_get_object_va(struct i40e_hmc_info *hmc_info,\n \tstruct i40e_hmc_sd_entry *sd_entry;\n \tstruct i40e_hmc_pd_entry *pd_entry;\n \tu32 pd_idx, pd_lmt, rel_pd_idx;\n+\tstruct i40e_hmc_info *hmc_info = &hw->hmc;\n \tu64 obj_offset_in_fpm;\n \tu32 sd_idx, sd_lmt;\n \n@@ -1047,7 +1049,7 @@ i40e_status i40e_clear_lan_tx_queue_context(struct i40e_hw *hw,\n \ti40e_status err;\n \tu8 *context_bytes;\n \n-\terr = i40e_hmc_get_object_va(&hw->hmc, &context_bytes,\n+\terr = i40e_hmc_get_object_va(hw, &context_bytes,\n \t\t\t\t I40E_HMC_LAN_TX, queue);\n \tif (err < 0)\n \t\treturn err;\n@@ -1068,7 +1070,7 @@ i40e_status i40e_set_lan_tx_queue_context(struct i40e_hw *hw,\n \ti40e_status err;\n \tu8 *context_bytes;\n \n-\terr = i40e_hmc_get_object_va(&hw->hmc, &context_bytes,\n+\terr = i40e_hmc_get_object_va(hw, &context_bytes,\n \t\t\t\t I40E_HMC_LAN_TX, queue);\n \tif (err < 0)\n \t\treturn err;\n@@ -1088,7 +1090,7 @@ i40e_status i40e_clear_lan_rx_queue_context(struct i40e_hw *hw,\n \ti40e_status err;\n \tu8 *context_bytes;\n \n-\terr = i40e_hmc_get_object_va(&hw->hmc, &context_bytes,\n+\terr = i40e_hmc_get_object_va(hw, &context_bytes,\n \t\t\t\t I40E_HMC_LAN_RX, queue);\n \tif (err < 0)\n \t\treturn err;\n@@ -1109,7 +1111,7 @@ i40e_status i40e_set_lan_rx_queue_context(struct i40e_hw *hw,\n \ti40e_status err;\n \tu8 *context_bytes;\n \n-\terr = i40e_hmc_get_object_va(&hw->hmc, &context_bytes,\n+\terr = i40e_hmc_get_object_va(hw, &context_bytes,\n \t\t\t\t I40E_HMC_LAN_RX, queue);\n \tif (err < 0)\n \t\treturn err;\n", "prefixes": [ "1/2" ] }