Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1138556/?format=api
{ "id": 1138556, "url": "http://patchwork.ozlabs.org/api/patches/1138556/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190729090454.5501-7-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190729090454.5501-7-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2019-07-29T09:04:49", "name": "[S24,v2,07/12] ice: reject VF attempts to enable head writeback", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "08e07098b903fff37e5e235928b0b778a5348092", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190729090454.5501-7-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 122035, "url": "http://patchwork.ozlabs.org/api/series/122035/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=122035", "date": "2019-07-29T09:04:53", "name": "[S24,v2,01/12] ice: Allow egress control packets from PF_VSI", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/122035/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1138556/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1138556/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45y6Gv59khz9sNF\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 30 Jul 2019 03:33:26 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 817622044F;\n\tMon, 29 Jul 2019 17:33:24 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ML3WS0y+7i0Y; Mon, 29 Jul 2019 17:33:22 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id D4F4420034;\n\tMon, 29 Jul 2019 17:33:22 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 87A081BF97F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 29 Jul 2019 17:33:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 80435875B6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 29 Jul 2019 17:33:20 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id B6TkdaqJdTmB for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 29 Jul 2019 17:33:19 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 298FB875AD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 29 Jul 2019 17:33:19 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Jul 2019 10:33:17 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby FMSMGA003.fm.intel.com with ESMTP; 29 Jul 2019 10:33:17 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,323,1559545200\"; d=\"scan'208\";a=\"179447241\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 29 Jul 2019 02:04:49 -0700", "Message-Id": "<20190729090454.5501-7-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190729090454.5501-1-anthony.l.nguyen@intel.com>", "References": "<20190729090454.5501-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S24 v2 07/12] ice: reject VF attempts to\n\tenable head writeback", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nThe virtchnl interface provides a mechanism for a VF driver to request\nhead writeback support. This feature is deprecated as of AVF 1.0, but\nolder versions of a VF driver may still attempt to request the mode.\n\nSince the ice hardware does not support head writeback, we should not\naccept Tx queue configuration which attempts to enable it.\n\nCurrently, the driver simply assumes that the headwb_enabled bit will\nnever be set.\n\nIf a VF driver does request head writeback, the configuration will\nreturn successfully, even though head writeback is not enabled. This\nleaves the VF driver in a non functional state since it is assuming to\nbe operating in head writeback mode.\n\nFix the PF driver to reject any attempt to setup headwb_enabled.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\nindex 1b1d1ea0c8f9..73ab6222d29b 100644\n--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n@@ -2109,6 +2109,7 @@ static int ice_vc_cfg_qs_msg(struct ice_vf *vf, u8 *msg)\n \t\tif (qpi->txq.vsi_id != qci->vsi_id ||\n \t\t qpi->rxq.vsi_id != qci->vsi_id ||\n \t\t qpi->rxq.queue_id != qpi->txq.queue_id ||\n+\t\t qpi->txq.headwb_enabled ||\n \t\t !ice_vc_isvalid_q_id(vf, qci->vsi_id, qpi->txq.queue_id)) {\n \t\t\tv_ret = VIRTCHNL_STATUS_ERR_PARAM;\n \t\t\tgoto error_param;\n", "prefixes": [ "S24", "v2", "07/12" ] }