Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1137059/?format=api
{ "id": 1137059, "url": "http://patchwork.ozlabs.org/api/patches/1137059/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190725095401.24590-3-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190725095401.24590-3-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2019-07-25T09:53:52", "name": "[S25,03/12] ice: Don't allow VSI to remove unassociated ucast filter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d94e131a0f8b89178c4f35709691e1ca0f3d4d6e", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190725095401.24590-3-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 121514, "url": "http://patchwork.ozlabs.org/api/series/121514/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=121514", "date": "2019-07-25T09:53:50", "name": "[S25,01/12] ice: update ethtool stats on-demand", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/121514/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1137059/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1137059/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45vgYL00Tcz9sMr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 26 Jul 2019 04:22:29 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 64F2622661;\n\tThu, 25 Jul 2019 18:22:28 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id pZ0hbQw1R5JC; Thu, 25 Jul 2019 18:22:21 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id E0D5B22668;\n\tThu, 25 Jul 2019 18:22:20 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id F25A71BF2C8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 25 Jul 2019 18:22:18 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id EFCF3865AB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 25 Jul 2019 18:22:18 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id x4ZhQDZw6UGD for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 25 Jul 2019 18:22:18 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 39F8986582\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 25 Jul 2019 18:22:18 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jul 2019 11:22:17 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby fmsmga004.fm.intel.com with ESMTP; 25 Jul 2019 11:22:17 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,307,1559545200\"; d=\"scan'208\";a=\"193897599\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 25 Jul 2019 02:53:52 -0700", "Message-Id": "<20190725095401.24590-3-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190725095401.24590-1-anthony.l.nguyen@intel.com>", "References": "<20190725095401.24590-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S25 03/12] ice: Don't allow VSI to remove\n\tunassociated ucast filter", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>\n\nIf a VSI is not using a unicast filter or did not configure that\nparticular unicast filter, driver should not allow it to be removed\nby the rogue VSI.\n\nSigned-off-by: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_switch.c | 56 +++++++++++++++++++++\n 1 file changed, 56 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c\nindex 6b68ff8dae18..2e6ea062fa2a 100644\n--- a/drivers/net/ethernet/intel/ice/ice_switch.c\n+++ b/drivers/net/ethernet/intel/ice/ice_switch.c\n@@ -2136,6 +2136,38 @@ ice_cfg_dflt_vsi(struct ice_hw *hw, u16 vsi_handle, bool set, u8 direction)\n \treturn status;\n }\n \n+/**\n+ * ice_find_ucast_rule_entry - Search for a unicast MAC filter rule entry\n+ * @hw: pointer to the hardware structure\n+ * @recp_id: lookup type for which the specified rule needs to be searched\n+ * @f_info: rule information\n+ *\n+ * Helper function to search for a unicast rule entry - this is to be used\n+ * to remove unicast MAC filter that is not shared with other VSIs on the\n+ * PF switch.\n+ *\n+ * Returns pointer to entry storing the rule if found\n+ */\n+static struct ice_fltr_mgmt_list_entry *\n+ice_find_ucast_rule_entry(struct ice_hw *hw, u8 recp_id,\n+\t\t\t struct ice_fltr_info *f_info)\n+{\n+\tstruct ice_switch_info *sw = hw->switch_info;\n+\tstruct ice_fltr_mgmt_list_entry *list_itr;\n+\tstruct list_head *list_head;\n+\n+\tlist_head = &sw->recp_list[recp_id].filt_rules;\n+\tlist_for_each_entry(list_itr, list_head, list_entry) {\n+\t\tif (!memcmp(&f_info->l_data, &list_itr->fltr_info.l_data,\n+\t\t\t sizeof(f_info->l_data)) &&\n+\t\t f_info->fwd_id.hw_vsi_id ==\n+\t\t list_itr->fltr_info.fwd_id.hw_vsi_id &&\n+\t\t f_info->flag == list_itr->fltr_info.flag)\n+\t\t\treturn list_itr;\n+\t}\n+\treturn NULL;\n+}\n+\n /**\n * ice_remove_mac - remove a MAC address based filter rule\n * @hw: pointer to the hardware structure\n@@ -2153,15 +2185,39 @@ enum ice_status\n ice_remove_mac(struct ice_hw *hw, struct list_head *m_list)\n {\n \tstruct ice_fltr_list_entry *list_itr, *tmp;\n+\tstruct mutex *rule_lock; /* Lock to protect filter rule list */\n \n \tif (!m_list)\n \t\treturn ICE_ERR_PARAM;\n \n+\trule_lock = &hw->switch_info->recp_list[ICE_SW_LKUP_MAC].filt_rule_lock;\n \tlist_for_each_entry_safe(list_itr, tmp, m_list, list_entry) {\n \t\tenum ice_sw_lkup_type l_type = list_itr->fltr_info.lkup_type;\n+\t\tu8 *add = &list_itr->fltr_info.l_data.mac.mac_addr[0];\n+\t\tu16 vsi_handle;\n \n \t\tif (l_type != ICE_SW_LKUP_MAC)\n \t\t\treturn ICE_ERR_PARAM;\n+\n+\t\tvsi_handle = list_itr->fltr_info.vsi_handle;\n+\t\tif (!ice_is_vsi_valid(hw, vsi_handle))\n+\t\t\treturn ICE_ERR_PARAM;\n+\n+\t\tlist_itr->fltr_info.fwd_id.hw_vsi_id =\n+\t\t\t\t\tice_get_hw_vsi_num(hw, vsi_handle);\n+\t\tif (is_unicast_ether_addr(add) && !hw->ucast_shared) {\n+\t\t\t/* Don't remove the unicast address that belongs to\n+\t\t\t * another VSI on the switch, since it is not being\n+\t\t\t * shared...\n+\t\t\t */\n+\t\t\tmutex_lock(rule_lock);\n+\t\t\tif (!ice_find_ucast_rule_entry(hw, ICE_SW_LKUP_MAC,\n+\t\t\t\t\t\t &list_itr->fltr_info)) {\n+\t\t\t\tmutex_unlock(rule_lock);\n+\t\t\t\treturn ICE_ERR_DOES_NOT_EXIST;\n+\t\t\t}\n+\t\t\tmutex_unlock(rule_lock);\n+\t\t}\n \t\tlist_itr->status = ice_remove_rule_internal(hw,\n \t\t\t\t\t\t\t ICE_SW_LKUP_MAC,\n \t\t\t\t\t\t\t list_itr);\n", "prefixes": [ "S25", "03/12" ] }