Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1137050/?format=api
{ "id": 1137050, "url": "http://patchwork.ozlabs.org/api/patches/1137050/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190725094743.20861-1-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190725094743.20861-1-alice.michael@intel.com>", "list_archive_url": null, "date": "2019-07-25T09:47:43", "name": "[next] iavf: allow permanent MAC address to change", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b724d7b0531553ff5974b8591fe5b97dd1aefc0c", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190725094743.20861-1-alice.michael@intel.com/mbox/", "series": [ { "id": 121512, "url": "http://patchwork.ozlabs.org/api/series/121512/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=121512", "date": "2019-07-25T09:47:43", "name": "[next] iavf: allow permanent MAC address to change", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/121512/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1137050/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1137050/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45vgFS2Wcxz9s8m\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 26 Jul 2019 04:08:42 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3529F88192;\n\tThu, 25 Jul 2019 18:08:40 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id NUuBp5JT3-dW; Thu, 25 Jul 2019 18:08:38 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 06C7188193;\n\tThu, 25 Jul 2019 18:08:37 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 680911BF2C8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 25 Jul 2019 18:08:37 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5E190873B8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 25 Jul 2019 18:08:37 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Hwbf5YEvVY+l for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 25 Jul 2019 18:08:36 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 8608E84854\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 25 Jul 2019 18:08:36 +0000 (UTC)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jul 2019 11:08:35 -0700", "from alicemic-1.jf.intel.com ([10.166.17.62])\n\tby fmsmga005.fm.intel.com with ESMTP; 25 Jul 2019 11:08:35 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,307,1559545200\"; d=\"scan'208\";a=\"369217378\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Thu, 25 Jul 2019 05:47:43 -0400", "Message-Id": "<20190725094743.20861-1-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH] iavf: allow permanent MAC address to\n\tchange", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Allow the VF to override the \"permanent\" MAC address set by the host.\nThis allows bonding to work in the case where the administrator has set\nthe VF MAC.\n\nNote that the VF must still be set to Trusted on the host if this change\nis to be accepted by the PF driver.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\n---\n drivers/net/ethernet/intel/iavf/iavf.h | 1 -\n drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ----\n 2 files changed, 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/iavf/iavf.h b/drivers/net/ethernet/intel/iavf/iavf.h\nindex 9fc635d816d2..29de3ae96ef2 100644\n--- a/drivers/net/ethernet/intel/iavf/iavf.h\n+++ b/drivers/net/ethernet/intel/iavf/iavf.h\n@@ -253,7 +253,6 @@ struct iavf_adapter {\n #define IAVF_FLAG_RESET_PENDING\t\tBIT(4)\n #define IAVF_FLAG_RESET_NEEDED\t\tBIT(5)\n #define IAVF_FLAG_WB_ON_ITR_CAPABLE\t\tBIT(6)\n-#define IAVF_FLAG_ADDR_SET_BY_PF\t\tBIT(8)\n #define IAVF_FLAG_SERVICE_CLIENT_REQUESTED\tBIT(9)\n #define IAVF_FLAG_CLIENT_NEEDS_OPEN\t\tBIT(10)\n #define IAVF_FLAG_CLIENT_NEEDS_CLOSE\t\tBIT(11)\ndiff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c\nindex 554aa619ff02..07f5541a0f01 100644\n--- a/drivers/net/ethernet/intel/iavf/iavf_main.c\n+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c\n@@ -790,9 +790,6 @@ static int iavf_set_mac(struct net_device *netdev, void *p)\n \tif (ether_addr_equal(netdev->dev_addr, addr->sa_data))\n \t\treturn 0;\n \n-\tif (adapter->flags & IAVF_FLAG_ADDR_SET_BY_PF)\n-\t\treturn -EPERM;\n-\n \tspin_lock_bh(&adapter->mac_vlan_list_lock);\n \n \tf = iavf_find_filter(adapter, hw->mac.addr);\n@@ -1811,7 +1808,6 @@ static int iavf_init_get_resources(struct iavf_adapter *adapter)\n \t\teth_hw_addr_random(netdev);\n \t\tether_addr_copy(adapter->hw.mac.addr, netdev->dev_addr);\n \t} else {\n-\t\tadapter->flags |= IAVF_FLAG_ADDR_SET_BY_PF;\n \t\tether_addr_copy(netdev->dev_addr, adapter->hw.mac.addr);\n \t\tether_addr_copy(netdev->perm_addr, adapter->hw.mac.addr);\n \t}\n", "prefixes": [ "next" ] }