Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1137040/?format=api
{ "id": 1137040, "url": "http://patchwork.ozlabs.org/api/patches/1137040/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190725085541.55104-12-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190725085541.55104-12-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2019-07-25T08:55:38", "name": "[S23,v4,12/15] ice: Increase size of Mailbox receive queue for many VFs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "77520c8b3829478f18f36649b0d70dc2de0f1d69", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190725085541.55104-12-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 121506, "url": "http://patchwork.ozlabs.org/api/series/121506/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=121506", "date": "2019-07-25T08:55:36", "name": "[S23,v4,01/15] ice: Implement ethtool ops for channels", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/121506/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1137040/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1137040/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45vfGC3FTWz9sNm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 26 Jul 2019 03:24:19 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id DA26622640;\n\tThu, 25 Jul 2019 17:24:17 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5W41AIrPzEf0; Thu, 25 Jul 2019 17:24:12 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 01D1D22686;\n\tThu, 25 Jul 2019 17:24:07 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id BE13A1BF988\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 25 Jul 2019 17:24:02 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 93B6D2044E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 25 Jul 2019 17:24:02 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Oo1-hBtD0J0w for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 25 Jul 2019 17:23:57 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 8818A207A4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 25 Jul 2019 17:23:57 +0000 (UTC)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jul 2019 10:23:56 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby orsmga007.jf.intel.com with ESMTP; 25 Jul 2019 10:23:56 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,307,1559545200\"; d=\"scan'208\";a=\"160973713\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 25 Jul 2019 01:55:38 -0700", "Message-Id": "<20190725085541.55104-12-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190725085541.55104-1-anthony.l.nguyen@intel.com>", "References": "<20190725085541.55104-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S23 v4 12/15] ice: Increase size of\n\tMailbox receive queue for many VFs", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Brett Creeley <brett.creeley@intel.com>\n\nCurrently we use the ICE_MBXQ_LEN for both the Mailbox send and receive\nqueues that are used to communicate with VFs. This is fine for the send\nqueue because the PF driver will lock the queue for every single send,\nbut for the Mailbox receive queue every VF is posting to its Mailbox\nsend queue and the hardware is then handing the message to the PF on its\nMailbox receive queue. This becomes a problem with many VFs because it\nseems to overburden the Mailbox receive queue on the PF. Fix this by\nincreasing the Mailbox receive queue for the PF to 512 entries.\n\nThe number 512 was determined based on the number of VFs supported by\nthe device. We can have a total of 256 VFs so in the worst case this\nallows the VFs to put 2 messages in the PFs Mailbox receive queue at the\nsame time.\n\nSigned-off-by: Brett Creeley <brett.creeley@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice.h | 3 ++-\n drivers/net/ethernet/intel/ice/ice_main.c | 4 ++--\n 2 files changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h\nindex 112bdb662ea2..36a8ee873ae1 100644\n--- a/drivers/net/ethernet/intel/ice/ice.h\n+++ b/drivers/net/ethernet/intel/ice/ice.h\n@@ -69,7 +69,8 @@ extern const char ice_drv_ver[];\n #define ICE_INT_NAME_STR_LEN\t(IFNAMSIZ + 16)\n #define ICE_ETHTOOL_FWVER_LEN\t32\n #define ICE_AQ_LEN\t\t64\n-#define ICE_MBXQ_LEN\t\t64\n+#define ICE_MBXSQ_LEN\t\t64\n+#define ICE_MBXRQ_LEN\t\t512\n #define ICE_MIN_MSIX\t\t2\n #define ICE_NO_VSI\t\t0xffff\n #define ICE_MAX_TXQS\t\t2048\ndiff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex be872336e08e..833f0efc93f9 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -1507,8 +1507,8 @@ static void ice_set_ctrlq_len(struct ice_hw *hw)\n \thw->adminq.num_sq_entries = ICE_AQ_LEN;\n \thw->adminq.rq_buf_size = ICE_AQ_MAX_BUF_LEN;\n \thw->adminq.sq_buf_size = ICE_AQ_MAX_BUF_LEN;\n-\thw->mailboxq.num_rq_entries = ICE_MBXQ_LEN;\n-\thw->mailboxq.num_sq_entries = ICE_MBXQ_LEN;\n+\thw->mailboxq.num_rq_entries = ICE_MBXRQ_LEN;\n+\thw->mailboxq.num_sq_entries = ICE_MBXSQ_LEN;\n \thw->mailboxq.rq_buf_size = ICE_MBXQ_MAX_BUF_LEN;\n \thw->mailboxq.sq_buf_size = ICE_MBXQ_MAX_BUF_LEN;\n }\n", "prefixes": [ "S23", "v4", "12/15" ] }