Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1136412/?format=api
{ "id": 1136412, "url": "http://patchwork.ozlabs.org/api/patches/1136412/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190724165008.12142-1-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190724165008.12142-1-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2019-07-24T16:50:08", "name": "[-next,v2] ixgbevf: fix a compilation error of skb_frag_t", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e08cad3e42c67e554ae9ea851dd5a342640bf8c1", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190724165008.12142-1-jeffrey.t.kirsher@intel.com/mbox/", "series": [ { "id": 121270, "url": "http://patchwork.ozlabs.org/api/series/121270/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=121270", "date": "2019-07-24T16:50:08", "name": "[-next,v2] ixgbevf: fix a compilation error of skb_frag_t", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/121270/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1136412/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1136412/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45v1Zg0Yw0z9s8m\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 25 Jul 2019 02:51:22 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id A2E9E85E83;\n\tWed, 24 Jul 2019 16:51:20 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1dVpY89oJoy0; Wed, 24 Jul 2019 16:51:16 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1EC3A85F32;\n\tWed, 24 Jul 2019 16:51:15 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id A50EB1BF3C1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 24 Jul 2019 16:50:41 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A0792860CE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 24 Jul 2019 16:50:41 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id gOLKJKlgw-eL for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 24 Jul 2019 16:50:40 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 3BF2D85465\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 24 Jul 2019 16:50:40 +0000 (UTC)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t24 Jul 2019 09:50:39 -0700", "from jtkirshe-desk1.jf.intel.com ([134.134.177.96])\n\tby fmsmga008.fm.intel.com with ESMTP; 24 Jul 2019 09:50:39 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,303,1559545200\"; d=\"scan'208\";a=\"169977830\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 24 Jul 2019 09:50:08 -0700", "Message-Id": "<20190724165008.12142-1-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH -next v2] ixgbevf: fix a compilation error\n\tof skb_frag_t", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Qian Cai <cai@lca.pw>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Qian Cai <cai@lca.pw>\n\nThe linux-next commit \"net: Rename skb_frag_t size to bv_len\" [1]\nintroduced a compilation error on powerpc as it forgot to deal with the\nrenaming from \"size\" to \"bv_len\" for ixgbevf.\n\n[1] https://lore.kernel.org/netdev/20190723030831.11879-1-willy@infradead.org/T/#md052f1c7de965ccd1bdcb6f92e1990a52298eac5\n\nIn file included from ./include/linux/cache.h:5,\n from ./include/linux/printk.h:9,\n from ./include/linux/kernel.h:15,\n from ./include/linux/list.h:9,\n from ./include/linux/module.h:9,\n from\ndrivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:12:\ndrivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c: In function\n'ixgbevf_xmit_frame_ring':\ndrivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:4138:51: error:\n'skb_frag_t' {aka 'struct bio_vec'} has no member named 'size'\n count += TXD_USE_COUNT(skb_shinfo(skb)->frags[f].size);\n ^\n./include/uapi/linux/kernel.h:13:40: note: in definition of macro\n'__KERNEL_DIV_ROUND_UP'\n #define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))\n ^\ndrivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:4138:12: note: in\nexpansion of macro 'TXD_USE_COUNT'\n count += TXD_USE_COUNT(skb_shinfo(skb)->frags[f].size);\n\nSigned-off-by: Qian Cai <cai@lca.pw>\n---\n\nv2: Use the fine accessor per Matthew.\n\nSent to intel-wired-lan@lists.osuosl.org, since it was left off in the original\nsubmission.\n\n drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\nindex bdfccaf38edd..8c011d4ce7a9 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n@@ -4134,8 +4134,11 @@ static int ixgbevf_xmit_frame_ring(struct sk_buff *skb,\n \t * otherwise try next time\n \t */\n #if PAGE_SIZE > IXGBE_MAX_DATA_PER_TXD\n-\tfor (f = 0; f < skb_shinfo(skb)->nr_frags; f++)\n-\t\tcount += TXD_USE_COUNT(skb_shinfo(skb)->frags[f].size);\n+\tfor (f = 0; f < skb_shinfo(skb)->nr_frags; f++) {\n+\t\tskb_frag_t *frag = &skb_shinfo(skb)->frags[f];\n+\n+\t\tcount += TXD_USE_COUNT(skb_frag_size(frag));\n+\t}\n #else\n \tcount += skb_shinfo(skb)->nr_frags;\n #endif\n", "prefixes": [ "-next", "v2" ] }