Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1135863/?format=api
{ "id": 1135863, "url": "http://patchwork.ozlabs.org/api/patches/1135863/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190723100144.57435-10-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190723100144.57435-10-alice.michael@intel.com>", "list_archive_url": null, "date": "2019-07-23T10:01:42", "name": "[next,S8,10/12] i40e: allow reset in recovery mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6a0f22ffbff391ab1fe459e7118994c315904917", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190723100144.57435-10-alice.michael@intel.com/mbox/", "series": [ { "id": 121043, "url": "http://patchwork.ozlabs.org/api/series/121043/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=121043", "date": "2019-07-23T10:01:38", "name": "[next,S8,01/12] i40e: fix shifts of signed values", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/121043/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1135863/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1135863/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45tRff0QMgz9s00\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 24 Jul 2019 04:22:50 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 5C2A385AE9;\n\tTue, 23 Jul 2019 18:22:48 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DmmL9Ci6GYMZ; Tue, 23 Jul 2019 18:22:47 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1140B85B2F;\n\tTue, 23 Jul 2019 18:22:47 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 503AF1BF97A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jul 2019 18:22:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3F21C8475A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jul 2019 18:22:43 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id O+Ip7cMgTwKn for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jul 2019 18:22:40 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id DC3C48472A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jul 2019 18:22:39 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Jul 2019 11:22:37 -0700", "from alicemic-1.jf.intel.com ([10.166.17.62])\n\tby orsmga003.jf.intel.com with ESMTP; 23 Jul 2019 11:22:35 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,299,1559545200\"; d=\"scan'208\";a=\"172037678\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Tue, 23 Jul 2019 06:01:42 -0400", "Message-Id": "<20190723100144.57435-10-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190723100144.57435-1-alice.michael@intel.com>", "References": "<20190723100144.57435-1-alice.michael@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S8 10/12] i40e: allow reset in\n\trecovery mode", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Piotr Kwapulinski <piotr.kwapulinski@intel.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Piotr Kwapulinski <piotr.kwapulinski@intel.com>\n\nDriver waits after issuing a reset. When a reset takes too long a driver\ngives up. Implemented by invoking PF reset in a loop. After defined\nnumber of unsuccessful PF reset trials it returns error.\nWithout this patch PF reset fails when NIC is in recovery mode.\n\nSigned-off-by: Piotr Kwapulinski <piotr.kwapulinski@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 67 ++++++++++++++++++---\n 1 file changed, 60 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 8d6b9515b595..fdf43d87e983 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -14564,6 +14564,51 @@ static bool i40e_check_recovery_mode(struct i40e_pf *pf)\n \treturn false;\n }\n \n+/**\n+ * i40e_pf_loop_reset - perform reset in a loop.\n+ * @pf: board private structure\n+ *\n+ * This function is useful when a NIC is about to enter recovery mode.\n+ * When a NIC's internal data structures are corrupted the NIC's\n+ * firmware is going to enter recovery mode.\n+ * Right after a POR it takes about 7 minutes for firmware to enter\n+ * recovery mode. Until that time a NIC is in some kind of intermediate\n+ * state. After that time period the NIC almost surely enters\n+ * recovery mode. The only way for a driver to detect intermediate\n+ * state is to issue a series of pf-resets and check a return value.\n+ * If a PF reset returns success then the firmware could be in recovery\n+ * mode so the caller of this code needs to check for recovery mode\n+ * if this function returns success. There is a little chance that\n+ * firmware will hang in intermediate state forever.\n+ * Since waiting 7 minutes is quite a lot of time this function waits\n+ * 10 seconds and then gives up by returning an error.\n+ *\n+ * Return 0 on success, negative on failure.\n+ **/\n+static i40e_status i40e_pf_loop_reset(struct i40e_pf *pf)\n+{\n+\tconst unsigned short MAX_CNT = 1000;\n+\tconst unsigned short MSECS = 10;\n+\tstruct i40e_hw *hw = &pf->hw;\n+\ti40e_status ret;\n+\tint cnt;\n+\n+\tfor (cnt = 0; cnt < MAX_CNT; ++cnt) {\n+\t\tret = i40e_pf_reset(hw);\n+\t\tif (!ret)\n+\t\t\tbreak;\n+\t\tmsleep(MSECS);\n+\t}\n+\n+\tif (cnt == MAX_CNT) {\n+\t\tdev_info(&pf->pdev->dev, \"PF reset failed: %d\\n\", ret);\n+\t\treturn ret;\n+\t}\n+\n+\tpf->pfr_count++;\n+\treturn ret;\n+}\n+\n /**\n * i40e_init_recovery_mode - initialize subsystems needed in recovery mode\n * @pf: board private structure\n@@ -14792,14 +14837,22 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \n \t/* Reset here to make sure all is clean and to define PF 'n' */\n \ti40e_clear_hw(hw);\n-\tif (!i40e_check_recovery_mode(pf)) {\n-\t\terr = i40e_pf_reset(hw);\n-\t\tif (err) {\n-\t\t\tdev_info(&pdev->dev, \"Initial pf_reset failed: %d\\n\", err);\n-\t\t\tgoto err_pf_reset;\n-\t\t}\n-\t\tpf->pfr_count++;\n+\n+\terr = i40e_set_mac_type(hw);\n+\tif (err) {\n+\t\tdev_warn(&pdev->dev, \"unidentified MAC or BLANK NVM: %d\\n\",\n+\t\t\t err);\n+\t\tgoto err_pf_reset;\n \t}\n+\n+\terr = i40e_pf_loop_reset(pf);\n+\tif (err) {\n+\t\tdev_info(&pdev->dev, \"Initial pf_reset failed: %d\\n\", err);\n+\t\tgoto err_pf_reset;\n+\t}\n+\n+\ti40e_check_recovery_mode(pf);\n+\n \thw->aq.num_arq_entries = I40E_AQ_LEN;\n \thw->aq.num_asq_entries = I40E_AQ_LEN;\n \thw->aq.arq_buf_size = I40E_MAX_AQ_BUF_SIZE;\n", "prefixes": [ "next", "S8", "10/12" ] }