Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1135859/?format=api
{ "id": 1135859, "url": "http://patchwork.ozlabs.org/api/patches/1135859/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190723100144.57435-12-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190723100144.57435-12-alice.michael@intel.com>", "list_archive_url": null, "date": "2019-07-23T10:01:44", "name": "[next,S8,12/12] i40e: fix retrying in i40e_aq_get_phy_capabilities", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1f5d8b0fa52fd8e11e657cad7258689db6b12f9b", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190723100144.57435-12-alice.michael@intel.com/mbox/", "series": [ { "id": 121043, "url": "http://patchwork.ozlabs.org/api/series/121043/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=121043", "date": "2019-07-23T10:01:38", "name": "[next,S8,01/12] i40e: fix shifts of signed values", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/121043/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1135859/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1135859/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45tRfZ5TbSz9s00\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 24 Jul 2019 04:22:46 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 303F284D49;\n\tTue, 23 Jul 2019 18:22:45 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id rf6dO+qeZFlY; Tue, 23 Jul 2019 18:22:42 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id CA2C984D6E;\n\tTue, 23 Jul 2019 18:22:41 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 5B96F1BF2A5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jul 2019 18:22:40 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 55BA685B18\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jul 2019 18:22:40 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id K2qmkf6JljJI for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jul 2019 18:22:39 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id B96E385ACD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jul 2019 18:22:39 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Jul 2019 11:22:37 -0700", "from alicemic-1.jf.intel.com ([10.166.17.62])\n\tby orsmga003.jf.intel.com with ESMTP; 23 Jul 2019 11:22:35 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,299,1559545200\"; d=\"scan'208\";a=\"172037680\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Tue, 23 Jul 2019 06:01:44 -0400", "Message-Id": "<20190723100144.57435-12-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190723100144.57435-1-alice.michael@intel.com>", "References": "<20190723100144.57435-1-alice.michael@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S8 12/12] i40e: fix retrying in\n\ti40e_aq_get_phy_capabilities", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Marcin Formela <marcin.formela@intel.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Marcin Formela <marcin.formela@intel.com>\n\nFixed a bug where driver was breaking out of the loop and\nreporting an error without retrying first.\n\nSigned-off-by: Marcin Formela <marcin.formela@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_common.c | 17 ++++++++++-------\n 1 file changed, 10 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c\nindex de996a80013e..46e649c09f72 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c\n@@ -1577,19 +1577,22 @@ i40e_status i40e_aq_get_phy_capabilities(struct i40e_hw *hw,\n \t\tstatus = i40e_asq_send_command(hw, &desc, abilities,\n \t\t\t\t\t abilities_size, cmd_details);\n \n-\t\tif (status)\n-\t\t\tbreak;\n-\n-\t\tif (hw->aq.asq_last_status == I40E_AQ_RC_EIO) {\n+\t\tswitch (hw->aq.asq_last_status) {\n+\t\tcase I40E_AQ_RC_EIO:\n \t\t\tstatus = I40E_ERR_UNKNOWN_PHY;\n \t\t\tbreak;\n-\t\t} else if (hw->aq.asq_last_status == I40E_AQ_RC_EAGAIN) {\n+\t\tcase I40E_AQ_RC_EAGAIN:\n \t\t\tusleep_range(1000, 2000);\n \t\t\ttotal_delay++;\n \t\t\tstatus = I40E_ERR_TIMEOUT;\n+\t\t\tbreak;\n+\t\t/* also covers I40E_AQ_RC_OK */\n+\t\tdefault:\n+\t\t\tbreak;\n \t\t}\n-\t} while ((hw->aq.asq_last_status != I40E_AQ_RC_OK) &&\n-\t\t (total_delay < max_delay));\n+\n+\t} while ((hw->aq.asq_last_status == I40E_AQ_RC_EAGAIN) &&\n+\t\t(total_delay < max_delay));\n \n \tif (status)\n \t\treturn status;\n", "prefixes": [ "next", "S8", "12/12" ] }