Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1135852/?format=api
{ "id": 1135852, "url": "http://patchwork.ozlabs.org/api/patches/1135852/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190723092759.3614-8-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190723092759.3614-8-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2019-07-23T09:27:55", "name": "[S24,08/12] ice: Rename ethtool private flag for lldp", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "cd574b63fd41c264966d3ecd99c558b2bfaa3781", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190723092759.3614-8-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 121041, "url": "http://patchwork.ozlabs.org/api/series/121041/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=121041", "date": "2019-07-23T09:27:51", "name": "[S24,01/12] ice: Allow egress control packets from PF_VSI", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/121041/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1135852/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1135852/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45tR484Frzz9sBt\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 24 Jul 2019 03:56:24 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0844884CE6;\n\tTue, 23 Jul 2019 17:56:23 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id NML0gmXBq0pK; Tue, 23 Jul 2019 17:56:21 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7978185B81;\n\tTue, 23 Jul 2019 17:56:21 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 4939B1BF95A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jul 2019 17:56:19 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 408F381FAA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jul 2019 17:56:19 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id kcwmBJXUtmXL for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jul 2019 17:56:16 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id D96E084D49\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jul 2019 17:56:15 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Jul 2019 10:56:14 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby orsmga002.jf.intel.com with ESMTP; 23 Jul 2019 10:56:13 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,299,1559545200\"; d=\"scan'208\";a=\"180816348\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 23 Jul 2019 02:27:55 -0700", "Message-Id": "<20190723092759.3614-8-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190723092759.3614-1-anthony.l.nguyen@intel.com>", "References": "<20190723092759.3614-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S24 08/12] ice: Rename ethtool private\n\tflag for lldp", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Dave Ertman <david.m.ertman@intel.com>\n\nThe current flag name of \"enable-fw-lldp\" is a bit cumbersome.\n\nChange priv-flag name to \"fw-lldp-agent\" with a value of on or\noff. This is more straight-forward in meaning.\n\nSigned-off-by: Dave Ertman <david.m.ertman@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice.h | 2 +-\n drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 4 ++--\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 6 +++---\n drivers/net/ethernet/intel/ice/ice_lib.c | 4 ++--\n 4 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h\nindex 8398dd45a8a2..0e233b7c40bc 100644\n--- a/drivers/net/ethernet/intel/ice/ice.h\n+++ b/drivers/net/ethernet/intel/ice/ice.h\n@@ -331,7 +331,7 @@ enum ice_pf_flags {\n \tICE_FLAG_DCB_ENA,\n \tICE_FLAG_LINK_DOWN_ON_CLOSE_ENA,\n \tICE_FLAG_NO_MEDIA,\n-\tICE_FLAG_ENABLE_FW_LLDP,\n+\tICE_FLAG_FW_LLDP_AGENT,\n \tICE_FLAG_ETHTOOL_CTXT,\t\t/* set when ethtool holds RTNL lock */\n \tICE_PF_FLAGS_NBITS\t\t/* must be last */\n };\ndiff --git a/drivers/net/ethernet/intel/ice/ice_dcb_lib.c b/drivers/net/ethernet/intel/ice/ice_dcb_lib.c\nindex 2a868eea2a37..21405958aa63 100644\n--- a/drivers/net/ethernet/intel/ice/ice_dcb_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_dcb_lib.c\n@@ -462,7 +462,7 @@ int ice_init_pf_dcb(struct ice_pf *pf, bool locked)\n \t\tdev_info(&pf->pdev->dev,\n \t\t\t \"FW LLDP is disabled, DCBx/LLDP in SW mode.\\n\");\n \t\tport_info->is_sw_lldp = true;\n-\t\tclear_bit(ICE_FLAG_ENABLE_FW_LLDP, pf->flags);\n+\t\tclear_bit(ICE_FLAG_FW_LLDP_AGENT, pf->flags);\n \t\terr = ice_dcb_sw_dflt_cfg(pf, locked);\n \t\tif (err) {\n \t\t\tdev_err(&pf->pdev->dev,\n@@ -478,7 +478,7 @@ int ice_init_pf_dcb(struct ice_pf *pf, bool locked)\n \t}\n \n \tport_info->is_sw_lldp = false;\n-\tset_bit(ICE_FLAG_ENABLE_FW_LLDP, pf->flags);\n+\tset_bit(ICE_FLAG_FW_LLDP_AGENT, pf->flags);\n \n \t/* DCBX in FW and LLDP enabled in FW */\n \tpf->dcbx_cap = DCB_CAP_DCBX_LLD_MANAGED | DCB_CAP_DCBX_VER_IEEE;\ndiff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex 35aa4a3f59df..b60bcbcf9bf2 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -155,7 +155,7 @@ struct ice_priv_flag {\n \n static const struct ice_priv_flag ice_gstrings_priv_flags[] = {\n \tICE_PRIV_FLAG(\"link-down-on-close\", ICE_FLAG_LINK_DOWN_ON_CLOSE_ENA),\n-\tICE_PRIV_FLAG(\"enable-fw-lldp\", ICE_FLAG_ENABLE_FW_LLDP),\n+\tICE_PRIV_FLAG(\"fw-lldp-agent\", ICE_FLAG_FW_LLDP_AGENT),\n };\n \n #define ICE_PRIV_FLAG_ARRAY_SIZE\tARRAY_SIZE(ice_gstrings_priv_flags)\n@@ -1201,8 +1201,8 @@ static int ice_set_priv_flags(struct net_device *netdev, u32 flags)\n \n \tbitmap_xor(change_flags, pf->flags, orig_flags, ICE_PF_FLAGS_NBITS);\n \n-\tif (test_bit(ICE_FLAG_ENABLE_FW_LLDP, change_flags)) {\n-\t\tif (!test_bit(ICE_FLAG_ENABLE_FW_LLDP, pf->flags)) {\n+\tif (test_bit(ICE_FLAG_FW_LLDP_AGENT, change_flags)) {\n+\t\tif (!test_bit(ICE_FLAG_FW_LLDP_AGENT, pf->flags)) {\n \t\t\tenum ice_status status;\n \n \t\t\t/* Disable FW LLDP engine */\ndiff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c\nindex 42645c074691..aff65333c302 100644\n--- a/drivers/net/ethernet/intel/ice/ice_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_lib.c\n@@ -2561,7 +2561,7 @@ ice_vsi_setup(struct ice_pf *pf, struct ice_port_info *pi,\n \t\tice_cfg_sw_lldp(vsi, true, true);\n \n \t\t/* Rx LLDP packets */\n-\t\tif (!test_bit(ICE_FLAG_ENABLE_FW_LLDP, pf->flags))\n+\t\tif (!test_bit(ICE_FLAG_FW_LLDP_AGENT, pf->flags))\n \t\t\tice_cfg_sw_lldp(vsi, false, true);\n \t}\n \n@@ -2908,7 +2908,7 @@ int ice_vsi_release(struct ice_vsi *vsi)\n \t\t/* The Rx rule will only exist to remove if the LLDP FW\n \t\t * engine is currently stopped\n \t\t */\n-\t\tif (!test_bit(ICE_FLAG_ENABLE_FW_LLDP, pf->flags))\n+\t\tif (!test_bit(ICE_FLAG_FW_LLDP_AGENT, pf->flags))\n \t\t\tice_cfg_sw_lldp(vsi, false, false);\n \t}\n \n", "prefixes": [ "S24", "08/12" ] }