Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1135843/?format=api
{ "id": 1135843, "url": "http://patchwork.ozlabs.org/api/patches/1135843/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190723092606.3557-1-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190723092606.3557-1-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2019-07-23T09:26:06", "name": "[S23,v3,14/15] ice: Change type for queue counts", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7084060f3a5b7700dae277d4904474b9ebcd0d3e", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190723092606.3557-1-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 121040, "url": "http://patchwork.ozlabs.org/api/series/121040/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=121040", "date": "2019-07-23T09:24:50", "name": "[S23,v3,01/15] ice: Implement ethtool ops for channels", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/121040/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1135843/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1135843/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45tR1s4YYrz9s4Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 24 Jul 2019 03:54:25 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0FA182045D;\n\tTue, 23 Jul 2019 17:54:24 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id BE0poD3pWkuM; Tue, 23 Jul 2019 17:54:22 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 06AE120407;\n\tTue, 23 Jul 2019 17:54:22 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 89C991BF95A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jul 2019 17:54:21 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 829C881B7D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jul 2019 17:54:21 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zvM2h+167E2S for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jul 2019 17:54:20 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id E140F81B76\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jul 2019 17:54:20 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Jul 2019 10:54:20 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby fmsmga001.fm.intel.com with ESMTP; 23 Jul 2019 10:54:20 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,299,1559545200\"; d=\"scan'208\";a=\"188886058\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 23 Jul 2019 02:26:06 -0700", "Message-Id": "<20190723092606.3557-1-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S23 v3 14/15] ice: Change type for queue\n\tcounts", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "pmenzel@molgen.mpg.de", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Pawel Kaminski <pawel.kaminski@intel.com>\n\nThese queue variables are being assigned values that are type u16.\nChange the local variables to match these types. Since these\nrepresent queue counts, they should never be negative.\n\nSigned-off-by: Pawel Kaminski <pawel.kaminski@intel.com>\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\nv3: Change type back to u16\n Fix format specifiers and min_t type\n Redo commit message\n\nv2: Change type from u16 to unsigned int\n Reword commit message\n\n .../net/ethernet/intel/ice/ice_virtchnl_pf.c | 25 ++++++++++---------\n 1 file changed, 13 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\nindex 829102ee6e0c..0254b945d576 100644\n--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n@@ -2338,11 +2338,11 @@ static int ice_vc_request_qs_msg(struct ice_vf *vf, u8 *msg)\n \tenum virtchnl_status_code v_ret = VIRTCHNL_STATUS_SUCCESS;\n \tstruct virtchnl_vf_res_request *vfres =\n \t\t(struct virtchnl_vf_res_request *)msg;\n-\tint req_queues = vfres->num_queue_pairs;\n+\tu16 req_queues = vfres->num_queue_pairs;\n \tstruct ice_pf *pf = vf->pf;\n-\tint max_allowed_vf_queues;\n-\tint tx_rx_queue_left;\n-\tint cur_queues;\n+\tu16 max_allowed_vf_queues;\n+\tu16 tx_rx_queue_left;\n+\tu16 cur_queues;\n \n \tif (!test_bit(ICE_VF_STATE_ACTIVE, vf->vf_states)) {\n \t\tv_ret = VIRTCHNL_STATUS_ERR_PARAM;\n@@ -2350,29 +2350,30 @@ static int ice_vc_request_qs_msg(struct ice_vf *vf, u8 *msg)\n \t}\n \n \tcur_queues = vf->num_vf_qs;\n-\ttx_rx_queue_left = min_t(int, pf->q_left_tx, pf->q_left_rx);\n+\ttx_rx_queue_left = min_t(u16, pf->q_left_tx, pf->q_left_rx);\n \tmax_allowed_vf_queues = tx_rx_queue_left + cur_queues;\n-\tif (req_queues <= 0) {\n+\tif (!req_queues) {\n \t\tdev_err(&pf->pdev->dev,\n-\t\t\t\"VF %d tried to request %d queues. Ignoring.\\n\",\n-\t\t\tvf->vf_id, req_queues);\n+\t\t\t\"VF %d tried to request 0 queues. Ignoring.\\n\",\n+\t\t\tvf->vf_id);\n \t} else if (req_queues > ICE_MAX_BASE_QS_PER_VF) {\n \t\tdev_err(&pf->pdev->dev,\n \t\t\t\"VF %d tried to request more than %d queues.\\n\",\n \t\t\tvf->vf_id, ICE_MAX_BASE_QS_PER_VF);\n \t\tvfres->num_queue_pairs = ICE_MAX_BASE_QS_PER_VF;\n-\t} else if (req_queues - cur_queues > tx_rx_queue_left) {\n+\t} else if (req_queues > cur_queues &&\n+\t\t req_queues - cur_queues > tx_rx_queue_left) {\n \t\tdev_warn(&pf->pdev->dev,\n-\t\t\t \"VF %d requested %d more queues, but only %d left.\\n\",\n+\t\t\t \"VF %d requested %u more queues, but only %u left.\\n\",\n \t\t\t vf->vf_id, req_queues - cur_queues, tx_rx_queue_left);\n-\t\tvfres->num_queue_pairs = min_t(int, max_allowed_vf_queues,\n+\t\tvfres->num_queue_pairs = min_t(u16, max_allowed_vf_queues,\n \t\t\t\t\t ICE_MAX_BASE_QS_PER_VF);\n \t} else {\n \t\t/* request is successful, then reset VF */\n \t\tvf->num_req_qs = req_queues;\n \t\tice_vc_dis_vf(vf);\n \t\tdev_info(&pf->pdev->dev,\n-\t\t\t \"VF %d granted request of %d queues.\\n\",\n+\t\t\t \"VF %d granted request of %u queues.\\n\",\n \t\t\t vf->vf_id, req_queues);\n \t\treturn 0;\n \t}\n", "prefixes": [ "S23", "v3", "14/15" ] }