Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1135766/?format=api
{ "id": 1135766, "url": "http://patchwork.ozlabs.org/api/patches/1135766/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190723160848.1006-1-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190723160848.1006-1-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2019-07-23T16:08:48", "name": "fm10k: use a local variable for the frag pointer", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f11170423e60a0bbf7e7eaee83b136a61c8e013a", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190723160848.1006-1-jacob.e.keller@intel.com/mbox/", "series": [ { "id": 121024, "url": "http://patchwork.ozlabs.org/api/series/121024/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=121024", "date": "2019-07-23T16:08:48", "name": "fm10k: use a local variable for the frag pointer", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/121024/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1135766/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1135766/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45tNhY6m7wz9s00\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 24 Jul 2019 02:09:16 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8ADD020444;\n\tTue, 23 Jul 2019 16:09:14 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Ud5NtbW-WASh; Tue, 23 Jul 2019 16:09:11 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8D5FB20446;\n\tTue, 23 Jul 2019 16:09:11 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6723E1BF2AE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jul 2019 16:09:10 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 63D1B203C9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jul 2019 16:09:10 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tWogLXbazLGM for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jul 2019 16:09:09 +0000 (UTC)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby silver.osuosl.org (Postfix) with ESMTPS id C965920444\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 23 Jul 2019 16:09:09 +0000 (UTC)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Jul 2019 09:08:51 -0700", "from jekeller-desk.amr.corp.intel.com ([10.166.244.172])\n\tby fmsmga005.fm.intel.com with ESMTP; 23 Jul 2019 09:08:50 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,299,1559545200\"; d=\"scan'208\";a=\"368419199\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Tue, 23 Jul 2019 09:08:48 -0700", "Message-Id": "<20190723160848.1006-1-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.22.0.214.g8dca754b1e87", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] fm10k: use a local variable for the frag\n\tpointer", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "In the function fm10k_xmit_frame_ring, we recently switched to using\nthe skb_frag_size accessor instead of directly using the size member of\nthe skb fragment.\n\nThis made the for loop slightly harder to read because it created a very\nlong line that is difficult to split up. Avoid this by using a local\nvariable in the for loop, so that we do not have to break the line on an\nopen parenthesis.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_main.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\nindex e0a2be534b20..2be9222510e7 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n@@ -1073,9 +1073,11 @@ netdev_tx_t fm10k_xmit_frame_ring(struct sk_buff *skb,\n \t * + 2 desc gap to keep tail from touching head\n \t * otherwise try next time\n \t */\n-\tfor (f = 0; f < skb_shinfo(skb)->nr_frags; f++)\n-\t\tcount += TXD_USE_COUNT(skb_frag_size(\n-\t\t\t\t\t\t&skb_shinfo(skb)->frags[f]));\n+\tfor (f = 0; f < skb_shinfo(skb)->nr_frags; f++) {\n+\t\tskb_frag_t *frag = &skb_shinfo(skb)->frags[f];\n+\n+\t\tcount += TXD_USE_COUNT(skb_frag_size(frag));\n+\t}\n \n \tif (fm10k_maybe_stop_tx(tx_ring, count + 3)) {\n \t\ttx_ring->tx_stats.tx_busy++;\n", "prefixes": [] }