Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1133777/?format=api
{ "id": 1133777, "url": "http://patchwork.ozlabs.org/api/patches/1133777/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190718020745.8867-4-fred@fredlawl.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190718020745.8867-4-fred@fredlawl.com>", "list_archive_url": null, "date": "2019-07-18T02:07:39", "name": "igc: Prefer pcie_capability_read_word()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b5eaf13723942538d5517c1b00dfa6d365f03dae", "submitter": { "id": 73063, "url": "http://patchwork.ozlabs.org/api/people/73063/?format=api", "name": "Frederick Lawler", "email": "fred@fredlawl.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190718020745.8867-4-fred@fredlawl.com/mbox/", "series": [ { "id": 120232, "url": "http://patchwork.ozlabs.org/api/series/120232/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=120232", "date": "2019-07-18T02:07:39", "name": "igc: Prefer pcie_capability_read_word()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/120232/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1133777/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1133777/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=fredlawl.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=fredlawl-com.20150623.gappssmtp.com\n\theader.i=@fredlawl-com.20150623.gappssmtp.com\n\theader.b=\"mTXnqU5j\"; dkim-atps=neutral" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45qKrF1xRsz9s4Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 19 Jul 2019 02:50:18 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C9C8087885;\n\tThu, 18 Jul 2019 16:50:15 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id aU95C1yq-8Zt; Thu, 18 Jul 2019 16:50:14 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 77DC88787C;\n\tThu, 18 Jul 2019 16:50:14 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 06E4A1BF308\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 18 Jul 2019 02:17:03 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0355820403\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 18 Jul 2019 02:17:03 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id UHBnuHdSBDFi for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 18 Jul 2019 02:17:00 +0000 (UTC)", "from mail-oi1-f195.google.com (mail-oi1-f195.google.com\n\t[209.85.167.195])\n\tby silver.osuosl.org (Postfix) with ESMTPS id C2F5A2279E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 18 Jul 2019 02:17:00 +0000 (UTC)", "by mail-oi1-f195.google.com with SMTP id e189so20163314oib.11\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 17 Jul 2019 19:17:00 -0700 (PDT)", "from linux.fredlawl.com ([2600:1700:18a0:11d0:18af:e893:6cb0:139a])\n\tby smtp.gmail.com with ESMTPSA id\n\t93sm9102146ota.77.2019.07.17.19.08.49\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tWed, 17 Jul 2019 19:08:50 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:08:09 by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=fredlawl-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=pYIGokAnHiTaXGPTQHk0GqCr5VmgXxhysOu7yDy4mE8=;\n\tb=mTXnqU5jjT+d2PiAwqfS+oHZeBwddIfIzbgwJr5HJVj8OZu3Ejhi+A9hQAi3E1QXSB\n\tp6yso+LASKDHoVMvrSZNUJW8Qr/lVybvydLGLZG3dAWCnsQe9rQVN9QPaP7cXSOOm7xG\n\tWeqBJrZ7jJE0djFZh+4thTZM1/E0H6ZFc4+kAD5x48/AIdMh8SWZL9dZtCJBm9OVm3eH\n\thJBKA/kvNzNJnG5RfU9oPb10jIKyI3UyWzoAX2uJ9/ndXvbz/1w5O7at+bEgY29vT8Un\n\tcx5tgXraKzGDqNnRvqxLNfVGtKJDyu6t+DvKjYCl0HBdgLrZT/IlUcw4u2gwiB4nTnZ7\n\tvcMw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=pYIGokAnHiTaXGPTQHk0GqCr5VmgXxhysOu7yDy4mE8=;\n\tb=TRR9NWKTQfrGys/EEXEaHOkci4e7ehhlOV3bPT8OWCs/h1wpWA/Ka8YARfvSx5EM9Y\n\tF404Jau1tw61WPSMEtBa8d+3SWwdYLbTy/YLeZnV9PSW8hVb9LdFNsjQpSi/uoLdZuTN\n\tNipOoilIabrqcv8smBfjJVMizy5XcFeW1TUY5NC9s/LgICgTceR8ic85Uv/BzG3mD3F0\n\tWlNw/8tfN/bOHZruAxn2/gfd2I2t/a32giRqL5lMqT6Wg2txEewQx9VXDtCM3mmgTORe\n\tKSMMmt0HJoWt/eP+S7iX0EOH28eKf1ChZVGXijRwXbmOlBodZQRsBx8LDyHxbSfxqs3D\n\tvOcQ==", "X-Gm-Message-State": "APjAAAX8iBl2gW3eWPty9IERof5Yf2PAs/ljDY3yDeBzCwCczoSfhlBS\n\tK6Z0ayaUtmnJp2raryAw7ANnz3Z/gJPinQ==", "X-Google-Smtp-Source": "APXvYqyU0Pfb/5vUCO66TmKbYlCzgLlHqd41g6a+kdgNWxNg9gHANJ35Dgn3P91SIentrM9mHXMU4w==", "X-Received": "by 2002:aca:382:: with SMTP id 124mr19829874oid.80.1563415730827;\n\tWed, 17 Jul 2019 19:08:50 -0700 (PDT)", "From": "Frederick Lawler <fred@fredlawl.com>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Wed, 17 Jul 2019 21:07:39 -0500", "Message-Id": "<20190718020745.8867-4-fred@fredlawl.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190718020745.8867-1-fred@fredlawl.com>", "References": "<20190718020745.8867-1-fred@fredlawl.com>", "X-Mailman-Approved-At": "Thu, 18 Jul 2019 16:50:11 +0000", "Subject": "[Intel-wired-lan] [PATCH] igc: Prefer pcie_capability_read_word()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "bhelgaas@google.com, netdev@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org,\n\tFrederick Lawler <fred@fredlawl.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Commit 8c0d3a02c130 (\"PCI: Add accessors for PCI Express Capability\")\nadded accessors for the PCI Express Capability so that drivers didn't\nneed to be aware of differences between v1 and v2 of the PCI\nExpress Capability.\n\nReplace pci_read_config_word() and pci_write_config_word() calls with\npcie_capability_read_word() and pcie_capability_write_word().\n\nSigned-off-by: Frederick Lawler <fred@fredlawl.com>\n---\n drivers/net/ethernet/intel/igc/igc_main.c | 12 ++++--------\n 1 file changed, 4 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex 34fa0e60a780..8e8ad07a5776 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -3891,13 +3891,11 @@ void igc_write_pci_cfg(struct igc_hw *hw, u32 reg, u16 *value)\n s32 igc_read_pcie_cap_reg(struct igc_hw *hw, u32 reg, u16 *value)\n {\n \tstruct igc_adapter *adapter = hw->back;\n-\tu16 cap_offset;\n \n-\tcap_offset = pci_find_capability(adapter->pdev, PCI_CAP_ID_EXP);\n-\tif (!cap_offset)\n+\tif (!pci_is_pcie(adapter->pdev))\n \t\treturn -IGC_ERR_CONFIG;\n \n-\tpci_read_config_word(adapter->pdev, cap_offset + reg, value);\n+\tpcie_capability_read_word(adapter->pdev, reg, value);\n \n \treturn IGC_SUCCESS;\n }\n@@ -3905,13 +3903,11 @@ s32 igc_read_pcie_cap_reg(struct igc_hw *hw, u32 reg, u16 *value)\n s32 igc_write_pcie_cap_reg(struct igc_hw *hw, u32 reg, u16 *value)\n {\n \tstruct igc_adapter *adapter = hw->back;\n-\tu16 cap_offset;\n \n-\tcap_offset = pci_find_capability(adapter->pdev, PCI_CAP_ID_EXP);\n-\tif (!cap_offset)\n+\tif (!pci_is_pcie(adapter->pdev))\n \t\treturn -IGC_ERR_CONFIG;\n \n-\tpci_write_config_word(adapter->pdev, cap_offset + reg, *value);\n+\tpcie_capability_write_word(adapter->pdev, reg, *value);\n \n \treturn IGC_SUCCESS;\n }\n", "prefixes": [] }