Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1132126/?format=api
{ "id": 1132126, "url": "http://patchwork.ozlabs.org/api/patches/1132126/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190715045706.6140-1-ap420073@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190715045706.6140-1-ap420073@gmail.com>", "list_archive_url": null, "date": "2019-07-15T04:57:06", "name": "[net] ixgbe: fix possible deadlock in ixgbe_service_task()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "46232ac9ef1ea5bfa5706efc7a3ac35506677688", "submitter": { "id": 68997, "url": "http://patchwork.ozlabs.org/api/people/68997/?format=api", "name": "Taehee Yoo", "email": "ap420073@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190715045706.6140-1-ap420073@gmail.com/mbox/", "series": [ { "id": 119560, "url": "http://patchwork.ozlabs.org/api/series/119560/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=119560", "date": "2019-07-15T04:57:06", "name": "[net] ixgbe: fix possible deadlock in ixgbe_service_task()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/119560/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1132126/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1132126/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"oFJbqO7F\"; dkim-atps=neutral" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45nVSD6pRZz9sLt\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 16 Jul 2019 03:11:40 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D4D35207A6;\n\tMon, 15 Jul 2019 17:11:38 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ZO327dMm+4dR; Mon, 15 Jul 2019 17:11:36 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 2B38720410;\n\tMon, 15 Jul 2019 17:11:36 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id D5A4D1BF3DB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Jul 2019 04:57:53 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id D1B1085817\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Jul 2019 04:57:53 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id kBLM131YsNfL for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Jul 2019 04:57:53 +0000 (UTC)", "from mail-pg1-f193.google.com (mail-pg1-f193.google.com\n\t[209.85.215.193])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 717C48453B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Jul 2019 04:57:53 +0000 (UTC)", "by mail-pg1-f193.google.com with SMTP id t132so7087174pgb.9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 14 Jul 2019 21:57:53 -0700 (PDT)", "from localhost.localdomain ([211.196.191.92])\n\tby smtp.gmail.com with ESMTPSA id\n\tx25sm16838955pfa.90.2019.07.14.21.57.50\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tSun, 14 Jul 2019 21:57:51 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:subject:date:message-id;\n\tbh=hMKYnCG1MovC2e0NthlYTwADIbhywb3Mf8OKx2c0Q88=;\n\tb=oFJbqO7FFhbMh2PePtZO8L1DEUSn/seuPNZp+G02tB0DnB3l2dzcoiDGm5WFCK3C+E\n\tyuoah+Azp/0YMv4WSDKUYrgoLVLCO0gtxO978paE/ZnKRtsH4qk4Z1bMbWzW7IGi5Vlr\n\tDy5gWWTB/SlSxNwecS/XTxE/iKDOGEr+YLZe8kHNCT9TXYCyYZ1b4VbSx8OJAAcaGpbm\n\t/9g63tKvL8qHIpDHSUl9FYouXbgvETvsZNo9uoln5Mx0Kz2L22do5DYyGkRmj1zqHUt+\n\td1w78Q9MGTNd9xrvT2ps4qrnwdtUkIKHXqrUq4nSiudmQ0IjJZs6bS0mBT5oqMtcauAM\n\tRWVg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:date:message-id;\n\tbh=hMKYnCG1MovC2e0NthlYTwADIbhywb3Mf8OKx2c0Q88=;\n\tb=mDNSKFemiCNgvw9mAoyqg9RLJfDKSJW9R2cQfMYwx/wiDz/P8sLGjHFcfBPVqGBbkj\n\tasA3lQSNYhbbsIl3lEraGG4QAqykH2fgrkpyi3uMEzkiDMlrLTsB6LC66+tCFFc1j8hV\n\tjKdgVcDeOfMp7Phb/QPXrhxxujpriTZ112sn9a1ExhF040qcS3diwQuc6cHR6QdiUGI9\n\tqnw3AUe4RX3q2hV8n2mb56lDiXGcVWq/k/GcxR7cuG/KUD3QH2bfly2VRtr155h+JjjU\n\t85Z2x66yOZxk+uVBqvbbcpMpqxN4qI5XxAubSUMsfS+4Zeo72tQPH54YHwwWymISFvWb\n\tBwAg==", "X-Gm-Message-State": "APjAAAU1Qh+ArLG2hHHUVsG7jy9ic2TSmGkYXZTkNwqFhWp4dcjbcaLA\n\tTfs6sg/hywoHFHp9jaOiQ64=", "X-Google-Smtp-Source": "APXvYqzuibIepvUCVkUQ34EWOnD4iCLGzvl0Crytvk1X7CKNy5IZ7NVm8R/4IwjRaDaBeqNwoDzZqg==", "X-Received": "by 2002:a17:90a:32ec:: with SMTP id\n\tl99mr27356363pjb.44.1563166672931; \n\tSun, 14 Jul 2019 21:57:52 -0700 (PDT)", "From": "Taehee Yoo <ap420073@gmail.com>", "To": "jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org,\n\tap420073@gmail.com", "Date": "Mon, 15 Jul 2019 13:57:06 +0900", "Message-Id": "<20190715045706.6140-1-ap420073@gmail.com>", "X-Mailer": "git-send-email 2.17.1", "X-Mailman-Approved-At": "Mon, 15 Jul 2019 17:11:34 +0000", "Subject": "[Intel-wired-lan] [PATCH net] ixgbe: fix possible deadlock in\n\tixgbe_service_task()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "ixgbe_service_task() calls unregister_netdev() under rtnl_lock().\nBut unregister_netdev() internally calls rtnl_lock().\nSo deadlock would occur.\n\nFixes: 59dd45d550c5 (\"ixgbe: firmware recovery mode\")\nSigned-off-by: Taehee Yoo <ap420073@gmail.com>\n---\nI did only compile test because I don't have the hardware.\nCould anyone test this patch?\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 57fd9ee6de66..b4888be94dfb 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -7894,9 +7894,7 @@ static void ixgbe_service_task(struct work_struct *work)\n \t}\n \tif (ixgbe_check_fw_error(adapter)) {\n \t\tif (!test_bit(__IXGBE_DOWN, &adapter->state)) {\n-\t\t\trtnl_lock();\n \t\t\tunregister_netdev(adapter->netdev);\n-\t\t\trtnl_unlock();\n \t\t}\n \t\tixgbe_service_event_complete(adapter);\n \t\treturn;\n", "prefixes": [ "net" ] }