Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1131961/?format=api
{ "id": 1131961, "url": "http://patchwork.ozlabs.org/api/patches/1131961/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190715122555.11922-1-kai.heng.feng@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190715122555.11922-1-kai.heng.feng@canonical.com>", "list_archive_url": null, "date": "2019-07-15T12:25:55", "name": "[v2] e1000e: Make speed detection on hotplugging cable more reliable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "125d5518d2c11e366d20f53cf0e30b00849202d9", "submitter": { "id": 70328, "url": "http://patchwork.ozlabs.org/api/people/70328/?format=api", "name": "Kai-Heng Feng", "email": "kai.heng.feng@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190715122555.11922-1-kai.heng.feng@canonical.com/mbox/", "series": [ { "id": 119504, "url": "http://patchwork.ozlabs.org/api/series/119504/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=119504", "date": "2019-07-15T12:25:55", "name": "[v2] e1000e: Make speed detection on hotplugging cable more reliable", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/119504/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1131961/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1131961/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=fail (p=none dis=none)\n\theader.from=canonical.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45nN6r50fvz9sNH\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 15 Jul 2019 22:26:12 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id C944585D39;\n\tMon, 15 Jul 2019 12:26:10 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FTt21XkXoT06; Mon, 15 Jul 2019 12:26:09 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8CE8F84707;\n\tMon, 15 Jul 2019 12:26:09 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 78B291BF3DF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Jul 2019 12:26:08 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7370820781\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Jul 2019 12:26:08 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id AOEDepWpqB91 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Jul 2019 12:26:07 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby silver.osuosl.org (Postfix) with ESMTPS id C270F204C4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Jul 2019 12:26:07 +0000 (UTC)", "from 61-220-137-37.hinet-ip.hinet.net ([61.220.137.37]\n\thelo=localhost) by youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <kai.heng.feng@canonical.com>)\n\tid 1hn03R-0004qz-1F; Mon, 15 Jul 2019 12:26:05 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Kai-Heng Feng <kai.heng.feng@canonical.com>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Mon, 15 Jul 2019 20:25:55 +0800", "Message-Id": "<20190715122555.11922-1-kai.heng.feng@canonical.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190715084355.9962-1-kai.heng.feng@canonical.com>", "References": "<20190715084355.9962-1-kai.heng.feng@canonical.com>", "Subject": "[Intel-wired-lan] [PATCH v2] e1000e: Make speed detection on\n\thotplugging cable more reliable", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, Kai-Heng Feng <kai.heng.feng@canonical.com>,\n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "After hotplugging an 1Gbps ethernet cable with 1Gbps link partner, the\nMII_BMSR may report 10Mbps, renders the network rather slow.\n\nThe issue has much lower fail rate after commit 59653e6497d1 (\"e1000e:\nMake watchdog use delayed work\"), which essentially introduces some\ndelay before running the watchdog task.\n\nBut there's still a chance that the hotplugging event and the queued\nwatchdog task gets run at the same time, then the original issue can be\nobserved once again.\n\nSo let's use mod_delayed_work() to add a deterministic 1 second delay\nbefore running watchdog task, after an interrupt.\n\nSigned-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex e4baa13b3cda..c83bf5349d53 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -1780,8 +1780,8 @@ static irqreturn_t e1000_intr_msi(int __always_unused irq, void *data)\n \t\t}\n \t\t/* guard against interrupt when we're going down */\n \t\tif (!test_bit(__E1000_DOWN, &adapter->state))\n-\t\t\tqueue_delayed_work(adapter->e1000_workqueue,\n-\t\t\t\t\t &adapter->watchdog_task, 1);\n+\t\t\tmod_delayed_work(adapter->e1000_workqueue,\n+\t\t\t\t\t &adapter->watchdog_task, HZ);\n \t}\n \n \t/* Reset on uncorrectable ECC error */\n@@ -1861,8 +1861,8 @@ static irqreturn_t e1000_intr(int __always_unused irq, void *data)\n \t\t}\n \t\t/* guard against interrupt when we're going down */\n \t\tif (!test_bit(__E1000_DOWN, &adapter->state))\n-\t\t\tqueue_delayed_work(adapter->e1000_workqueue,\n-\t\t\t\t\t &adapter->watchdog_task, 1);\n+\t\t\tmod_delayed_work(adapter->e1000_workqueue,\n+\t\t\t\t\t &adapter->watchdog_task, HZ);\n \t}\n \n \t/* Reset on uncorrectable ECC error */\n@@ -1907,8 +1907,8 @@ static irqreturn_t e1000_msix_other(int __always_unused irq, void *data)\n \t\thw->mac.get_link_status = true;\n \t\t/* guard against interrupt when we're going down */\n \t\tif (!test_bit(__E1000_DOWN, &adapter->state))\n-\t\t\tqueue_delayed_work(adapter->e1000_workqueue,\n-\t\t\t\t\t &adapter->watchdog_task, 1);\n+\t\t\tmod_delayed_work(adapter->e1000_workqueue,\n+\t\t\t\t\t &adapter->watchdog_task, HZ);\n \t}\n \n \tif (!test_bit(__E1000_DOWN, &adapter->state))\n", "prefixes": [ "v2" ] }