Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1130388/?format=api
{ "id": 1130388, "url": "http://patchwork.ozlabs.org/api/patches/1130388/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20190710130026.28009-3-chuanhua.han@nxp.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190710130026.28009-3-chuanhua.han@nxp.com>", "list_archive_url": null, "date": "2019-07-10T13:00:22", "name": "[U-Boot,v4,3/7] drivers: i2c: mxc: Solve the compiler error when using i2c dm mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fb0a18678f1703d6076ebbedc82ec01c3d8c1cf7", "submitter": { "id": 74737, "url": "http://patchwork.ozlabs.org/api/people/74737/?format=api", "name": "Chuanhua Han", "email": "chuanhua.han@nxp.com" }, "delegate": { "id": 2467, "url": "http://patchwork.ozlabs.org/api/users/2467/?format=api", "username": "prabhu_kush", "first_name": "Prabhakar", "last_name": "Kushwaha", "email": "prabhakar@freescale.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20190710130026.28009-3-chuanhua.han@nxp.com/mbox/", "series": [ { "id": 118772, "url": "http://patchwork.ozlabs.org/api/series/118772/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=118772", "date": "2019-07-10T13:00:20", "name": "[U-Boot,v4,1/7] armv8: lx2160a: The lx2160a platform supports the I2C driver model.", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/118772/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1130388/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1130388/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=nxp.com" ], "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 45kKNY2nWhz9s7T\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 10 Jul 2019 23:12:29 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid F394EC21F80; Wed, 10 Jul 2019 13:11:03 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 87DFDC21F9E;\n\tWed, 10 Jul 2019 13:09:54 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 0D0B0C21FA6; Wed, 10 Jul 2019 13:09:46 +0000 (UTC)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n\tby lists.denx.de (Postfix) with ESMTPS id 5594FC21F1A\n\tfor <u-boot@lists.denx.de>; Wed, 10 Jul 2019 13:09:40 +0000 (UTC)", "from inva021.nxp.com (localhost [127.0.0.1])\n\tby inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id D5C9420073C;\n\tWed, 10 Jul 2019 15:09:39 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n\t[165.114.16.14])\n\tby inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id A8CDB2001A0;\n\tWed, 10 Jul 2019 15:09:35 +0200 (CEST)", "from titan.ap.freescale.net (TITAN.ap.freescale.net\n\t[10.192.208.233])\n\tby invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 8C1E94030B;\n\tWed, 10 Jul 2019 21:09:30 +0800 (SGT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0", "From": "Chuanhua Han <chuanhua.han@nxp.com>", "To": "albert.u.boot@aribaud.net, priyanka.jain@nxp.com, udit.agarwal@nxp.com, \n\ths@denx.de, prabhakar.kushwaha@nxp.com", "Date": "Wed, 10 Jul 2019 21:00:22 +0800", "Message-Id": "<20190710130026.28009-3-chuanhua.han@nxp.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20190710130026.28009-1-chuanhua.han@nxp.com>", "References": "<20190710130026.28009-1-chuanhua.han@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Cc": "u-boot@lists.denx.de, Chuanhua Han <chuanhua.han@nxp.com>", "Subject": "[U-Boot] [PATCH v4 3/7] drivers: i2c: mxc: Solve the compiler error\n\twhen using i2c dm mode", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "This patch solved the following compilation error:\n\n1.Remove the definition of CONFIG_SYS_I2C to solve the following\ncompilation issue:\nIn file included from include/config.h:8:0,\n from include/common.h:20:\ninclude/config_fallbacks.h:51:4: error: #error \"Cannot define\nCONFIG_SYS_I2C when CONFIG_DM_I2C is used\"\n # error \"Cannot define CONFIG_SYS_I2C when CONFIG_DM_I2C is used\"\n ^~~~~\nIn file included from include/config.h:8:0,\n from include/common.h:20:\ninclude/config_fallbacks.h:51:4: error: #error \"Cannot define\nCONFIG_SYS_I2C when CONFIG_DM_I2C is used\"\n # error \"Cannot define CONFIG_SYS_I2C when CONFIG_DM_I2C is used\"\n ^~~~~\n\n2.Remove the definition of CONFIG_SYS_I2C_EARLY_INIT to solve the\nfollowing compilation issue:\nboard/freescale/lx2160a/lx2160a.c: In function 'board_early_init_f':\nboard/freescale/lx2160a/lx2160a.c:108:2: warning: implicit declaration\nof function 'i2c_early_init_f'; did you mean 'arch_early_init_r'?\n[-Wimplicit-function-declaration]\n i2c_early_init_f();\n ^~~~~~~~~~~~~~~~\n arch_early_init_r\n\n3.Move the enable_i2c_clk function definition to resolve the following\ncompilation issues:\n drivers/i2c/mxc_i2c.c: In function 'mxc_i2c_probe':\n drivers/i2c/mxc_i2c.c:824:8: warning: implicit declaration of function\n'enable_i2c_clk';\n did you mean 'enable_irq_wake'? [-Wimplicit-function-declaration]\n ret = enable_i2c_clk(1, bus->seq);\n ^~~~~~~~~~~~~~\n enable_irq_wake\n\nSigned-off-by: Chuanhua Han <chuanhua.han@nxp.com>\n---\nChanges in v4: \n\t- No change.\nChanges in v3: \n\t- No change.\nChanges in v2: \n\t- No change.\n\n arch/arm/include/asm/arch-fsl-layerscape/config.h | 2 --\n drivers/i2c/mxc_i2c.c | 15 ++++++++-------\n 2 files changed, 8 insertions(+), 9 deletions(-)", "diff": "diff --git a/arch/arm/include/asm/arch-fsl-layerscape/config.h b/arch/arm/include/asm/arch-fsl-layerscape/config.h\nindex eb21c09..5f87499 100644\n--- a/arch/arm/include/asm/arch-fsl-layerscape/config.h\n+++ b/arch/arm/include/asm/arch-fsl-layerscape/config.h\n@@ -178,8 +178,6 @@\n #elif defined(CONFIG_ARCH_LX2160A)\n #define TZPC_BASE\t\t\t\t0x02200000\n #define TZPCDECPROT_0_SET_BASE\t\t\t(TZPC_BASE + 0x804)\n-#define CONFIG_SYS_I2C\n-#define CONFIG_SYS_I2C_EARLY_INIT\n #define SRDS_MAX_LANES 8\n #ifndef L1_CACHE_BYTES\n #define L1_CACHE_SHIFT\t\t6\ndiff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c\nindex 23119cc..73b9807 100644\n--- a/drivers/i2c/mxc_i2c.c\n+++ b/drivers/i2c/mxc_i2c.c\n@@ -558,6 +558,14 @@ static int i2c_read_data(struct mxc_i2c_bus *i2c_bus, uchar chip, uchar *buf,\n \treturn 0;\n }\n \n+int __enable_i2c_clk(unsigned char enable, unsigned int i2c_num)\n+{\n+\treturn 1;\n+}\n+\n+int enable_i2c_clk(unsigned char enable, unsigned int i2c_num)\n+\t__attribute__((weak, alias(\"__enable_i2c_clk\")));\n+\n #ifndef CONFIG_DM_I2C\n /*\n * Read data from I2C device\n@@ -723,13 +731,6 @@ static int mxc_i2c_probe(struct i2c_adapter *adap, uint8_t chip)\n \treturn bus_i2c_write(i2c_get_base(adap), chip, 0, 0, NULL, 0);\n }\n \n-int __enable_i2c_clk(unsigned char enable, unsigned i2c_num)\n-{\n-\treturn 1;\n-}\n-int enable_i2c_clk(unsigned char enable, unsigned i2c_num)\n-\t__attribute__((weak, alias(\"__enable_i2c_clk\")));\n-\n void bus_i2c_init(int index, int speed, int unused,\n \t\t int (*idle_bus_fn)(void *p), void *idle_bus_data)\n {\n", "prefixes": [ "U-Boot", "v4", "3/7" ] }