Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1129416/?format=api
{ "id": 1129416, "url": "http://patchwork.ozlabs.org/api/patches/1129416/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190708231236.20516-17-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190708231236.20516-17-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2019-07-08T23:12:33", "name": "[16/19] fm10k: cast page_addr to u8 * when incrementing it", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0fbb70a74017ce92f57e29a315b47e16800c3bcf", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190708231236.20516-17-jacob.e.keller@intel.com/mbox/", "series": [ { "id": 118423, "url": "http://patchwork.ozlabs.org/api/series/118423/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=118423", "date": "2019-07-08T23:12:19", "name": "cleanup cppcheck warnings for fm10k driver", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/118423/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1129416/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1129416/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45jLpD4Y95z9sPJ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 9 Jul 2019 09:12:52 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 623CC85C19;\n\tMon, 8 Jul 2019 23:12:50 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id MIBS3WaOhsss; Mon, 8 Jul 2019 23:12:49 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 79C1485BD5;\n\tMon, 8 Jul 2019 23:12:49 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 59F621BF967\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 23:12:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5449820356\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 23:12:43 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3mPub0pi-pri for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 23:12:42 +0000 (UTC)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 08D6621511\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 23:12:41 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Jul 2019 16:12:40 -0700", "from jekeller-desk.amr.corp.intel.com ([10.166.244.172])\n\tby fmsmga002.fm.intel.com with ESMTP; 08 Jul 2019 16:12:40 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,468,1557212400\"; d=\"scan'208\";a=\"192484822\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Mon, 8 Jul 2019 16:12:33 -0700", "Message-Id": "<20190708231236.20516-17-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.22.0.214.g8dca754b1e87", "In-Reply-To": "<20190708231236.20516-1-jacob.e.keller@intel.com>", "References": "<20190708231236.20516-1-jacob.e.keller@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 16/19] fm10k: cast page_addr to u8 * when\n\tincrementing it", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The page_addr variable is a void pointer. Incrementing it before calling\nprefetch is technically undefined. Fix this by casting it to a u8*\npointer before incrementing it. This ensures that we increment the\npointer value in byte units, instead of relying on this undefined\nbehavior.\n\nThis was detected by cppcheck, and resolves the following warning\nproduced by that tool:\n\n[fm10k_main.c:328]: (portability) 'page_addr' is of type 'void *'. When\nusing void pointers in calculations, the behaviour is undefined.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_main.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\nindex 3bacf35fbfad..cf87812bdf4a 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n@@ -315,7 +315,7 @@ static struct sk_buff *fm10k_fetch_rx_buffer(struct fm10k_ring *rx_ring,\n \t\t/* prefetch first cache line of first page */\n \t\tprefetch(page_addr);\n #if L1_CACHE_BYTES < 128\n-\t\tprefetch(page_addr + L1_CACHE_BYTES);\n+\t\tprefetch((void *)((u8 *)page_addr + L1_CACHE_BYTES));\n #endif\n \n \t\t/* allocate a skb to store the frags */\n", "prefixes": [ "16/19" ] }