Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1129411/?format=api
{ "id": 1129411, "url": "http://patchwork.ozlabs.org/api/patches/1129411/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190708231236.20516-6-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190708231236.20516-6-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2019-07-08T23:12:22", "name": "[05/19] fm10k: reduce the scope of the q_idx local variable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9be582c7076d37caf9a2e9dec495bbe1ed7d1ea9", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190708231236.20516-6-jacob.e.keller@intel.com/mbox/", "series": [ { "id": 118423, "url": "http://patchwork.ozlabs.org/api/series/118423/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=118423", "date": "2019-07-08T23:12:19", "name": "cleanup cppcheck warnings for fm10k driver", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/118423/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1129411/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1129411/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45jLpB2jKqz9sP6\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 9 Jul 2019 09:12:50 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8793B85BD1;\n\tMon, 8 Jul 2019 23:12:48 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jc5Ycr_mwM8Q; Mon, 8 Jul 2019 23:12:47 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id D832E85BC2;\n\tMon, 8 Jul 2019 23:12:47 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id A6B3C1BF967\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 23:12:42 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id A438920356\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 23:12:42 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id xNkOc3iNbN1c for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 23:12:41 +0000 (UTC)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 56435214F6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 23:12:40 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Jul 2019 16:12:39 -0700", "from jekeller-desk.amr.corp.intel.com ([10.166.244.172])\n\tby fmsmga002.fm.intel.com with ESMTP; 08 Jul 2019 16:12:39 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,468,1557212400\"; d=\"scan'208\";a=\"192484784\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Mon, 8 Jul 2019 16:12:22 -0700", "Message-Id": "<20190708231236.20516-6-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.22.0.214.g8dca754b1e87", "In-Reply-To": "<20190708231236.20516-1-jacob.e.keller@intel.com>", "References": "<20190708231236.20516-1-jacob.e.keller@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 05/19] fm10k: reduce the scope of the\n\tq_idx local variable", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Reduce the scope of the q_idx local variable in the fm10k_cache_ring_qos\nfunction.\n\nThis was detected by cppcheck and resolves the following style warning\nproduced by that tool:\n\n[fm10k_main.c:2016]: (style) The scope of the variable 'q_idx' can be\nreduced.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_main.c | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\nindex 90270b4a1682..3bacf35fbfad 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n@@ -1,5 +1,5 @@\n // SPDX-License-Identifier: GPL-2.0\n-/* Copyright(c) 2013 - 2018 Intel Corporation. */\n+/* Copyright(c) 2013 - 2019 Intel Corporation. */\n \n #include <linux/types.h>\n #include <linux/module.h>\n@@ -17,7 +17,7 @@ const char fm10k_driver_version[] = DRV_VERSION;\n char fm10k_driver_name[] = \"fm10k\";\n static const char fm10k_driver_string[] = DRV_SUMMARY;\n static const char fm10k_copyright[] =\n-\t\"Copyright(c) 2013 - 2018 Intel Corporation.\";\n+\t\"Copyright(c) 2013 - 2019 Intel Corporation.\";\n \n MODULE_AUTHOR(\"Intel Corporation, <linux.nics@intel.com>\");\n MODULE_DESCRIPTION(DRV_SUMMARY);\n@@ -1869,7 +1869,7 @@ static int fm10k_init_msix_capability(struct fm10k_intfc *interface)\n static bool fm10k_cache_ring_qos(struct fm10k_intfc *interface)\n {\n \tstruct net_device *dev = interface->netdev;\n-\tint pc, offset, rss_i, i, q_idx;\n+\tint pc, offset, rss_i, i;\n \tu16 pc_stride = interface->ring_feature[RING_F_QOS].mask + 1;\n \tu8 num_pcs = netdev_get_num_tc(dev);\n \n@@ -1879,7 +1879,8 @@ static bool fm10k_cache_ring_qos(struct fm10k_intfc *interface)\n \trss_i = interface->ring_feature[RING_F_RSS].indices;\n \n \tfor (pc = 0, offset = 0; pc < num_pcs; pc++, offset += rss_i) {\n-\t\tq_idx = pc;\n+\t\tint q_idx = pc;\n+\n \t\tfor (i = 0; i < rss_i; i++) {\n \t\t\tinterface->tx_ring[offset + i]->reg_idx = q_idx;\n \t\t\tinterface->tx_ring[offset + i]->qos_pc = pc;\n", "prefixes": [ "05/19" ] }