Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1129410/?format=api
{ "id": 1129410, "url": "http://patchwork.ozlabs.org/api/patches/1129410/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190708231236.20516-10-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190708231236.20516-10-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2019-07-08T23:12:26", "name": "[09/19] fm10k: reduce the scope of the local msg variable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6d1a24293819780a3ec6e9872985ae84961261ad", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190708231236.20516-10-jacob.e.keller@intel.com/mbox/", "series": [ { "id": 118423, "url": "http://patchwork.ozlabs.org/api/series/118423/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=118423", "date": "2019-07-08T23:12:19", "name": "cleanup cppcheck warnings for fm10k driver", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/118423/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1129410/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1129410/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45jLp94FsRz9sNH\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 9 Jul 2019 09:12:47 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 771C88796C;\n\tMon, 8 Jul 2019 23:12:44 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id v7VjcTAdOuBs; Mon, 8 Jul 2019 23:12:43 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 31EFB8790D;\n\tMon, 8 Jul 2019 23:12:43 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id BB7C91BF46A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 23:12:41 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B29B486614\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 23:12:41 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id x1Q7rW2OlboP for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 23:12:40 +0000 (UTC)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id B186886566\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 23:12:40 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Jul 2019 16:12:40 -0700", "from jekeller-desk.amr.corp.intel.com ([10.166.244.172])\n\tby fmsmga002.fm.intel.com with ESMTP; 08 Jul 2019 16:12:40 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,468,1557212400\"; d=\"scan'208\";a=\"192484797\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Mon, 8 Jul 2019 16:12:26 -0700", "Message-Id": "<20190708231236.20516-10-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.22.0.214.g8dca754b1e87", "In-Reply-To": "<20190708231236.20516-1-jacob.e.keller@intel.com>", "References": "<20190708231236.20516-1-jacob.e.keller@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 09/19] fm10k: reduce the scope of the\n\tlocal msg variable", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The msg variable in the fm10k_mbx_validate_msg_size and\nfm10k_sm_mbx_transmit functions is only used within the do {} loop\nscope. Reduce its scope only to where it is used.\n\nThis was detected by cppcheck, and resolves the following warnings\nproduced by that tool:\n\n[fm10k_mbx.c:299]: (style) The scope of the variable 'msg' can be reduced.\n[fm10k_mbx.c:2004]: (style) The scope of the variable 'msg' can be reduced.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_mbx.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c b/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c\nindex 21021fe4f1c3..aece335b41f8 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c\n@@ -297,13 +297,14 @@ static u16 fm10k_mbx_validate_msg_size(struct fm10k_mbx_info *mbx, u16 len)\n {\n \tstruct fm10k_mbx_fifo *fifo = &mbx->rx;\n \tu16 total_len = 0, msg_len;\n-\tu32 *msg;\n \n \t/* length should include previous amounts pushed */\n \tlen += mbx->pushed;\n \n \t/* offset in message is based off of current message size */\n \tdo {\n+\t\tu32 *msg;\n+\n \t\tmsg = fifo->buffer + fm10k_fifo_tail_offset(fifo, total_len);\n \t\tmsg_len = FM10K_TLV_DWORD_LEN(*msg);\n \t\ttotal_len += msg_len;\n@@ -1920,7 +1921,6 @@ static void fm10k_sm_mbx_transmit(struct fm10k_hw *hw,\n \t/* reduce length by 1 to convert to a mask */\n \tu16 mbmem_len = mbx->mbmem_len - 1;\n \tu16 tail_len, len = 0;\n-\tu32 *msg;\n \n \t/* push head behind tail */\n \tif (mbx->tail < head)\n@@ -1930,6 +1930,8 @@ static void fm10k_sm_mbx_transmit(struct fm10k_hw *hw,\n \n \t/* determine msg aligned offset for end of buffer */\n \tdo {\n+\t\tu32 *msg;\n+\n \t\tmsg = fifo->buffer + fm10k_fifo_head_offset(fifo, len);\n \t\ttail_len = len;\n \t\tlen += FM10K_TLV_DWORD_LEN(*msg);\n", "prefixes": [ "09/19" ] }