Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1129407/?format=api
{ "id": 1129407, "url": "http://patchwork.ozlabs.org/api/patches/1129407/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190708231236.20516-18-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190708231236.20516-18-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2019-07-08T23:12:34", "name": "[17/19] fm10k: mark unused parameters with __always_unused", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "87ca93c00b28aa17acc44506d2981466c1d6707d", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190708231236.20516-18-jacob.e.keller@intel.com/mbox/", "series": [ { "id": 118423, "url": "http://patchwork.ozlabs.org/api/series/118423/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=118423", "date": "2019-07-08T23:12:19", "name": "cleanup cppcheck warnings for fm10k driver", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/118423/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1129407/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1129407/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45jLp941QQz9s3Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 9 Jul 2019 09:12:48 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A3E68865C4;\n\tMon, 8 Jul 2019 23:12:46 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id rmoNPyC4BxUS; Mon, 8 Jul 2019 23:12:44 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 017F8866A3;\n\tMon, 8 Jul 2019 23:12:44 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 422EB1BF46A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 23:12:42 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3CDB286566\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 23:12:42 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id h-HcawZy2+Wt for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 23:12:41 +0000 (UTC)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 18661865C4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 23:12:41 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Jul 2019 16:12:41 -0700", "from jekeller-desk.amr.corp.intel.com ([10.166.244.172])\n\tby fmsmga002.fm.intel.com with ESMTP; 08 Jul 2019 16:12:40 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,468,1557212400\"; d=\"scan'208\";a=\"192484825\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Mon, 8 Jul 2019 16:12:34 -0700", "Message-Id": "<20190708231236.20516-18-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.22.0.214.g8dca754b1e87", "In-Reply-To": "<20190708231236.20516-1-jacob.e.keller@intel.com>", "References": "<20190708231236.20516-1-jacob.e.keller@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 17/19] fm10k: mark unused parameters with\n\t__always_unused", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Several functions in the fm10k driver have specific function templates,\nas they are used as function pointers. The parameters in these functions\nare not always used. Explicitly mark unused parameters with the\n__always_unused macro, so that the compiler will not warn about them\nwhen building with the -Wunused-parameter warning enabled.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_mbx.c | 5 ++--\n drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 10 ++++----\n drivers/net/ethernet/intel/fm10k/fm10k_tlv.c | 7 +++---\n drivers/net/ethernet/intel/fm10k/fm10k_type.h | 2 +-\n drivers/net/ethernet/intel/fm10k/fm10k_vf.c | 25 +++++++++++--------\n 5 files changed, 28 insertions(+), 21 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c b/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c\nindex aece335b41f8..75e51f91036c 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c\n@@ -1,5 +1,5 @@\n // SPDX-License-Identifier: GPL-2.0\n-/* Copyright(c) 2013 - 2018 Intel Corporation. */\n+/* Copyright(c) 2013 - 2019 Intel Corporation. */\n \n #include \"fm10k_common.h\"\n \n@@ -2134,7 +2134,8 @@ static s32 fm10k_sm_mbx_process(struct fm10k_hw *hw,\n * DWORDs, not bytes. Any invalid values will cause the mailbox to return\n * error.\n **/\n-s32 fm10k_sm_mbx_init(struct fm10k_hw *hw, struct fm10k_mbx_info *mbx,\n+s32 fm10k_sm_mbx_init(struct fm10k_hw __always_unused *hw,\n+\t\t struct fm10k_mbx_info *mbx,\n \t\t const struct fm10k_msg_data *msg_data)\n {\n \tmbx->mbx_reg = FM10K_GMBX;\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pf.c b/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\nindex e85b2f2eef05..095c5b0e4096 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pf.c\n@@ -1,5 +1,5 @@\n // SPDX-License-Identifier: GPL-2.0\n-/* Copyright(c) 2013 - 2018 Intel Corporation. */\n+/* Copyright(c) 2013 - 2019 Intel Corporation. */\n \n #include \"fm10k_pf.h\"\n #include \"fm10k_vf.h\"\n@@ -1152,7 +1152,7 @@ static void fm10k_iov_update_stats_pf(struct fm10k_hw *hw,\n * assumption is that in this case it is acceptable to just directly\n * hand off the message from the VF to the underlying shared code.\n **/\n-s32 fm10k_iov_msg_msix_pf(struct fm10k_hw *hw, u32 **results,\n+s32 fm10k_iov_msg_msix_pf(struct fm10k_hw *hw, u32 __always_unused **results,\n \t\t\t struct fm10k_mbx_info *mbx)\n {\n \tstruct fm10k_vf_info *vf_info = (struct fm10k_vf_info *)mbx;\n@@ -1641,7 +1641,7 @@ const struct fm10k_tlv_attr fm10k_lport_map_msg_attr[] = {\n * switch API.\n **/\n s32 fm10k_msg_lport_map_pf(struct fm10k_hw *hw, u32 **results,\n-\t\t\t struct fm10k_mbx_info *mbx)\n+\t\t\t struct fm10k_mbx_info __always_unused *mbx)\n {\n \tu16 glort, mask;\n \tu32 dglort_map;\n@@ -1684,7 +1684,7 @@ const struct fm10k_tlv_attr fm10k_update_pvid_msg_attr[] = {\n * This handler configures the default VLAN for the PF\n **/\n static s32 fm10k_msg_update_pvid_pf(struct fm10k_hw *hw, u32 **results,\n-\t\t\t\t struct fm10k_mbx_info *mbx)\n+\t\t\t\t struct fm10k_mbx_info __always_unused *mbx)\n {\n \tu16 glort, pvid;\n \tu32 pvid_update;\n@@ -1745,7 +1745,7 @@ const struct fm10k_tlv_attr fm10k_err_msg_attr[] = {\n * messages that the PF has sent.\n **/\n s32 fm10k_msg_err_pf(struct fm10k_hw *hw, u32 **results,\n-\t\t struct fm10k_mbx_info *mbx)\n+\t\t struct fm10k_mbx_info __always_unused *mbx)\n {\n \tstruct fm10k_swapi_error err_msg;\n \ts32 err;\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_tlv.c b/drivers/net/ethernet/intel/fm10k/fm10k_tlv.c\nindex f4c42a40f934..21eff0895a7a 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_tlv.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_tlv.c\n@@ -1,5 +1,5 @@\n // SPDX-License-Identifier: GPL-2.0\n-/* Copyright(c) 2013 - 2018 Intel Corporation. */\n+/* Copyright(c) 2013 - 2019 Intel Corporation. */\n \n #include \"fm10k_tlv.h\"\n \n@@ -587,8 +587,9 @@ s32 fm10k_tlv_msg_parse(struct fm10k_hw *hw, u32 *msg,\n * a minimum it just indicates that the message requested was\n * unimplemented.\n **/\n-s32 fm10k_tlv_msg_error(struct fm10k_hw *hw, u32 **results,\n-\t\t\tstruct fm10k_mbx_info *mbx)\n+s32 fm10k_tlv_msg_error(struct fm10k_hw __always_unused *hw,\n+\t\t\tu32 __always_unused **results,\n+\t\t\tstruct fm10k_mbx_info __always_unused *mbx)\n {\n \treturn FM10K_NOT_IMPLEMENTED;\n }\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_type.h b/drivers/net/ethernet/intel/fm10k/fm10k_type.h\nindex 9fb9fca375e3..15ac1c7885bc 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_type.h\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_type.h\n@@ -1,5 +1,5 @@\n /* SPDX-License-Identifier: GPL-2.0 */\n-/* Copyright(c) 2013 - 2018 Intel Corporation. */\n+/* Copyright(c) 2013 - 2019 Intel Corporation. */\n \n #ifndef _FM10K_TYPE_H_\n #define _FM10K_TYPE_H_\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_vf.c b/drivers/net/ethernet/intel/fm10k/fm10k_vf.c\nindex a8519c1f0406..dc8ccd378ec9 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_vf.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_vf.c\n@@ -1,5 +1,5 @@\n // SPDX-License-Identifier: GPL-2.0\n-/* Copyright(c) 2013 - 2018 Intel Corporation. */\n+/* Copyright(c) 2013 - 2019 Intel Corporation. */\n \n #include \"fm10k_vf.h\"\n \n@@ -198,7 +198,7 @@ static s32 fm10k_update_vlan_vf(struct fm10k_hw *hw, u32 vid, u8 vsi, bool set)\n * This function should determine the MAC address for the VF\n **/\n s32 fm10k_msg_mac_vlan_vf(struct fm10k_hw *hw, u32 **results,\n-\t\t\t struct fm10k_mbx_info *mbx)\n+\t\t\t struct fm10k_mbx_info __always_unused *mbx)\n {\n \tu8 perm_addr[ETH_ALEN];\n \tu16 vid;\n@@ -267,8 +267,10 @@ static s32 fm10k_read_mac_addr_vf(struct fm10k_hw *hw)\n * This function is used to add or remove unicast MAC addresses for\n * the VF.\n **/\n-static s32 fm10k_update_uc_addr_vf(struct fm10k_hw *hw, u16 glort,\n-\t\t\t\t const u8 *mac, u16 vid, bool add, u8 flags)\n+static s32 fm10k_update_uc_addr_vf(struct fm10k_hw *hw,\n+\t\t\t\t u16 __always_unused glort,\n+\t\t\t\t const u8 *mac, u16 vid, bool add,\n+\t\t\t\t u8 __always_unused flags)\n {\n \tstruct fm10k_mbx_info *mbx = &hw->mbx;\n \tu32 msg[7];\n@@ -309,7 +311,8 @@ static s32 fm10k_update_uc_addr_vf(struct fm10k_hw *hw, u16 glort,\n * This function is used to add or remove multicast MAC addresses for\n * the VF.\n **/\n-static s32 fm10k_update_mc_addr_vf(struct fm10k_hw *hw, u16 glort,\n+static s32 fm10k_update_mc_addr_vf(struct fm10k_hw *hw,\n+\t\t\t\t u16 __always_unused glort,\n \t\t\t\t const u8 *mac, u16 vid, bool add)\n {\n \tstruct fm10k_mbx_info *mbx = &hw->mbx;\n@@ -373,7 +376,7 @@ const struct fm10k_tlv_attr fm10k_lport_state_msg_attr[] = {\n * are ready to bring up the interface.\n **/\n s32 fm10k_msg_lport_state_vf(struct fm10k_hw *hw, u32 **results,\n-\t\t\t struct fm10k_mbx_info *mbx)\n+\t\t\t struct fm10k_mbx_info __always_unused *mbx)\n {\n \thw->mac.dglort_map = !results[FM10K_LPORT_STATE_MSG_READY] ?\n \t\t\t FM10K_DGLORTMAP_NONE : FM10K_DGLORTMAP_ZERO;\n@@ -392,8 +395,9 @@ s32 fm10k_msg_lport_state_vf(struct fm10k_hw *hw, u32 **results,\n * enabled we can add filters, if it is disabled all filters for this\n * logical port are flushed.\n **/\n-static s32 fm10k_update_lport_state_vf(struct fm10k_hw *hw, u16 glort,\n-\t\t\t\t u16 count, bool enable)\n+static s32 fm10k_update_lport_state_vf(struct fm10k_hw *hw,\n+\t\t\t\t u16 __always_unused glort,\n+\t\t\t\t u16 __always_unused count, bool enable)\n {\n \tstruct fm10k_mbx_info *mbx = &hw->mbx;\n \tu32 msg[2];\n@@ -420,7 +424,8 @@ static s32 fm10k_update_lport_state_vf(struct fm10k_hw *hw, u16 glort,\n * so that it can enable either multicast, multicast promiscuous, or\n * promiscuous mode of operation.\n **/\n-static s32 fm10k_update_xcast_mode_vf(struct fm10k_hw *hw, u16 glort, u8 mode)\n+static s32 fm10k_update_xcast_mode_vf(struct fm10k_hw *hw,\n+\t\t\t\t u16 __always_unused glort, u8 mode)\n {\n \tstruct fm10k_mbx_info *mbx = &hw->mbx;\n \tu32 msg[3];\n@@ -475,7 +480,7 @@ static void fm10k_rebind_hw_stats_vf(struct fm10k_hw *hw,\n * that information to then populate a DGLORTMAP/DEC entry and the queues\n * to which it has been assigned.\n **/\n-static s32 fm10k_configure_dglort_map_vf(struct fm10k_hw *hw,\n+static s32 fm10k_configure_dglort_map_vf(struct fm10k_hw __always_unused *hw,\n \t\t\t\t\t struct fm10k_dglort_cfg *dglort)\n {\n \t/* verify the dglort pointer */\n", "prefixes": [ "17/19" ] }