Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1128878/?format=api
{ "id": 1128878, "url": "http://patchwork.ozlabs.org/api/patches/1128878/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190708045546.30160-2-kai.heng.feng@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190708045546.30160-2-kai.heng.feng@canonical.com>", "list_archive_url": null, "date": "2019-07-08T04:55:46", "name": "[2/2] e1000e: disable force K1-off feature", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "2edf6f9fc74535ad10dd6d671ff28af6697b06be", "submitter": { "id": 70328, "url": "http://patchwork.ozlabs.org/api/people/70328/?format=api", "name": "Kai-Heng Feng", "email": "kai.heng.feng@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190708045546.30160-2-kai.heng.feng@canonical.com/mbox/", "series": [ { "id": 118238, "url": "http://patchwork.ozlabs.org/api/series/118238/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=118238", "date": "2019-07-08T04:55:46", "name": null, "version": 1, "mbox": "http://patchwork.ozlabs.org/series/118238/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1128878/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1128878/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=fail (p=none dis=none)\n\theader.from=canonical.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45htSg2Scvz9sNs\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 8 Jul 2019 14:56:02 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 891FA20514;\n\tMon, 8 Jul 2019 04:56:00 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id MAWphitklN-k; Mon, 8 Jul 2019 04:55:58 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7F681204F7;\n\tMon, 8 Jul 2019 04:55:58 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 81BDC1BF337\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 04:55:57 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7E6B7847B8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 04:55:57 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1Bjo8QjTaVs2 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 04:55:56 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id A82AF82731\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 8 Jul 2019 04:55:56 +0000 (UTC)", "from 61-220-137-37.hinet-ip.hinet.net ([61.220.137.37]\n\thelo=localhost) by youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <kai.heng.feng@canonical.com>)\n\tid 1hkLgw-000317-8W; Mon, 08 Jul 2019 04:55:54 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Kai-Heng Feng <kai.heng.feng@canonical.com>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Mon, 8 Jul 2019 12:55:46 +0800", "Message-Id": "<20190708045546.30160-2-kai.heng.feng@canonical.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190708045546.30160-1-kai.heng.feng@canonical.com>", "References": "<20190708045546.30160-1-kai.heng.feng@canonical.com>", "Subject": "[Intel-wired-lan] [PATCH 2/2] e1000e: disable force K1-off feature", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Kai-Heng Feng <kai.heng.feng@canonical.com>, netdev@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Forwardport from http://mails.dpdk.org/archives/dev/2016-November/050658.html\n\nMAC-PHY desync may occur causing misdetection of link up event.\nDisabling K1-off feature can work around the problem.\n\nBugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204057\n\nSigned-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>\n---\n drivers/net/ethernet/intel/e1000e/hw.h | 1 +\n drivers/net/ethernet/intel/e1000e/ich8lan.c | 3 +++\n 2 files changed, 4 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/hw.h b/drivers/net/ethernet/intel/e1000e/hw.h\nindex eff75bd8a8f0..e3c71fd093ee 100644\n--- a/drivers/net/ethernet/intel/e1000e/hw.h\n+++ b/drivers/net/ethernet/intel/e1000e/hw.h\n@@ -662,6 +662,7 @@ struct e1000_dev_spec_ich8lan {\n \tbool kmrn_lock_loss_workaround_enabled;\n \tstruct e1000_shadow_ram shadow_ram[E1000_ICH8_SHADOW_RAM_WORDS];\n \tbool nvm_k1_enabled;\n+\tbool disable_k1_off;\n \tbool eee_disable;\n \tu16 eee_lp_ability;\n \tenum e1000_ulp_state ulp_state;\ndiff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c\nindex 56f88a4e538c..c1e0e03dc5cb 100644\n--- a/drivers/net/ethernet/intel/e1000e/ich8lan.c\n+++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c\n@@ -1538,6 +1538,9 @@ static s32 e1000_check_for_copper_link_ich8lan(struct e1000_hw *hw)\n \t\t\t\tfextnvm6 &= ~E1000_FEXTNVM6_K1_OFF_ENABLE;\n \t\t}\n \n+\t\tif (hw->dev_spec.ich8lan.disable_k1_off == true)\n+\t\t\tfextnvm6 &= ~E1000_FEXTNVM6_K1_OFF_ENABLE;\n+\n \t\tew32(FEXTNVM6, fextnvm6);\n \t}\n \n", "prefixes": [ "2/2" ] }