Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1126497/?format=api
{ "id": 1126497, "url": "http://patchwork.ozlabs.org/api/patches/1126497/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190702122259.79070-1-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190702122259.79070-1-alice.michael@intel.com>", "list_archive_url": null, "date": "2019-07-02T12:22:51", "name": "[next,S7,1/9] i40e: fix incorrect ethtool statistics veb and veb.tc_", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6de6a0e9e365e9297fa94926db311bfdc6891c6c", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190702122259.79070-1-alice.michael@intel.com/mbox/", "series": [ { "id": 117390, "url": "http://patchwork.ozlabs.org/api/series/117390/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=117390", "date": "2019-07-02T12:22:53", "name": "[next,S7,1/9] i40e: fix incorrect ethtool statistics veb and veb.tc_", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/117390/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1126497/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1126497/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45dbmm4tbHz9s00\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 3 Jul 2019 06:43:36 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3A66886DF3;\n\tTue, 2 Jul 2019 20:43:35 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 2GCt52mnexyP; Tue, 2 Jul 2019 20:43:31 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id D31C28672C;\n\tTue, 2 Jul 2019 20:43:31 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2A6471BF589\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 Jul 2019 20:43:31 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2765587CCB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 Jul 2019 20:43:31 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lggRFH78rbVX for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 Jul 2019 20:43:21 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 335DD879FD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 Jul 2019 20:43:21 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 02 Jul 2019 13:43:20 -0700", "from alicemic-1.jf.intel.com ([10.166.17.62])\n\tby fmsmga002.fm.intel.com with ESMTP; 02 Jul 2019 13:43:20 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,444,1557212400\"; d=\"scan'208\";a=\"190805448\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Tue, 2 Jul 2019 08:22:51 -0400", "Message-Id": "<20190702122259.79070-1-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S7 1/9] i40e: fix incorrect ethtool\n\tstatistics veb and veb.tc_", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Dmitrii Golovanov <dmitrii.golovanov@intel.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Dmitrii Golovanov <dmitrii.golovanov@intel.com>\n\nThis patch fixes missing call of i40e_update_veb_stats() in function\ni40e_get_ethtool_stats() to update stats data of VEB and VEB TC\ncounters before they are written into ethtool buffer.\nBefore the patch ethtool counters may fell behind interface counters.\n\nSigned-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e.h | 1 +\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 8 +++++++-\n drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-\n 3 files changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h\nindex 84bd06901014..3e535d3263b3 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e.h\n@@ -1021,6 +1021,7 @@ i40e_find_vsi_by_type(struct i40e_pf *pf, u16 type)\n \treturn NULL;\n }\n void i40e_update_stats(struct i40e_vsi *vsi);\n+void i40e_update_veb_stats(struct i40e_veb *veb);\n void i40e_update_eth_stats(struct i40e_vsi *vsi);\n struct rtnl_link_stats64 *i40e_get_vsi_stats_struct(struct i40e_vsi *vsi);\n int i40e_fetch_switch_configuration(struct i40e_pf *pf,\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 527eb52c5401..65e016f54f58 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -2250,7 +2250,7 @@ static void i40e_get_ethtool_stats(struct net_device *netdev,\n \tstruct i40e_netdev_priv *np = netdev_priv(netdev);\n \tstruct i40e_vsi *vsi = np->vsi;\n \tstruct i40e_pf *pf = vsi->back;\n-\tstruct i40e_veb *veb = pf->veb[pf->lan_veb];\n+\tstruct i40e_veb *veb = NULL;\n \tunsigned int i;\n \tbool veb_stats;\n \tu64 *p = data;\n@@ -2273,8 +2273,14 @@ static void i40e_get_ethtool_stats(struct net_device *netdev,\n \t\tgoto check_data_pointer;\n \n \tveb_stats = ((pf->lan_veb != I40E_NO_VEB) &&\n+\t\t (pf->lan_veb < I40E_MAX_VEB) &&\n \t\t (pf->flags & I40E_FLAG_VEB_STATS_ENABLED));\n \n+\tif (veb_stats) {\n+\t\tveb = pf->veb[pf->lan_veb];\n+\t\ti40e_update_veb_stats(veb);\n+\t}\n+\n \t/* If veb stats aren't enabled, pass NULL instead of the veb so that\n \t * we initialize stats to zero and update the data pointer\n \t * intelligently\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 5361c08328f7..8dac7a87834d 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -677,7 +677,7 @@ void i40e_update_eth_stats(struct i40e_vsi *vsi)\n * i40e_update_veb_stats - Update Switch component statistics\n * @veb: the VEB being updated\n **/\n-static void i40e_update_veb_stats(struct i40e_veb *veb)\n+void i40e_update_veb_stats(struct i40e_veb *veb)\n {\n \tstruct i40e_pf *pf = veb->pf;\n \tstruct i40e_hw *hw = &pf->hw;\n", "prefixes": [ "next", "S7", "1/9" ] }