Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1126496/?format=api
{ "id": 1126496, "url": "http://patchwork.ozlabs.org/api/patches/1126496/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190702122259.79070-6-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190702122259.79070-6-alice.michael@intel.com>", "list_archive_url": null, "date": "2019-07-02T12:22:56", "name": "[next,S7,6/9] i40e: Update visual effect for advertised FEC mode.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0fce5639ac393d361e3cbe6f987d0274c1d494be", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190702122259.79070-6-alice.michael@intel.com/mbox/", "series": [ { "id": 117390, "url": "http://patchwork.ozlabs.org/api/series/117390/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=117390", "date": "2019-07-02T12:22:53", "name": "[next,S7,1/9] i40e: fix incorrect ethtool statistics veb and veb.tc_", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/117390/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1126496/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1126496/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45dbmg4JfMz9s4Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 3 Jul 2019 06:43:31 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 2DA9585F4B;\n\tTue, 2 Jul 2019 20:43:30 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id t0_dVyTFYmF8; Tue, 2 Jul 2019 20:43:28 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6080885EF1;\n\tTue, 2 Jul 2019 20:43:28 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 30F701BF589\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 Jul 2019 20:43:26 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2B70287CDB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 Jul 2019 20:43:26 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id gY8PODDkQGIR for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 Jul 2019 20:43:22 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 791B587B6D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 Jul 2019 20:43:22 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 02 Jul 2019 13:43:21 -0700", "from alicemic-1.jf.intel.com ([10.166.17.62])\n\tby fmsmga002.fm.intel.com with ESMTP; 02 Jul 2019 13:43:21 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,444,1557212400\"; d=\"scan'208\";a=\"190805464\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Tue, 2 Jul 2019 08:22:56 -0400", "Message-Id": "<20190702122259.79070-6-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190702122259.79070-1-alice.michael@intel.com>", "References": "<20190702122259.79070-1-alice.michael@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S7 6/9] i40e: Update visual effect\n\tfor advertised FEC mode.", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Czeslaw Zagorski <czeslawx.zagorski@intel.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Czeslaw Zagorski <czeslawx.zagorski@intel.com>\n\nUpdates visual effect for advertised mode after setting desired mode.\nThe mode appears in advertised FEC mode correctly, when ethtool\ninterface command is called. Without this commit advertised FEC\nis displayed regardless of the settings as \"None BaseR RS\".\n\nSigned-off-by: Czeslaw Zagorski <czeslawx.zagorski@intel.com>\n---\n .../net/ethernet/intel/i40e/i40e_ethtool.c | 63 ++++++++++---------\n 1 file changed, 35 insertions(+), 28 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 65e016f54f58..663de4fd7bbe 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -710,6 +710,35 @@ static void i40e_phy_type_to_ethtool(struct i40e_pf *pf,\n \t}\n }\n \n+/**\n+ * i40e_get_settings_link_up_fec - Get the FEC mode encoding from mask\n+ * @req_fec_info: mask request fec info\n+ * @ks: ethtool ksettings to fill in\n+ **/\n+static void i40e_get_settings_link_up_fec(u8 req_fec_info,\n+\t\t\t\t\t struct ethtool_link_ksettings *ks)\n+{\n+\tethtool_link_ksettings_add_link_mode(ks, supported, FEC_NONE);\n+\tethtool_link_ksettings_add_link_mode(ks, supported, FEC_RS);\n+\tethtool_link_ksettings_add_link_mode(ks, supported, FEC_BASER);\n+\n+\tif (I40E_AQ_SET_FEC_REQUEST_RS & req_fec_info) {\n+\t\tethtool_link_ksettings_add_link_mode(ks, advertising, FEC_RS);\n+\t} else if (I40E_AQ_SET_FEC_REQUEST_KR & req_fec_info) {\n+\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n+\t\t\t\t\t\t FEC_BASER);\n+\t} else {\n+\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n+\t\t\t\t\t\t FEC_NONE);\n+\t\tif (I40E_AQ_SET_FEC_AUTO & req_fec_info) {\n+\t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n+\t\t\t\t\t\t\t FEC_RS);\n+\t\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n+\t\t\t\t\t\t\t FEC_BASER);\n+\t\t}\n+\t}\n+}\n+\n /**\n * i40e_get_settings_link_up - Get the Link settings for when link is up\n * @hw: hw structure\n@@ -769,13 +798,7 @@ static void i40e_get_settings_link_up(struct i40e_hw *hw,\n \t\t\t\t\t\t 25000baseSR_Full);\n \t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t 25000baseSR_Full);\n-\t\tethtool_link_ksettings_add_link_mode(ks, supported, FEC_NONE);\n-\t\tethtool_link_ksettings_add_link_mode(ks, supported, FEC_RS);\n-\t\tethtool_link_ksettings_add_link_mode(ks, supported, FEC_BASER);\n-\t\tethtool_link_ksettings_add_link_mode(ks, advertising, FEC_NONE);\n-\t\tethtool_link_ksettings_add_link_mode(ks, advertising, FEC_RS);\n-\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n-\t\t\t\t\t\t FEC_BASER);\n+\t\ti40e_get_settings_link_up_fec(hw_link_info->req_fec_info, ks);\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 10000baseSR_Full);\n \t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n@@ -892,9 +915,6 @@ static void i40e_get_settings_link_up(struct i40e_hw *hw,\n \t\t\t\t\t\t 40000baseKR4_Full);\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 25000baseKR_Full);\n-\t\tethtool_link_ksettings_add_link_mode(ks, supported, FEC_NONE);\n-\t\tethtool_link_ksettings_add_link_mode(ks, supported, FEC_RS);\n-\t\tethtool_link_ksettings_add_link_mode(ks, supported, FEC_BASER);\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 20000baseKR2_Full);\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n@@ -908,10 +928,7 @@ static void i40e_get_settings_link_up(struct i40e_hw *hw,\n \t\t\t\t\t\t 40000baseKR4_Full);\n \t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t 25000baseKR_Full);\n-\t\tethtool_link_ksettings_add_link_mode(ks, advertising, FEC_NONE);\n-\t\tethtool_link_ksettings_add_link_mode(ks, advertising, FEC_RS);\n-\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n-\t\t\t\t\t\t FEC_BASER);\n+\t\ti40e_get_settings_link_up_fec(hw_link_info->req_fec_info, ks);\n \t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t 20000baseKR2_Full);\n \t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n@@ -929,13 +946,8 @@ static void i40e_get_settings_link_up(struct i40e_hw *hw,\n \t\t\t\t\t\t 25000baseCR_Full);\n \t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t 25000baseCR_Full);\n-\t\tethtool_link_ksettings_add_link_mode(ks, supported, FEC_NONE);\n-\t\tethtool_link_ksettings_add_link_mode(ks, supported, FEC_RS);\n-\t\tethtool_link_ksettings_add_link_mode(ks, supported, FEC_BASER);\n-\t\tethtool_link_ksettings_add_link_mode(ks, advertising, FEC_NONE);\n-\t\tethtool_link_ksettings_add_link_mode(ks, advertising, FEC_RS);\n-\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n-\t\t\t\t\t\t FEC_BASER);\n+\t\ti40e_get_settings_link_up_fec(hw_link_info->req_fec_info, ks);\n+\n \t\tbreak;\n \tcase I40E_PHY_TYPE_25GBASE_AOC:\n \tcase I40E_PHY_TYPE_25GBASE_ACC:\n@@ -945,13 +957,8 @@ static void i40e_get_settings_link_up(struct i40e_hw *hw,\n \t\t\t\t\t\t 25000baseCR_Full);\n \t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n \t\t\t\t\t\t 25000baseCR_Full);\n-\t\tethtool_link_ksettings_add_link_mode(ks, supported, FEC_NONE);\n-\t\tethtool_link_ksettings_add_link_mode(ks, supported, FEC_RS);\n-\t\tethtool_link_ksettings_add_link_mode(ks, supported, FEC_BASER);\n-\t\tethtool_link_ksettings_add_link_mode(ks, advertising, FEC_NONE);\n-\t\tethtool_link_ksettings_add_link_mode(ks, advertising, FEC_RS);\n-\t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n-\t\t\t\t\t\t FEC_BASER);\n+\t\ti40e_get_settings_link_up_fec(hw_link_info->req_fec_info, ks);\n+\n \t\tethtool_link_ksettings_add_link_mode(ks, supported,\n \t\t\t\t\t\t 10000baseCR_Full);\n \t\tethtool_link_ksettings_add_link_mode(ks, advertising,\n", "prefixes": [ "next", "S7", "6/9" ] }