Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1124636/?format=api
{ "id": 1124636, "url": "http://patchwork.ozlabs.org/api/patches/1124636/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190628150348.59202-1-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190628150348.59202-1-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2019-06-28T15:03:48", "name": "[S23,v2,14/15] ice: Change type for queue counts", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4941e12928309ee0070592cbfc27095b7d68041f", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190628150348.59202-1-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 116826, "url": "http://patchwork.ozlabs.org/api/series/116826/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=116826", "date": "2019-06-28T15:03:48", "name": null, "version": 2, "mbox": "http://patchwork.ozlabs.org/series/116826/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1124636/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1124636/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45bChH3DVRz9s3l\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 29 Jun 2019 09:31:27 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 05E3086880;\n\tFri, 28 Jun 2019 23:31:26 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mtRLA9hfZE-H; Fri, 28 Jun 2019 23:31:24 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 035CF8685A;\n\tFri, 28 Jun 2019 23:31:24 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7862F1BF2E3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 28 Jun 2019 23:31:22 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 74DAD22851\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 28 Jun 2019 23:31:22 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 26aLxdpsNtAH for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 28 Jun 2019 23:31:17 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby silver.osuosl.org (Postfix) with ESMTPS id E88EF22854\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 28 Jun 2019 23:31:16 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Jun 2019 16:31:16 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby orsmga001.jf.intel.com with ESMTP; 28 Jun 2019 16:31:15 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,429,1557212400\"; d=\"scan'208\";a=\"246314741\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 28 Jun 2019 08:03:48 -0700", "Message-Id": "<20190628150348.59202-1-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S23 v2 14/15] ice: Change type for queue\n\tcounts", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "pmenzel@molgen.mpg.de", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Pawel Kaminski <pawel.kaminski@intel.com>\n\nA negative queue count should never exist, change the type to unsigned\nto convey that.\n\nSigned-off-by: Pawel Kaminski <pawel.kaminski@intel.com>\n---\nv2: Change type from u16 to unsigned int\n Reword commit message\n\n drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\nindex f2ebbe83ae4c..b8fc08c1d365 100644\n--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n@@ -2339,11 +2339,11 @@ static int ice_vc_request_qs_msg(struct ice_vf *vf, u8 *msg)\n \tenum virtchnl_status_code v_ret = VIRTCHNL_STATUS_SUCCESS;\n \tstruct virtchnl_vf_res_request *vfres =\n \t\t(struct virtchnl_vf_res_request *)msg;\n-\tint req_queues = vfres->num_queue_pairs;\n+\tunsigned int req_queues = vfres->num_queue_pairs;\n+\tunsigned int max_allowed_vf_queues;\n+\tunsigned int tx_rx_queue_left;\n \tstruct ice_pf *pf = vf->pf;\n-\tint max_allowed_vf_queues;\n-\tint tx_rx_queue_left;\n-\tint cur_queues;\n+\tunsigned int cur_queues;\n \n \tif (!test_bit(ICE_VF_STATE_ACTIVE, vf->vf_states)) {\n \t\tv_ret = VIRTCHNL_STATUS_ERR_PARAM;\n@@ -2353,10 +2353,10 @@ static int ice_vc_request_qs_msg(struct ice_vf *vf, u8 *msg)\n \tcur_queues = vf->num_vf_qs;\n \ttx_rx_queue_left = min_t(int, pf->q_left_tx, pf->q_left_rx);\n \tmax_allowed_vf_queues = tx_rx_queue_left + cur_queues;\n-\tif (req_queues <= 0) {\n+\tif (!req_queues) {\n \t\tdev_err(&pf->pdev->dev,\n-\t\t\t\"VF %d tried to request %d queues. Ignoring.\\n\",\n-\t\t\tvf->vf_id, req_queues);\n+\t\t\t\"VF %d tried to request 0 queues. Ignoring.\\n\",\n+\t\t\tvf->vf_id);\n \t} else if (req_queues > ICE_MAX_BASE_QS_PER_VF) {\n \t\tdev_err(&pf->pdev->dev,\n \t\t\t\"VF %d tried to request more than %d queues.\\n\",\n", "prefixes": [ "S23", "v2", "14/15" ] }