Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1122373/?format=api
{ "id": 1122373, "url": "http://patchwork.ozlabs.org/api/patches/1122373/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1561500439-30276-2-git-send-email-vedang.patel@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1561500439-30276-2-git-send-email-vedang.patel@intel.com>", "list_archive_url": null, "date": "2019-06-25T22:07:12", "name": "[net-next,v6,1/8] igb: clear out skb->tstamp after reading the txtime", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6a49254e74e8086b6c454bcd73ae4735edd57472", "submitter": { "id": 76208, "url": "http://patchwork.ozlabs.org/api/people/76208/?format=api", "name": "Vedang Patel", "email": "vedang.patel@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1561500439-30276-2-git-send-email-vedang.patel@intel.com/mbox/", "series": [ { "id": 116115, "url": "http://patchwork.ozlabs.org/api/series/116115/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=116115", "date": "2019-06-25T22:07:11", "name": "net/sched: Add txtime-assist support for taprio.", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/116115/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1122373/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1122373/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45YLfH6lwyz9s4V\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 26 Jun 2019 08:38:15 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4C9E486566;\n\tTue, 25 Jun 2019 22:38:14 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6Nku-y1GMexm; Tue, 25 Jun 2019 22:38:11 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C000386569;\n\tTue, 25 Jun 2019 22:38:09 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8FC021BF38E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 25 Jun 2019 22:07:27 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8C7C985F53\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 25 Jun 2019 22:07:27 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 7O7vy0nRuebc for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 25 Jun 2019 22:07:27 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 1A8CE85F4C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 25 Jun 2019 22:07:27 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jun 2019 15:07:27 -0700", "from vpatel-desk.jf.intel.com (HELO localhost.localdomain)\n\t([10.7.159.52])\n\tby orsmga002.jf.intel.com with ESMTP; 25 Jun 2019 15:07:26 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,417,1557212400\"; d=\"scan'208\";a=\"172511934\"", "From": "Vedang Patel <vedang.patel@intel.com>", "To": "netdev@vger.kernel.org", "Date": "Tue, 25 Jun 2019 15:07:12 -0700", "Message-Id": "<1561500439-30276-2-git-send-email-vedang.patel@intel.com>", "X-Mailer": "git-send-email 2.7.3", "In-Reply-To": "<1561500439-30276-1-git-send-email-vedang.patel@intel.com>", "References": "<1561500439-30276-1-git-send-email-vedang.patel@intel.com>", "X-Mailman-Approved-At": "Tue, 25 Jun 2019 22:38:08 +0000", "Subject": "[Intel-wired-lan] [PATCH net-next v6 1/8] igb: clear out\n\tskb->tstamp after reading the txtime", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "jiri@resnulli.us, l@dorileo.org, sergei.shtylyov@cogentembedded.com,\n\tjakub.kicinski@netronome.com, jhs@mojatatu.com, m-karicheri2@ti.com, \n\tintel-wired-lan@lists.osuosl.org, xiyou.wangcong@gmail.com,\n\teric.dumazet@gmail.com, davem@davemloft.net", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "If a packet which is utilizing the launchtime feature (via SO_TXTIME socket\noption) also requests the hardware transmit timestamp, the hardware\ntimestamp is not delivered to the userspace. This is because the value in\nskb->tstamp is mistaken as the software timestamp.\n\nApplications, like ptp4l, request a hardware timestamp by setting the\nSOF_TIMESTAMPING_TX_HARDWARE socket option. Whenever a new timestamp is\ndetected by the driver (this work is done in igb_ptp_tx_work() which calls\nigb_ptp_tx_hwtstamps() in igb_ptp.c[1]), it will queue the timestamp in the\nERR_QUEUE for the userspace to read. When the userspace is ready, it will\nissue a recvmsg() call to collect this timestamp. The problem is in this\nrecvmsg() call. If the skb->tstamp is not cleared out, it will be\ninterpreted as a software timestamp and the hardware tx timestamp will not\nbe successfully sent to the userspace. Look at skb_is_swtx_tstamp() and the\ncallee function __sock_recv_timestamp() in net/socket.c for more details.\n\nSigned-off-by: Vedang Patel <vedang.patel@intel.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex fc925adbd9fa..f66dae72fe37 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -5688,6 +5688,7 @@ static void igb_tx_ctxtdesc(struct igb_ring *tx_ring,\n \t */\n \tif (tx_ring->launchtime_enable) {\n \t\tts = ns_to_timespec64(first->skb->tstamp);\n+\t\tfirst->skb->tstamp = 0;\n \t\tcontext_desc->seqnum_seed = cpu_to_le32(ts.tv_nsec / 32);\n \t} else {\n \t\tcontext_desc->seqnum_seed = 0;\n", "prefixes": [ "net-next", "v6", "1/8" ] }