Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1119/?format=api
{ "id": 1119, "url": "http://patchwork.ozlabs.org/api/patches/1119/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20080923083934.032d6098@extreme/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20080923083934.032d6098@extreme>", "list_archive_url": null, "date": "2008-09-23T15:39:34", "name": "[1/2] netdev: use const for some name functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "580de891bfa90545e6ac2ac822a45fb793be15f2", "submitter": { "id": 423, "url": "http://patchwork.ozlabs.org/api/people/423/?format=api", "name": "stephen hemminger", "email": "shemminger@vyatta.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20080923083934.032d6098@extreme/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/1119/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1119/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 9C855DE095\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 24 Sep 2008 01:47:05 +1000 (EST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751545AbYIWPrA (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 23 Sep 2008 11:47:00 -0400", "(majordomo@vger.kernel.org) by vger.kernel.org id S1751749AbYIWPq7\n\t(ORCPT <rfc822; netdev-outgoing>); Tue, 23 Sep 2008 11:46:59 -0400", "from mail.vyatta.com ([76.74.103.46]:52479 \"EHLO mail.vyatta.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751459AbYIWPq6 (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tTue, 23 Sep 2008 11:46:58 -0400", "from localhost (localhost.localdomain [127.0.0.1])\n\tby mail.vyatta.com (Postfix) with ESMTP id 389714F46AE;\n\tTue, 23 Sep 2008 08:46:57 -0700 (PDT)", "from mail.vyatta.com ([127.0.0.1])\n\tby localhost (mail.vyatta.com [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id rMeeM69F7ClI; Tue, 23 Sep 2008 08:46:55 -0700 (PDT)", "from extreme (pool-71-182-88-81.ptldor.fios.verizon.net\n\t[71.182.88.81])\n\tby mail.vyatta.com (Postfix) with ESMTP id 8730C4F46AC;\n\tTue, 23 Sep 2008 08:46:55 -0700 (PDT)" ], "X-Virus-Scanned": "amavisd-new at ", "Date": "Tue, 23 Sep 2008 08:39:34 -0700", "From": "Stephen Hemminger <shemminger@vyatta.com>", "To": "David Miller <davem@davemloft.net>", "Cc": "netdev@vger.kernel.org", "Subject": "[PATCH 1/2] netdev: use const for some name functions", "Message-ID": "<20080923083934.032d6098@extreme>", "Organization": "Vyatta", "X-Mailer": "Claws Mail 3.3.1 (GTK+ 2.12.9; x86_64-pc-linux-gnu)", "Mime-Version": "1.0", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "7bit", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "dev_change_name and netdev_drivername should use const char on parameters\nthat are read-only input values. The strcpy to newname is not needed since\nnewname is not used later in function.\n\nSigned-off-by: Stephen Hemminger <shemminger@vyatta.com>\n\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe netdev\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html", "diff": "--- a/include/linux/netdevice.h\t2008-09-23 08:29:15.000000000 -0700\n+++ b/include/linux/netdevice.h\t2008-09-23 08:29:16.000000000 -0700\n@@ -1225,7 +1225,7 @@ extern int\t\tdev_ioctl(struct net *net, u\n extern int\t\tdev_ethtool(struct net *net, struct ifreq *);\n extern unsigned\t\tdev_get_flags(const struct net_device *);\n extern int\t\tdev_change_flags(struct net_device *, unsigned);\n-extern int\t\tdev_change_name(struct net_device *, char *);\n+extern int\t\tdev_change_name(struct net_device *, const char *);\n extern int\t\tdev_set_alias(struct net_device *, const char *, size_t);\n extern int\t\tdev_change_net_namespace(struct net_device *,\n \t\t\t\t\t\t struct net *, const char *);\n@@ -1670,7 +1670,7 @@ extern void dev_seq_stop(struct seq_file\n extern int netdev_class_create_file(struct class_attribute *class_attr);\n extern void netdev_class_remove_file(struct class_attribute *class_attr);\n \n-extern char *netdev_drivername(struct net_device *dev, char *buffer, int len);\n+extern char *netdev_drivername(const struct net_device *dev, char *buffer, int len);\n \n extern void linkwatch_run_queue(void);\n \n--- a/net/core/dev.c\t2008-09-23 08:29:15.000000000 -0700\n+++ b/net/core/dev.c\t2008-09-23 08:32:48.000000000 -0700\n@@ -890,7 +890,7 @@ int dev_alloc_name(struct net_device *de\n *\tChange name of a device, can pass format strings \"eth%d\".\n *\tfor wildcarding.\n */\n-int dev_change_name(struct net_device *dev, char *newname)\n+int dev_change_name(struct net_device *dev, const char *newname)\n {\n \tchar oldname[IFNAMSIZ];\n \tint err = 0;\n@@ -916,7 +916,6 @@ int dev_change_name(struct net_device *d\n \t\terr = dev_alloc_name(dev, newname);\n \t\tif (err < 0)\n \t\t\treturn err;\n-\t\tstrcpy(newname, dev->name);\n \t}\n \telse if (__dev_get_by_name(net, newname))\n \t\treturn -EEXIST;\n@@ -4746,10 +4745,10 @@ err_name:\n \treturn -ENOMEM;\n }\n \n-char *netdev_drivername(struct net_device *dev, char *buffer, int len)\n+char *netdev_drivername(const struct net_device *dev, char *buffer, int len)\n {\n-\tstruct device_driver *driver;\n-\tstruct device *parent;\n+\tconst struct device_driver *driver;\n+\tconst struct device *parent;\n \n \tif (len <= 0 || !buffer)\n \t\treturn buffer;\n", "prefixes": [ "1/2" ] }