Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1118876/?format=api
{ "id": 1118876, "url": "http://patchwork.ozlabs.org/api/patches/1118876/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190619165853.28234-1-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190619165853.28234-1-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2019-06-19T16:58:53", "name": "[net] ixgbevf: Use cached link state instead of re-reading the value for ethtool", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "968a92c23e96bed97e7210a539b7e406c3702c67", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190619165853.28234-1-jeffrey.t.kirsher@intel.com/mbox/", "series": [ { "id": 114883, "url": "http://patchwork.ozlabs.org/api/series/114883/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=114883", "date": "2019-06-19T16:58:53", "name": "[net] ixgbevf: Use cached link state instead of re-reading the value for ethtool", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/114883/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1118876/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1118876/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 45TWPT5mFwz9s5c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 20 Jun 2019 02:58:53 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3036485E24;\n\tWed, 19 Jun 2019 16:58:52 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Gubqs01wMzq7; Wed, 19 Jun 2019 16:58:50 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6364485DDC;\n\tWed, 19 Jun 2019 16:58:50 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 517DD1BF355\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 19 Jun 2019 16:58:49 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4B3CD86749\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 19 Jun 2019 16:58:49 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id aPbi+9dJbKp2 for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 19 Jun 2019 16:58:48 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 136C5813ED\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 19 Jun 2019 16:58:48 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Jun 2019 09:58:47 -0700", "from jtkirshe-desk1.jf.intel.com ([134.134.177.96])\n\tby fmsmga004.fm.intel.com with ESMTP; 19 Jun 2019 09:58:47 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,392,1557212400\"; d=\"scan'208\";a=\"182800649\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 19 Jun 2019 09:58:53 -0700", "Message-Id": "<20190619165853.28234-1-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [net] ixgbevf: Use cached link state instead of\n\tre-reading the value for ethtool", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Alexander Duyck <alexander.h.duyck@linux.intel.com>,\n\tGuilherme Piccoli <gpiccoli@canonical.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@linux.intel.com>\n\nChange the ethtool link settings call to just read the cached state out of\nthe adapter structure instead of trying to recheck the value from the PF.\nDoing this should prevent excessive reading of the mailbox.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>\nReviewed-by: Guilherme Piccoli <gpiccoli@canonical.com>\n---\n drivers/net/ethernet/intel/ixgbevf/ethtool.c | 10 ++--------\n 1 file changed, 2 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ethtool.c b/drivers/net/ethernet/intel/ixgbevf/ethtool.c\nindex 5399787e07af..54459b69c948 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ethtool.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ethtool.c\n@@ -85,22 +85,16 @@ static int ixgbevf_get_link_ksettings(struct net_device *netdev,\n \t\t\t\t struct ethtool_link_ksettings *cmd)\n {\n \tstruct ixgbevf_adapter *adapter = netdev_priv(netdev);\n-\tstruct ixgbe_hw *hw = &adapter->hw;\n-\tu32 link_speed = 0;\n-\tbool link_up;\n \n \tethtool_link_ksettings_zero_link_mode(cmd, supported);\n \tethtool_link_ksettings_add_link_mode(cmd, supported, 10000baseT_Full);\n \tcmd->base.autoneg = AUTONEG_DISABLE;\n \tcmd->base.port = -1;\n \n-\thw->mac.get_link_status = 1;\n-\thw->mac.ops.check_link(hw, &link_speed, &link_up, false);\n-\n-\tif (link_up) {\n+\tif (adapter->link_up) {\n \t\t__u32 speed = SPEED_10000;\n \n-\t\tswitch (link_speed) {\n+\t\tswitch (adapter->link_speed) {\n \t\tcase IXGBE_LINK_SPEED_10GB_FULL:\n \t\t\tspeed = SPEED_10000;\n \t\t\tbreak;\n", "prefixes": [ "net" ] }